| Message ID | 1593079768-9349-1-git-send-email-claudiu.beznea@microchip.com (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Headers | show |
| Series | [1/2] clk: at91: remove the checking of parent_name | expand |
On 25/06/2020 13:09:27+0300, Claudiu Beznea wrote: > There is no need to check parent_name variable while assigning it to > init.parent_names. parent_name variable is already checked at > the beginning of at91_clk_register_sam9x5_peripheral() function. > Same thing with init.num_parents: it could only be 1. > > Fixes: 6114067e437eb ("clk: at91: add PMC peripheral clocks") > Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com> Reviewed-by: Alexandre Belloni <alexandre.belloni@bootlin.com> > --- > drivers/clk/at91/clk-peripheral.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/clk/at91/clk-peripheral.c b/drivers/clk/at91/clk-peripheral.c > index c2ab4860a2bf..4a0f40738fe3 100644 > --- a/drivers/clk/at91/clk-peripheral.c > +++ b/drivers/clk/at91/clk-peripheral.c > @@ -111,8 +111,8 @@ at91_clk_register_peripheral(struct regmap *regmap, const char *name, > > init.name = name; > init.ops = &peripheral_ops; > - init.parent_names = (parent_name ? &parent_name : NULL); > - init.num_parents = (parent_name ? 1 : 0); > + init.parent_names = &parent_name; > + init.num_parents = 1; > init.flags = 0; > > periph->id = id; > @@ -340,8 +340,8 @@ at91_clk_register_sam9x5_peripheral(struct regmap *regmap, spinlock_t *lock, > > init.name = name; > init.ops = &sam9x5_peripheral_ops; > - init.parent_names = (parent_name ? &parent_name : NULL); > - init.num_parents = (parent_name ? 1 : 0); > + init.parent_names = &parent_name; > + init.num_parents = 1; > init.flags = 0; > > periph->id = id; > -- > 2.7.4 >
diff --git a/drivers/clk/at91/clk-peripheral.c b/drivers/clk/at91/clk-peripheral.c index c2ab4860a2bf..4a0f40738fe3 100644 --- a/drivers/clk/at91/clk-peripheral.c +++ b/drivers/clk/at91/clk-peripheral.c @@ -111,8 +111,8 @@ at91_clk_register_peripheral(struct regmap *regmap, const char *name, init.name = name; init.ops = &peripheral_ops; - init.parent_names = (parent_name ? &parent_name : NULL); - init.num_parents = (parent_name ? 1 : 0); + init.parent_names = &parent_name; + init.num_parents = 1; init.flags = 0; periph->id = id; @@ -340,8 +340,8 @@ at91_clk_register_sam9x5_peripheral(struct regmap *regmap, spinlock_t *lock, init.name = name; init.ops = &sam9x5_peripheral_ops; - init.parent_names = (parent_name ? &parent_name : NULL); - init.num_parents = (parent_name ? 1 : 0); + init.parent_names = &parent_name; + init.num_parents = 1; init.flags = 0; periph->id = id;
There is no need to check parent_name variable while assigning it to init.parent_names. parent_name variable is already checked at the beginning of at91_clk_register_sam9x5_peripheral() function. Same thing with init.num_parents: it could only be 1. Fixes: 6114067e437eb ("clk: at91: add PMC peripheral clocks") Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com> --- drivers/clk/at91/clk-peripheral.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)