[RFC] iwlwifi: yoyo: don't print failure if debug firmware is missing
diff mbox series

Message ID 20200625165210.14904-1-wsa@kernel.org
State Accepted
Commit 3f4600de8c93917594a8b3c9ca713160ee4d563c
Delegated to: Kalle Valo
Headers show
Series
  • [RFC] iwlwifi: yoyo: don't print failure if debug firmware is missing
Related show

Commit Message

Wolfram Sang June 25, 2020, 4:52 p.m. UTC
Missing this firmware is not fatal, my wifi card still works. Even more,
I couldn't find any documentation what it is or where to get it. So, I
don't think the users should be notified if it is missing. If you browse
the net, you see the message is present is in quite some logs. Better
remove it.

Signed-off-by: Wolfram Sang <wsa@kernel.org>
---

This is only build tested because I wanted to get your opinions first. I
couldn't find any explanation about yoyo, so I am entering unknown
territory here.

 drivers/net/wireless/intel/iwlwifi/iwl-dbg-tlv.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Wolfram Sang July 26, 2020, 3:26 p.m. UTC | #1
On Thu, Jun 25, 2020 at 06:52:10PM +0200, Wolfram Sang wrote:
> Missing this firmware is not fatal, my wifi card still works. Even more,
> I couldn't find any documentation what it is or where to get it. So, I
> don't think the users should be notified if it is missing. If you browse
> the net, you see the message is present is in quite some logs. Better
> remove it.
> 
> Signed-off-by: Wolfram Sang <wsa@kernel.org>
> ---

Any input on this? Or people I should add to CC?

> 
> This is only build tested because I wanted to get your opinions first. I
> couldn't find any explanation about yoyo, so I am entering unknown
> territory here.
> 
>  drivers/net/wireless/intel/iwlwifi/iwl-dbg-tlv.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/wireless/intel/iwlwifi/iwl-dbg-tlv.c b/drivers/net/wireless/intel/iwlwifi/iwl-dbg-tlv.c
> index 7987a288917b..f180db2936e3 100644
> --- a/drivers/net/wireless/intel/iwlwifi/iwl-dbg-tlv.c
> +++ b/drivers/net/wireless/intel/iwlwifi/iwl-dbg-tlv.c
> @@ -468,7 +468,7 @@ void iwl_dbg_tlv_load_bin(struct device *dev, struct iwl_trans *trans)
>  	if (!iwlwifi_mod_params.enable_ini)
>  		return;
>  
> -	res = request_firmware(&fw, "iwl-debug-yoyo.bin", dev);
> +	res = firmware_request_nowarn(&fw, "iwl-debug-yoyo.bin", dev);
>  	if (res)
>  		return;
>  
> -- 
> 2.20.1
>
Kalle Valo July 26, 2020, 6:11 p.m. UTC | #2
Wolfram Sang <wsa@kernel.org> writes:

> On Thu, Jun 25, 2020 at 06:52:10PM +0200, Wolfram Sang wrote:
>> Missing this firmware is not fatal, my wifi card still works. Even more,
>> I couldn't find any documentation what it is or where to get it. So, I
>> don't think the users should be notified if it is missing. If you browse
>> the net, you see the message is present is in quite some logs. Better
>> remove it.
>> 
>> Signed-off-by: Wolfram Sang <wsa@kernel.org>
>> ---
>
> Any input on this? Or people I should add to CC?

This was discussed on another thread:

https://lkml.kernel.org/r/87mu3magfp.fsf@tynnyri.adurom.net

Unless Intel folks object I'm planning to take this to
wireless-drivers-next.
Wolfram Sang July 26, 2020, 6:24 p.m. UTC | #3
On Sun, Jul 26, 2020 at 09:11:25PM +0300, Kalle Valo wrote:
> Wolfram Sang <wsa@kernel.org> writes:
> 
> > On Thu, Jun 25, 2020 at 06:52:10PM +0200, Wolfram Sang wrote:
> >> Missing this firmware is not fatal, my wifi card still works. Even more,
> >> I couldn't find any documentation what it is or where to get it. So, I
> >> don't think the users should be notified if it is missing. If you browse
> >> the net, you see the message is present is in quite some logs. Better
> >> remove it.
> >> 
> >> Signed-off-by: Wolfram Sang <wsa@kernel.org>
> >> ---
> >
> > Any input on this? Or people I should add to CC?
> 
> This was discussed on another thread:
> 
> https://lkml.kernel.org/r/87mu3magfp.fsf@tynnyri.adurom.net
> 
> Unless Intel folks object I'm planning to take this to
> wireless-drivers-next.

Cool, thanks for the heads up!
Luciano Coelho July 27, 2020, 6:21 a.m. UTC | #4
On Sun, 2020-07-26 at 21:11 +0300, Kalle Valo wrote:
> Wolfram Sang <wsa@kernel.org> writes:
> 
> > On Thu, Jun 25, 2020 at 06:52:10PM +0200, Wolfram Sang wrote:
> > > Missing this firmware is not fatal, my wifi card still works. Even more,
> > > I couldn't find any documentation what it is or where to get it. So, I
> > > don't think the users should be notified if it is missing. If you browse
> > > the net, you see the message is present is in quite some logs. Better
> > > remove it.
> > > 
> > > Signed-off-by: Wolfram Sang <wsa@kernel.org>
> > > ---
> > 
> > Any input on this? Or people I should add to CC?
> 
> This was discussed on another thread:
> 
> https://lkml.kernel.org/r/87mu3magfp.fsf@tynnyri.adurom.net
> 
> Unless Intel folks object I'm planning to take this to
> wireless-drivers-next.

Yes, please, just go ahead and take it.  I have the same change in our
internal tree, but I didn't have the time to send it out due to my
vacations (from which I'm now back).

--
Cheers,
Luca.
Kalle Valo Aug. 2, 2020, 3:08 p.m. UTC | #5
Wolfram Sang <wsa@kernel.org> wrote:

> Missing this firmware is not fatal, my wifi card still works. Even more,
> I couldn't find any documentation what it is or where to get it. So, I
> don't think the users should be notified if it is missing. If you browse
> the net, you see the message is present is in quite some logs. Better
> remove it.
> 
> Signed-off-by: Wolfram Sang <wsa@kernel.org>

Patch applied to wireless-drivers-next.git, thanks.

3f4600de8c93 iwlwifi: yoyo: don't print failure if debug firmware is missing

Patch
diff mbox series

diff --git a/drivers/net/wireless/intel/iwlwifi/iwl-dbg-tlv.c b/drivers/net/wireless/intel/iwlwifi/iwl-dbg-tlv.c
index 7987a288917b..f180db2936e3 100644
--- a/drivers/net/wireless/intel/iwlwifi/iwl-dbg-tlv.c
+++ b/drivers/net/wireless/intel/iwlwifi/iwl-dbg-tlv.c
@@ -468,7 +468,7 @@  void iwl_dbg_tlv_load_bin(struct device *dev, struct iwl_trans *trans)
 	if (!iwlwifi_mod_params.enable_ini)
 		return;
 
-	res = request_firmware(&fw, "iwl-debug-yoyo.bin", dev);
+	res = firmware_request_nowarn(&fw, "iwl-debug-yoyo.bin", dev);
 	if (res)
 		return;