From patchwork Thu Jun 25 23:30:07 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Allison Henderson X-Patchwork-Id: 11626271 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id DB6CA1731 for ; Thu, 25 Jun 2020 23:30:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C34842081A for ; Thu, 25 Jun 2020 23:30:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="n7ANo9Iw" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728399AbgFYXav (ORCPT ); Thu, 25 Jun 2020 19:30:51 -0400 Received: from aserp2120.oracle.com ([141.146.126.78]:50618 "EHLO aserp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728350AbgFYXat (ORCPT ); Thu, 25 Jun 2020 19:30:49 -0400 Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 05PNS6I1151875 for ; Thu, 25 Jun 2020 23:30:48 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : subject : date : message-id : in-reply-to : references; s=corp-2020-01-29; bh=O7Cdu1eouBXv8teMzkeok6IL9nsMQz7S06S4i+LdmYY=; b=n7ANo9IwJGPWsU4Gk8dtyFzzimXhhqt/Bxw+iB89bWgYe6WioyaKNs7DoyPWdyoec+Qy b/srz4KCdaQkD3ZpW09XLQTxM33kU2G3JXHWZDqYGrSGQve0O4cg6p6RJ5z69DedsG8T bIBoIN+6cUb0X3a+zyIAlnUFw0dXlvFf41jIInJ06BtW7JTiXjTm+20ZXpTjpXHJmAR1 wKc7cKn45hmZvt8fH9hgMC/V8veLT/CPyDVcqd9X47W55nFf1QWURBEGxoIWqzXNyVrd aZ68DZbvBVnObH2CHeUte5F1TpQ57nR60LtA1PVukkTfZv6I0gqH1i2XYAx8N/du+Jcd 1A== Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by aserp2120.oracle.com with ESMTP id 31uusu3ae3-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Thu, 25 Jun 2020 23:30:48 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 05PNRS61015467 for ; Thu, 25 Jun 2020 23:30:47 GMT Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by userp3030.oracle.com with ESMTP id 31uurt9kuw-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Thu, 25 Jun 2020 23:30:47 +0000 Received: from abhmp0002.oracle.com (abhmp0002.oracle.com [141.146.116.8]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id 05PNUklH017531 for ; Thu, 25 Jun 2020 23:30:46 GMT Received: from localhost.localdomain (/67.1.142.158) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Thu, 25 Jun 2020 23:30:46 +0000 From: Allison Collins To: linux-xfs@vger.kernel.org Subject: [PATCH v10 14/25] xfs: Remove xfs_trans_roll in xfs_attr_node_removename Date: Thu, 25 Jun 2020 16:30:07 -0700 Message-Id: <20200625233018.14585-15-allison.henderson@oracle.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200625233018.14585-1-allison.henderson@oracle.com> References: <20200625233018.14585-1-allison.henderson@oracle.com> X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9663 signatures=668680 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 phishscore=0 mlxscore=0 spamscore=0 mlxlogscore=999 bulkscore=0 suspectscore=1 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2004280000 definitions=main-2006250136 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9663 signatures=668680 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=1 bulkscore=0 cotscore=-2147483648 malwarescore=0 mlxscore=0 clxscore=1015 lowpriorityscore=0 mlxlogscore=999 phishscore=0 priorityscore=1501 spamscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2004280000 definitions=main-2006250136 Sender: linux-xfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org The xfs_trans_roll in _removename is not needed because invalidating blocks is an incore-only change. This is analogous to the non-remote remove case where an entry is removed and a potential dabtree join occurs under the same transaction. Signed-off-by: Allison Collins Reviewed-by: Brian Foster --- fs/xfs/libxfs/xfs_attr.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/fs/xfs/libxfs/xfs_attr.c b/fs/xfs/libxfs/xfs_attr.c index 1a78023..f1becca 100644 --- a/fs/xfs/libxfs/xfs_attr.c +++ b/fs/xfs/libxfs/xfs_attr.c @@ -1148,10 +1148,6 @@ xfs_attr_node_removename( if (error) goto out; - error = xfs_trans_roll_inode(&args->trans, args->dp); - if (error) - goto out; - error = xfs_attr_rmtval_invalidate(args); if (error) return error;