[v10,15/26] xfsprogs: Remove xfs_trans_roll in xfs_attr_node_removename
diff mbox series

Message ID 20200625232848.14465-16-allison.henderson@oracle.com
State Superseded
Headers show
  • Delay Ready Attributes
Related show

Commit Message

Allison Collins June 25, 2020, 11:28 p.m. UTC
The xfs_trans_roll in _removename is not needed because invalidating
blocks is an incore-only change.  This is analogous to the non-remote
remove case where an entry is removed and a potential dabtree join
occurs under the same transaction.

Signed-off-by: Allison Collins <allison.henderson@oracle.com>
 libxfs/xfs_attr.c | 4 ----
 1 file changed, 4 deletions(-)

diff mbox series

diff --git a/libxfs/xfs_attr.c b/libxfs/xfs_attr.c
index 0b81bf5..a743900 100644
--- a/libxfs/xfs_attr.c
+++ b/libxfs/xfs_attr.c
@@ -1148,10 +1148,6 @@  xfs_attr_node_removename(
 		if (error)
 			goto out;
-		error = xfs_trans_roll_inode(&args->trans, args->dp);
-		if (error)
-			goto out;
 		error = xfs_attr_rmtval_invalidate(args);
 		if (error)
 			return error;