diff mbox series

[2/7] dcssblk: don't set bd_block_size in ->open

Message ID 20200626080158.1998621-3-hch@lst.de (mailing list archive)
State New, archived
Headers show
Series [1/7] floppy: use block_size | expand

Commit Message

Christoph Hellwig June 26, 2020, 8:01 a.m. UTC 
bd_block_size contains a value that matches the logic block size when
opening, so the statement is redundant.  Even if it wasn't the dumb
assignment would cause a a mismatch with bd_inode->i_blkbits.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 drivers/s390/block/dcssblk.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Johannes Thumshirn June 26, 2020, 3:54 p.m. UTC | #1 
Looks good,
Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
diff mbox series

Patch

diff --git a/drivers/s390/block/dcssblk.c b/drivers/s390/block/dcssblk.c
index 384edffe5cb4ae..9c22c6078a4662 100644
--- a/drivers/s390/block/dcssblk.c
+++ b/drivers/s390/block/dcssblk.c
@@ -833,7 +833,6 @@  dcssblk_open(struct block_device *bdev, fmode_t mode)
 		goto out;
 	}
 	atomic_inc(&dev_info->use_count);
-	bdev->bd_block_size = 4096;
 	rc = 0;
 out:
 	return rc;