| Message ID | 20200626120527.10562-1-jbx6244@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/2] net: stmmac: change Kconfig menu entry to STMMAC/DWMAC | expand |
From: Johan Jonker <jbx6244@gmail.com> Date: Fri, 26 Jun 2020 14:05:26 +0200 > When a Rockchip user wants to enable support for > the ethernet controller one has to search for > something with STMicroelectronics. > Change the Kconfig menu entry to STMMAC/DWMAC, > so that it better reflects the options it enables. > > Signed-off-by: Johan Jonker <jbx6244@gmail.com> I'm not OK with this. It's called internally stmmac beause it's based upon an ST Microelectronics chipset. This is what happens when we have several sub drivers based upon a top-level common chipset "library". The problem you have is that just knowing the driver doesn't tell you the dependencies, but that's a larger scope generic problem that needs a high level solution rather then something we should be hacking around with name adjustments here and there.
diff --git a/drivers/net/ethernet/stmicro/stmmac/Kconfig b/drivers/net/ethernet/stmicro/stmmac/Kconfig index 36bd2e18f..8f7625cc8 100644 --- a/drivers/net/ethernet/stmicro/stmmac/Kconfig +++ b/drivers/net/ethernet/stmicro/stmmac/Kconfig @@ -1,6 +1,6 @@ # SPDX-License-Identifier: GPL-2.0-only config STMMAC_ETH - tristate "STMicroelectronics Multi-Gigabit Ethernet driver" + tristate "STMMAC/DWMAC Multi-Gigabit Ethernet driver" depends on HAS_IOMEM && HAS_DMA select MII select MDIO_XPCS @@ -26,7 +26,7 @@ config STMMAC_SELFTESTS results to the netdev Mailing List. config STMMAC_PLATFORM - tristate "STMMAC Platform bus support" + tristate "STMMAC/DWMAC Platform bus support" depends on STMMAC_ETH select MFD_SYSCON default y
When a Rockchip user wants to enable support for the ethernet controller one has to search for something with STMicroelectronics. Change the Kconfig menu entry to STMMAC/DWMAC, so that it better reflects the options it enables. Signed-off-by: Johan Jonker <jbx6244@gmail.com> --- drivers/net/ethernet/stmicro/stmmac/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)