diff mbox series

[2/2] rtlwifi: 8821ae: remove unused path B parameters from swing table

Message ID 20200629032937.17374-2-pkshih@realtek.com (mailing list archive)
State Changes Requested
Delegated to: Kalle Valo
Headers show
Series [1/2] rtlwifi: Use const in 8188ee/8723be/8821ae swing_table declarations | expand

Commit Message

Ping-Ke Shih June 29, 2020, 3:29 a.m. UTC 
From: Ping-Ke Shih <pkshih@realtek.com>

8821AE is a 1x1 chip, so swing parameters for path B aren't necessary.

Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>
---
 .../wireless/realtek/rtlwifi/rtl8821ae/dm.c   | 22 ++-----------------
 1 file changed, 2 insertions(+), 20 deletions(-)

Comments

Joe Perches June 29, 2020, 5:21 a.m. UTC | #1 
On 2020-06-28 20:29, pkshih@realtek.com wrote:
> From: Ping-Ke Shih <pkshih@realtek.com>
> 
> 8821AE is a 1x1 chip, so swing parameters for path B aren't necessary.

Then all the now unused arrays could be removed as well.
---
  .../net/wireless/realtek/rtlwifi/rtl8821ae/dm.c    | 34 
----------------------
  1 file changed, 34 deletions(-)

diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/dm.c 
b/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/dm.c
index 194d56a98ef2..97a30ccf0b27 100644
--- a/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/dm.c
+++ b/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/dm.c
@@ -191,14 +191,6 @@ static const u8 
rtl8812ae_delta_swing_table_idx_5ga_p[][DEL_SW_IDX_SZ] = {
  	10, 10, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11},
  };

-static const u8 rtl8821ae_delta_swing_table_idx_24gb_n[] = {
-	0, 1, 1, 2, 2, 2, 3, 3, 3, 4, 4, 4, 5, 5, 5, 6, 6,
-	6, 7, 7, 7, 8, 8, 8, 9, 9, 9, 10, 10, 10};
-
-static const u8 rtl8821ae_delta_swing_table_idx_24gb_p[]  = {
-	0, 0, 1, 1, 2, 2, 3, 3, 4, 4, 5, 5, 6, 6, 7, 7, 8,
-	8, 9, 9, 10, 10, 11, 11, 12, 12, 12, 12, 12, 12};
-
  static const u8 rtl8821ae_delta_swing_table_idx_24ga_n[]  = {
  	0, 1, 1, 2, 2, 2, 3, 3, 3, 4, 4, 4, 5, 5, 5, 6, 6,
  	6, 7, 7, 7, 8, 8, 8, 9, 9, 9, 10, 10, 10};
@@ -207,14 +199,6 @@ static const u8 
rtl8821ae_delta_swing_table_idx_24ga_p[] = {
  	0, 0, 1, 1, 2, 2, 3, 3, 4, 4, 5, 5, 6, 6, 7, 7, 8,
  	8, 9, 9, 10, 10, 11, 11, 12, 12, 12, 12, 12, 12};

-static const u8 rtl8821ae_delta_swing_table_idx_24gcckb_n[] = {
-	0, 1, 1, 2, 2, 2, 3, 3, 3, 4, 4, 4, 5, 5, 5, 6, 6,
-	6, 7, 7, 7, 8, 8, 8, 9, 9, 9, 10, 10, 10};
-
-static const u8 rtl8821ae_delta_swing_table_idx_24gcckb_p[] = {
-	0, 0, 1, 1, 2, 2, 3, 3, 4, 4, 5, 5, 6, 6, 7, 7, 8,
-	8, 9, 9, 10, 10, 11, 11, 12, 12, 12, 12, 12, 12};
-
  static const u8 rtl8821ae_delta_swing_table_idx_24gccka_n[] = {
  	0, 1, 1, 2, 2, 2, 3, 3, 3, 4, 4, 4, 5, 5, 5, 6, 6,
  	6, 7, 7, 7, 8, 8, 8, 9, 9, 9, 10, 10, 10};
@@ -223,24 +207,6 @@ static const u8 
rtl8821ae_delta_swing_table_idx_24gccka_p[] = {
  	0, 0, 1, 1, 2, 2, 3, 3, 4, 4, 5, 5, 6, 6, 7, 7, 8,
  	8, 9, 9, 10, 10, 11, 11, 12, 12, 12, 12, 12, 12};

-static const u8 rtl8821ae_delta_swing_table_idx_5gb_n[][DEL_SW_IDX_SZ] 
= {
-	{0, 0, 1, 2, 3, 3, 4, 5, 6, 6, 7, 8, 9, 9, 10, 11,
-	12, 12, 13, 14, 15, 15, 16, 16, 16, 16, 16, 16, 16, 16},
-	{0, 0, 1, 2, 3, 3, 4, 5, 6, 6, 7, 8, 9, 9, 10, 11,
-	12, 12, 13, 14, 15, 15, 16, 16, 16, 16, 16, 16, 16, 16},
-	{0, 0, 1, 2, 3, 3, 4, 5, 6, 6, 7, 8, 9, 9, 10, 11,
-	12, 12, 13, 14, 15, 15, 16, 16, 16, 16, 16, 16, 16, 16},
-};
-
-static const u8 rtl8821ae_delta_swing_table_idx_5gb_p[][DEL_SW_IDX_SZ] 
= {
-	{0, 0, 1, 2, 3, 3, 4, 5, 6, 6, 7, 8, 9, 9, 10, 11,
-	12, 12, 13, 14, 15, 15, 16, 16, 16, 16, 16, 16, 16, 16},
-	{0, 0, 1, 2, 3, 3, 4, 5, 6, 6, 7, 8, 9, 9, 10, 11,
-	12, 12, 13, 14, 15, 15, 16, 16, 16, 16, 16, 16, 16, 16},
-	{0, 0, 1, 2, 3, 3, 4, 5, 6, 6, 7, 8, 9, 9, 10, 11,
-	12, 12, 13, 14, 15, 15, 16, 16, 16, 16, 16, 16, 16, 16},
-};
-
  static const u8 rtl8821ae_delta_swing_table_idx_5ga_n[][DEL_SW_IDX_SZ] 
= {
  	{0, 0, 1, 2, 3, 3, 4, 5, 6, 6, 7, 8, 9, 9, 10, 11,
  	12, 12, 13, 14, 15, 15, 16, 16, 16, 16, 16, 16, 16, 16},
Ping-Ke Shih June 29, 2020, 6:09 a.m. UTC | #2 
On Sun, 2020-06-28 at 22:21 -0700, Joe Perches wrote:
> On 2020-06-28 20:29, pkshih@realtek.com wrote:
> > From: Ping-Ke Shih <pkshih@realtek.com>
> > 
> > 8821AE is a 1x1 chip, so swing parameters for path B aren't necessary.
> 
> Then all the now unused arrays could be removed as well.
> 

My gcc doesn't warn this. Could I know how you find them?


I had sent v2, but I can't see it in patchwork.
If it still not there, I'll try to re-send v3 later.

---
Thank you
PK
Joe Perches June 29, 2020, 6:18 a.m. UTC | #3 
On Mon, 2020-06-29 at 06:09 +0000, Pkshih wrote:
> On Sun, 2020-06-28 at 22:21 -0700, Joe Perches wrote:
> > On 2020-06-28 20:29, pkshih@realtek.com wrote:
> > > From: Ping-Ke Shih <pkshih@realtek.com>
> > >  
> > > 8821AE is a 1x1 chip, so swing parameters for path B aren't necessary.
> > 
> > Then all the now unused arrays could be removed as well.
> > 
> My gcc doesn't warn this. Could I know how you find them?

Logic then inspection.
kernel test robot June 29, 2020, 5:03 p.m. UTC | #4 
Hi,

I love your patch! Perhaps something to improve:

[auto build test WARNING on wireless-drivers-next/master]
[also build test WARNING on wireless-drivers/master v5.8-rc3 next-20200629]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use  as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/pkshih-realtek-com/rtlwifi-Use-const-in-8188ee-8723be-8821ae-swing_table-declarations/20200629-113150
base:   https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git master
config: x86_64-allyesconfig (attached as .config)
compiler: clang version 11.0.0 (https://github.com/llvm/llvm-project a28d38a6bca1726d56c9b373f4c7dc5264fc7716)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install x86_64 cross compiling tool for clang build
        # apt-get install binutils-x86-64-linux-gnu
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/net/wireless/realtek/rtlwifi/rtl8821ae/dm.c:194:17: warning: unused variable 'rtl8821ae_delta_swing_table_idx_24gb_n' [-Wunused-const-variable]
   static const u8 rtl8821ae_delta_swing_table_idx_24gb_n[] = {
                   ^
>> drivers/net/wireless/realtek/rtlwifi/rtl8821ae/dm.c:198:17: warning: unused variable 'rtl8821ae_delta_swing_table_idx_24gb_p' [-Wunused-const-variable]
   static const u8 rtl8821ae_delta_swing_table_idx_24gb_p[]  = {
                   ^
>> drivers/net/wireless/realtek/rtlwifi/rtl8821ae/dm.c:210:17: warning: unused variable 'rtl8821ae_delta_swing_table_idx_24gcckb_n' [-Wunused-const-variable]
   static const u8 rtl8821ae_delta_swing_table_idx_24gcckb_n[] = {
                   ^
>> drivers/net/wireless/realtek/rtlwifi/rtl8821ae/dm.c:214:17: warning: unused variable 'rtl8821ae_delta_swing_table_idx_24gcckb_p' [-Wunused-const-variable]
   static const u8 rtl8821ae_delta_swing_table_idx_24gcckb_p[] = {
                   ^
>> drivers/net/wireless/realtek/rtlwifi/rtl8821ae/dm.c:226:17: warning: unused variable 'rtl8821ae_delta_swing_table_idx_5gb_n' [-Wunused-const-variable]
   static const u8 rtl8821ae_delta_swing_table_idx_5gb_n[][DEL_SW_IDX_SZ] = {
                   ^
>> drivers/net/wireless/realtek/rtlwifi/rtl8821ae/dm.c:235:17: warning: unused variable 'rtl8821ae_delta_swing_table_idx_5gb_p' [-Wunused-const-variable]
   static const u8 rtl8821ae_delta_swing_table_idx_5gb_p[][DEL_SW_IDX_SZ] = {
                   ^
   6 warnings generated.

vim +/rtl8821ae_delta_swing_table_idx_24gb_n +194 drivers/net/wireless/realtek/rtlwifi/rtl8821ae/dm.c

21e4b0726dc671 drivers/net/wireless/rtlwifi/rtl8821ae/dm.c         Larry Finger 2014-09-22  193  
961dc288f4ba1b drivers/net/wireless/realtek/rtlwifi/rtl8821ae/dm.c Joe Perches  2020-06-29 @194  static const u8 rtl8821ae_delta_swing_table_idx_24gb_n[] = {
21e4b0726dc671 drivers/net/wireless/rtlwifi/rtl8821ae/dm.c         Larry Finger 2014-09-22  195  	0, 1, 1, 2, 2, 2, 3, 3, 3, 4, 4, 4, 5, 5, 5, 6, 6,
21e4b0726dc671 drivers/net/wireless/rtlwifi/rtl8821ae/dm.c         Larry Finger 2014-09-22  196  	6, 7, 7, 7, 8, 8, 8, 9, 9, 9, 10, 10, 10};
21e4b0726dc671 drivers/net/wireless/rtlwifi/rtl8821ae/dm.c         Larry Finger 2014-09-22  197  
961dc288f4ba1b drivers/net/wireless/realtek/rtlwifi/rtl8821ae/dm.c Joe Perches  2020-06-29 @198  static const u8 rtl8821ae_delta_swing_table_idx_24gb_p[]  = {
21e4b0726dc671 drivers/net/wireless/rtlwifi/rtl8821ae/dm.c         Larry Finger 2014-09-22  199  	0, 0, 1, 1, 2, 2, 3, 3, 4, 4, 5, 5, 6, 6, 7, 7, 8,
21e4b0726dc671 drivers/net/wireless/rtlwifi/rtl8821ae/dm.c         Larry Finger 2014-09-22  200  	8, 9, 9, 10, 10, 11, 11, 12, 12, 12, 12, 12, 12};
21e4b0726dc671 drivers/net/wireless/rtlwifi/rtl8821ae/dm.c         Larry Finger 2014-09-22  201  
961dc288f4ba1b drivers/net/wireless/realtek/rtlwifi/rtl8821ae/dm.c Joe Perches  2020-06-29  202  static const u8 rtl8821ae_delta_swing_table_idx_24ga_n[]  = {
21e4b0726dc671 drivers/net/wireless/rtlwifi/rtl8821ae/dm.c         Larry Finger 2014-09-22  203  	0, 1, 1, 2, 2, 2, 3, 3, 3, 4, 4, 4, 5, 5, 5, 6, 6,
21e4b0726dc671 drivers/net/wireless/rtlwifi/rtl8821ae/dm.c         Larry Finger 2014-09-22  204  	6, 7, 7, 7, 8, 8, 8, 9, 9, 9, 10, 10, 10};
21e4b0726dc671 drivers/net/wireless/rtlwifi/rtl8821ae/dm.c         Larry Finger 2014-09-22  205  
961dc288f4ba1b drivers/net/wireless/realtek/rtlwifi/rtl8821ae/dm.c Joe Perches  2020-06-29  206  static const u8 rtl8821ae_delta_swing_table_idx_24ga_p[] = {
21e4b0726dc671 drivers/net/wireless/rtlwifi/rtl8821ae/dm.c         Larry Finger 2014-09-22  207  	0, 0, 1, 1, 2, 2, 3, 3, 4, 4, 5, 5, 6, 6, 7, 7, 8,
21e4b0726dc671 drivers/net/wireless/rtlwifi/rtl8821ae/dm.c         Larry Finger 2014-09-22  208  	8, 9, 9, 10, 10, 11, 11, 12, 12, 12, 12, 12, 12};
21e4b0726dc671 drivers/net/wireless/rtlwifi/rtl8821ae/dm.c         Larry Finger 2014-09-22  209  
961dc288f4ba1b drivers/net/wireless/realtek/rtlwifi/rtl8821ae/dm.c Joe Perches  2020-06-29 @210  static const u8 rtl8821ae_delta_swing_table_idx_24gcckb_n[] = {
21e4b0726dc671 drivers/net/wireless/rtlwifi/rtl8821ae/dm.c         Larry Finger 2014-09-22  211  	0, 1, 1, 2, 2, 2, 3, 3, 3, 4, 4, 4, 5, 5, 5, 6, 6,
21e4b0726dc671 drivers/net/wireless/rtlwifi/rtl8821ae/dm.c         Larry Finger 2014-09-22  212  	6, 7, 7, 7, 8, 8, 8, 9, 9, 9, 10, 10, 10};
21e4b0726dc671 drivers/net/wireless/rtlwifi/rtl8821ae/dm.c         Larry Finger 2014-09-22  213  
961dc288f4ba1b drivers/net/wireless/realtek/rtlwifi/rtl8821ae/dm.c Joe Perches  2020-06-29 @214  static const u8 rtl8821ae_delta_swing_table_idx_24gcckb_p[] = {
21e4b0726dc671 drivers/net/wireless/rtlwifi/rtl8821ae/dm.c         Larry Finger 2014-09-22  215  	0, 0, 1, 1, 2, 2, 3, 3, 4, 4, 5, 5, 6, 6, 7, 7, 8,
21e4b0726dc671 drivers/net/wireless/rtlwifi/rtl8821ae/dm.c         Larry Finger 2014-09-22  216  	8, 9, 9, 10, 10, 11, 11, 12, 12, 12, 12, 12, 12};
21e4b0726dc671 drivers/net/wireless/rtlwifi/rtl8821ae/dm.c         Larry Finger 2014-09-22  217  
961dc288f4ba1b drivers/net/wireless/realtek/rtlwifi/rtl8821ae/dm.c Joe Perches  2020-06-29  218  static const u8 rtl8821ae_delta_swing_table_idx_24gccka_n[] = {
21e4b0726dc671 drivers/net/wireless/rtlwifi/rtl8821ae/dm.c         Larry Finger 2014-09-22  219  	0, 1, 1, 2, 2, 2, 3, 3, 3, 4, 4, 4, 5, 5, 5, 6, 6,
21e4b0726dc671 drivers/net/wireless/rtlwifi/rtl8821ae/dm.c         Larry Finger 2014-09-22  220  	6, 7, 7, 7, 8, 8, 8, 9, 9, 9, 10, 10, 10};
21e4b0726dc671 drivers/net/wireless/rtlwifi/rtl8821ae/dm.c         Larry Finger 2014-09-22  221  
961dc288f4ba1b drivers/net/wireless/realtek/rtlwifi/rtl8821ae/dm.c Joe Perches  2020-06-29  222  static const u8 rtl8821ae_delta_swing_table_idx_24gccka_p[] = {
21e4b0726dc671 drivers/net/wireless/rtlwifi/rtl8821ae/dm.c         Larry Finger 2014-09-22  223  	0, 0, 1, 1, 2, 2, 3, 3, 4, 4, 5, 5, 6, 6, 7, 7, 8,
21e4b0726dc671 drivers/net/wireless/rtlwifi/rtl8821ae/dm.c         Larry Finger 2014-09-22  224  	8, 9, 9, 10, 10, 11, 11, 12, 12, 12, 12, 12, 12};
21e4b0726dc671 drivers/net/wireless/rtlwifi/rtl8821ae/dm.c         Larry Finger 2014-09-22  225  
961dc288f4ba1b drivers/net/wireless/realtek/rtlwifi/rtl8821ae/dm.c Joe Perches  2020-06-29 @226  static const u8 rtl8821ae_delta_swing_table_idx_5gb_n[][DEL_SW_IDX_SZ] = {
21e4b0726dc671 drivers/net/wireless/rtlwifi/rtl8821ae/dm.c         Larry Finger 2014-09-22  227  	{0, 0, 1, 2, 3, 3, 4, 5, 6, 6, 7, 8, 9, 9, 10, 11,
21e4b0726dc671 drivers/net/wireless/rtlwifi/rtl8821ae/dm.c         Larry Finger 2014-09-22  228  	12, 12, 13, 14, 15, 15, 16, 16, 16, 16, 16, 16, 16, 16},
21e4b0726dc671 drivers/net/wireless/rtlwifi/rtl8821ae/dm.c         Larry Finger 2014-09-22  229  	{0, 0, 1, 2, 3, 3, 4, 5, 6, 6, 7, 8, 9, 9, 10, 11,
21e4b0726dc671 drivers/net/wireless/rtlwifi/rtl8821ae/dm.c         Larry Finger 2014-09-22  230  	12, 12, 13, 14, 15, 15, 16, 16, 16, 16, 16, 16, 16, 16},
21e4b0726dc671 drivers/net/wireless/rtlwifi/rtl8821ae/dm.c         Larry Finger 2014-09-22  231  	{0, 0, 1, 2, 3, 3, 4, 5, 6, 6, 7, 8, 9, 9, 10, 11,
21e4b0726dc671 drivers/net/wireless/rtlwifi/rtl8821ae/dm.c         Larry Finger 2014-09-22  232  	12, 12, 13, 14, 15, 15, 16, 16, 16, 16, 16, 16, 16, 16},
21e4b0726dc671 drivers/net/wireless/rtlwifi/rtl8821ae/dm.c         Larry Finger 2014-09-22  233  };
21e4b0726dc671 drivers/net/wireless/rtlwifi/rtl8821ae/dm.c         Larry Finger 2014-09-22  234  
961dc288f4ba1b drivers/net/wireless/realtek/rtlwifi/rtl8821ae/dm.c Joe Perches  2020-06-29 @235  static const u8 rtl8821ae_delta_swing_table_idx_5gb_p[][DEL_SW_IDX_SZ] = {
21e4b0726dc671 drivers/net/wireless/rtlwifi/rtl8821ae/dm.c         Larry Finger 2014-09-22  236  	{0, 0, 1, 2, 3, 3, 4, 5, 6, 6, 7, 8, 9, 9, 10, 11,
21e4b0726dc671 drivers/net/wireless/rtlwifi/rtl8821ae/dm.c         Larry Finger 2014-09-22  237  	12, 12, 13, 14, 15, 15, 16, 16, 16, 16, 16, 16, 16, 16},
21e4b0726dc671 drivers/net/wireless/rtlwifi/rtl8821ae/dm.c         Larry Finger 2014-09-22  238  	{0, 0, 1, 2, 3, 3, 4, 5, 6, 6, 7, 8, 9, 9, 10, 11,
21e4b0726dc671 drivers/net/wireless/rtlwifi/rtl8821ae/dm.c         Larry Finger 2014-09-22  239  	12, 12, 13, 14, 15, 15, 16, 16, 16, 16, 16, 16, 16, 16},
21e4b0726dc671 drivers/net/wireless/rtlwifi/rtl8821ae/dm.c         Larry Finger 2014-09-22  240  	{0, 0, 1, 2, 3, 3, 4, 5, 6, 6, 7, 8, 9, 9, 10, 11,
21e4b0726dc671 drivers/net/wireless/rtlwifi/rtl8821ae/dm.c         Larry Finger 2014-09-22  241  	12, 12, 13, 14, 15, 15, 16, 16, 16, 16, 16, 16, 16, 16},
21e4b0726dc671 drivers/net/wireless/rtlwifi/rtl8821ae/dm.c         Larry Finger 2014-09-22  242  };
21e4b0726dc671 drivers/net/wireless/rtlwifi/rtl8821ae/dm.c         Larry Finger 2014-09-22  243  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
diff mbox series

Patch

diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/dm.c b/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/dm.c
index e8fb9354cf19..194d56a98ef2 100644
--- a/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/dm.c
+++ b/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/dm.c
@@ -1834,9 +1834,7 @@  void rtl8812ae_dm_txpower_tracking_callback_thermalmeter(
 
 static void rtl8821ae_get_delta_swing_table(struct ieee80211_hw *hw,
 					    const u8 **up_a,
-					    const u8 **down_a,
-					    const u8 **up_b,
-					    const u8 **down_b)
+					    const u8 **down_a)
 {
 	struct rtl_priv *rtlpriv = rtl_priv(hw);
 	struct rtl_phy *rtlphy = &rtlpriv->phy;
@@ -1848,34 +1846,22 @@  static void rtl8821ae_get_delta_swing_table(struct ieee80211_hw *hw,
 		if (RTL8821AE_RX_HAL_IS_CCK_RATE(rate)) {
 			*up_a = rtl8821ae_delta_swing_table_idx_24gccka_p;
 			*down_a = rtl8821ae_delta_swing_table_idx_24gccka_n;
-			*up_b = rtl8821ae_delta_swing_table_idx_24gcckb_p;
-			*down_b = rtl8821ae_delta_swing_table_idx_24gcckb_n;
 		} else {
 			*up_a = rtl8821ae_delta_swing_table_idx_24ga_p;
 			*down_a = rtl8821ae_delta_swing_table_idx_24ga_n;
-			*up_b = rtl8821ae_delta_swing_table_idx_24gb_p;
-			*down_b = rtl8821ae_delta_swing_table_idx_24gb_n;
 		}
 	} else if (36 <= channel && channel <= 64) {
 		*up_a = rtl8821ae_delta_swing_table_idx_5ga_p[0];
 		*down_a = rtl8821ae_delta_swing_table_idx_5ga_n[0];
-		*up_b = rtl8821ae_delta_swing_table_idx_5gb_p[0];
-		*down_b = rtl8821ae_delta_swing_table_idx_5gb_n[0];
 	} else if (100 <= channel && channel <= 140) {
 		*up_a = rtl8821ae_delta_swing_table_idx_5ga_p[1];
 		*down_a = rtl8821ae_delta_swing_table_idx_5ga_n[1];
-		*up_b = rtl8821ae_delta_swing_table_idx_5gb_p[1];
-		*down_b = rtl8821ae_delta_swing_table_idx_5gb_n[1];
 	} else if (149 <= channel && channel <= 173) {
 		*up_a = rtl8821ae_delta_swing_table_idx_5ga_p[2];
 		*down_a = rtl8821ae_delta_swing_table_idx_5ga_n[2];
-		*up_b = rtl8821ae_delta_swing_table_idx_5gb_p[2];
-		*down_b = rtl8821ae_delta_swing_table_idx_5gb_n[2];
 	} else {
 		*up_a = rtl8818e_delta_swing_table_idx_24gb_p;
 		*down_a = rtl8818e_delta_swing_table_idx_24gb_n;
-		*up_b = rtl8818e_delta_swing_table_idx_24gb_p;
-		*down_b = rtl8818e_delta_swing_table_idx_24gb_n;
 	}
 	return;
 }
@@ -2082,15 +2068,11 @@  void rtl8821ae_dm_txpower_tracking_callback_thermalmeter(
 	 */
 	const u8 *delta_swing_table_idx_tup_a;
 	const u8 *delta_swing_table_idx_tdown_a;
-	const u8 *delta_swing_table_idx_tup_b;
-	const u8 *delta_swing_table_idx_tdown_b;
 
 	/*2. Initilization ( 7 steps in total )*/
 	rtl8821ae_get_delta_swing_table(hw,
 					&delta_swing_table_idx_tup_a,
-					&delta_swing_table_idx_tdown_a,
-					&delta_swing_table_idx_tup_b,
-					&delta_swing_table_idx_tdown_b);
+					&delta_swing_table_idx_tdown_a);
 
 	rtldm->txpower_trackinginit = true;