diff mbox series

[RFT,3/3] arm64: dts: exynos: Add unit address to soc node and move thermal zones on Exynos7

Message ID 20200629193338.29540-3-krzk@kernel.org (mailing list archive)
State Accepted
Headers show
Series [1/3] ARM: dts: exynos: Fix missing empty reg/ranges property regulators on Trats | expand

Commit Message

Krzysztof Kozlowski June 29, 2020, 7:33 p.m. UTC
Add @0 unit address to 'soc' node match its 'reg' property and move the
thermal zones out of 'soc' to main root as it this is usually not a
property of a Soc.

This silences DTC warnings:

    Warning (unit_address_vs_reg): /soc: node has a reg or ranges property, but no unit name
    Warning (simple_bus_reg): /soc/thermal-zones: missing or empty reg/ranges property

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>

---

Not tested on HW.
---
 arch/arm64/boot/dts/exynos/exynos7.dtsi | 20 ++++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)

Comments

Krzysztof Kozlowski July 7, 2020, 6:46 a.m. UTC | #1
On Mon, Jun 29, 2020 at 09:33:38PM +0200, Krzysztof Kozlowski wrote:
> Add @0 unit address to 'soc' node match its 'reg' property and move the
> thermal zones out of 'soc' to main root as it this is usually not a
> property of a Soc.
> 
> This silences DTC warnings:
> 
>     Warning (unit_address_vs_reg): /soc: node has a reg or ranges property, but no unit name
>     Warning (simple_bus_reg): /soc/thermal-zones: missing or empty reg/ranges property
> 
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> 
> ---
> 
> Not tested on HW.
> ---
>  arch/arm64/boot/dts/exynos/exynos7.dtsi | 20 ++++++++++----------

Applied.

Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/exynos/exynos7.dtsi b/arch/arm64/boot/dts/exynos/exynos7.dtsi
index 300ad7326ea8..f590891efe25 100644
--- a/arch/arm64/boot/dts/exynos/exynos7.dtsi
+++ b/arch/arm64/boot/dts/exynos/exynos7.dtsi
@@ -83,7 +83,7 @@ 
 		method = "smc";
 	};
 
-	soc: soc {
+	soc: soc@0 {
 		compatible = "simple-bus";
 		#address-cells = <1>;
 		#size-cells = <1>;
@@ -597,15 +597,6 @@ 
 			#thermal-sensor-cells = <0>;
 		};
 
-		thermal-zones {
-			atlas_thermal: cluster0-thermal {
-				polling-delay-passive = <0>; /* milliseconds */
-				polling-delay = <0>; /* milliseconds */
-				thermal-sensors = <&tmuctrl_0>;
-				#include "exynos7-trip-points.dtsi"
-			};
-		};
-
 		ufs: ufs@15570000 {
 			compatible = "samsung,exynos7-ufs";
 			reg = <0x15570000 0x100>,  /* 0: HCI standard */
@@ -675,6 +666,15 @@ 
 		};
 	};
 
+	thermal-zones {
+		atlas_thermal: cluster0-thermal {
+			polling-delay-passive = <0>; /* milliseconds */
+			polling-delay = <0>; /* milliseconds */
+			thermal-sensors = <&tmuctrl_0>;
+			#include "exynos7-trip-points.dtsi"
+		};
+	};
+
 	timer {
 		compatible = "arm,armv8-timer";
 		interrupts = <GIC_PPI 13