dt-bindings: arm: samsung: Do not require clkout on Exynos5260 and Exynos7
diff mbox series

Message ID 20200629203859.17298-1-krzk@kernel.org
State Under Review
Headers show
Series
  • dt-bindings: arm: samsung: Do not require clkout on Exynos5260 and Exynos7
Related show

Commit Message

Krzysztof Kozlowski June 29, 2020, 8:38 p.m. UTC
The PMU (Power Management Unit) driver is a clkout clock provider (for
clock signal monitoring) only for certain Exynos SoCs.  It was never
implemented for Exynos5260 and Exynos7.  This fixes dtschema validator
warnings like:

    system-controller@105c0000: '#clock-cells' is a required property

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
 .../devicetree/bindings/arm/samsung/pmu.yaml  | 22 ++++++++++++++++---
 1 file changed, 19 insertions(+), 3 deletions(-)

Comments

Rob Herring July 15, 2020, 8:27 p.m. UTC | #1
On Mon, 29 Jun 2020 22:38:59 +0200, Krzysztof Kozlowski wrote:
> The PMU (Power Management Unit) driver is a clkout clock provider (for
> clock signal monitoring) only for certain Exynos SoCs.  It was never
> implemented for Exynos5260 and Exynos7.  This fixes dtschema validator
> warnings like:
> 
>     system-controller@105c0000: '#clock-cells' is a required property
> 
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
>  .../devicetree/bindings/arm/samsung/pmu.yaml  | 22 ++++++++++++++++---
>  1 file changed, 19 insertions(+), 3 deletions(-)
> 

Reviewed-by: Rob Herring <robh@kernel.org>

Patch
diff mbox series

diff --git a/Documentation/devicetree/bindings/arm/samsung/pmu.yaml b/Documentation/devicetree/bindings/arm/samsung/pmu.yaml
index c9651892710e..686c13c14e32 100644
--- a/Documentation/devicetree/bindings/arm/samsung/pmu.yaml
+++ b/Documentation/devicetree/bindings/arm/samsung/pmu.yaml
@@ -85,12 +85,28 @@  properties:
 required:
   - compatible
   - reg
-  - '#clock-cells'
-  - clock-names
-  - clocks
 
 additionalProperties: false
 
+allOf:
+  - if:
+      properties:
+        compatible:
+          contains:
+            enum:
+              - samsung,exynos3250-pmu
+              - samsung,exynos4210-pmu
+              - samsung,exynos4412-pmu
+              - samsung,exynos5250-pmu
+              - samsung,exynos5410-pmu
+              - samsung,exynos5420-pmu
+              - samsung,exynos5433-pmu
+    then:
+      required:
+        - '#clock-cells'
+        - clock-names
+        - clocks
+
 examples:
   - |
     #include <dt-bindings/clock/exynos5250.h>