[3/4] arm64: dts: exynos: Align DMA controller bus node name with dtschema
diff mbox series

Message ID 20200629204442.17336-3-krzk@kernel.org
State Superseded
Headers show
Series
  • [1/4] arm64: dts: exynos: Add PWM interrupts on Exynos7
Related show

Commit Message

Krzysztof Kozlowski June 29, 2020, 8:44 p.m. UTC
AMBA is a bus so name the node with DMA controllers just as "bus" to fix
dtschema warnings like:

    amba: $nodename:0: 'amba' does not match '^(bus|soc|axi|ahb|apb)(@[0-9a-f]+)?$'

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>

---

Not tested although no effect expected.
---
 arch/arm64/boot/dts/exynos/exynos5433.dtsi | 2 +-
 arch/arm64/boot/dts/exynos/exynos7.dtsi    | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

Comments

Marek Szyprowski June 30, 2020, 7:34 a.m. UTC | #1
Hi Krzysztof,

On 29.06.2020 22:44, Krzysztof Kozlowski wrote:
> AMBA is a bus so name the node with DMA controllers just as "bus" to fix
> dtschema warnings like:
>
>      amba: $nodename:0: 'amba' does not match '^(bus|soc|axi|ahb|apb)(@[0-9a-f]+)?$'
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>

Do we really need a separate 'bus' for those DMA controllers?

IMHO they are not different from the hw perspective from the other 
devices available on the SoC. A separate bus is a historical thing, they 
work fine when moved directly under the 'soc' node. The separate bus 
only mimics the way Linux organizes its drivers. This comment affects 
both ARM and ARM64.

Best regards
Krzysztof Kozlowski July 2, 2020, 6:01 a.m. UTC | #2
On Tue, Jun 30, 2020 at 09:34:52AM +0200, Marek Szyprowski wrote:
> Hi Krzysztof,
> 
> On 29.06.2020 22:44, Krzysztof Kozlowski wrote:
> > AMBA is a bus so name the node with DMA controllers just as "bus" to fix
> > dtschema warnings like:
> >
> >      amba: $nodename:0: 'amba' does not match '^(bus|soc|axi|ahb|apb)(@[0-9a-f]+)?$'
> >
> > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> 
> Do we really need a separate 'bus' for those DMA controllers?
> 
> IMHO they are not different from the hw perspective from the other 
> devices available on the SoC. A separate bus is a historical thing, they 
> work fine when moved directly under the 'soc' node. The separate bus 
> only mimics the way Linux organizes its drivers. This comment affects 
> both ARM and ARM64.

Good point, other boards keep them under SoC usually. Thanks for
feedback.

Best regards,
Krzysztof

Patch
diff mbox series

diff --git a/arch/arm64/boot/dts/exynos/exynos5433.dtsi b/arch/arm64/boot/dts/exynos/exynos5433.dtsi
index 57b433a1c900..98e907115599 100644
--- a/arch/arm64/boot/dts/exynos/exynos5433.dtsi
+++ b/arch/arm64/boot/dts/exynos/exynos5433.dtsi
@@ -1756,7 +1756,7 @@ 
 			status = "disabled";
 		};
 
-		amba {
+		bus {
 			compatible = "simple-bus";
 			#address-cells = <1>;
 			#size-cells = <1>;
diff --git a/arch/arm64/boot/dts/exynos/exynos7.dtsi b/arch/arm64/boot/dts/exynos/exynos7.dtsi
index 96ed93a21e40..1e0acf6e17e2 100644
--- a/arch/arm64/boot/dts/exynos/exynos7.dtsi
+++ b/arch/arm64/boot/dts/exynos/exynos7.dtsi
@@ -105,7 +105,7 @@ 
 				<0x11006000 0x2000>;
 		};
 
-		amba {
+		bus {
 			compatible = "simple-bus";
 			#address-cells = <1>;
 			#size-cells = <1>;