| Message ID | 20200630103739.9715-4-philmd@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | hw/block/nvme: Fix I/O BAR structure | expand |
On Jun 30 12:37, Philippe Mathieu-Daudé wrote: > The Persistent Memory Region Controller Memory Space Control > register is 64-bit wide. See 'Figure 68: Register Definition' > of the 'NVM Express Base Specification Revision 1.4'. > > Fixes: 6cf9413229 ("introduce PMR support from NVMe 1.4 spec") > Reported-by: Klaus Jensen <its@irrelevant.dk> > Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> (if possible, please change the Reported-by to my Samsung address) Reviewed-by: Klaus Jensen <k.jensen@samsung.com> > --- > Cc: Andrzej Jakowski <andrzej.jakowski@linux.intel.com> > Cc: Keith Busch <kbusch@kernel.org> > --- > include/block/nvme.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/block/nvme.h b/include/block/nvme.h > index 71c5681912..82c384614a 100644 > --- a/include/block/nvme.h > +++ b/include/block/nvme.h > @@ -21,7 +21,7 @@ typedef struct QEMU_PACKED NvmeBar { > uint32_t pmrsts; > uint32_t pmrebs; > uint32_t pmrswtp; > - uint32_t pmrmsc; > + uint64_t pmrmsc; > } NvmeBar; > > enum NvmeCapShift { > -- > 2.21.3 > >
diff --git a/include/block/nvme.h b/include/block/nvme.h index 71c5681912..82c384614a 100644 --- a/include/block/nvme.h +++ b/include/block/nvme.h @@ -21,7 +21,7 @@ typedef struct QEMU_PACKED NvmeBar { uint32_t pmrsts; uint32_t pmrebs; uint32_t pmrswtp; - uint32_t pmrmsc; + uint64_t pmrmsc; } NvmeBar; enum NvmeCapShift {
The Persistent Memory Region Controller Memory Space Control register is 64-bit wide. See 'Figure 68: Register Definition' of the 'NVM Express Base Specification Revision 1.4'. Fixes: 6cf9413229 ("introduce PMR support from NVMe 1.4 spec") Reported-by: Klaus Jensen <its@irrelevant.dk> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> --- Cc: Andrzej Jakowski <andrzej.jakowski@linux.intel.com> Cc: Keith Busch <kbusch@kernel.org> --- include/block/nvme.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)