[2/4] iscsi class: delay freeing target_id
diff mbox series

Message ID 1593560134-28148-3-git-send-email-michael.christie@oracle.com
State Accepted
Headers show
  • iscsi fixes/cleanups
Related show

Commit Message

Mike Christie June 30, 2020, 11:35 p.m. UTC
If we are doing async removal of the session, we could be doing a
scsi_remove_target from the removal workqueue, and for the offload
case we could be doing a new session addition and scan to the same
host. The add/scan might then end up trying to use the target_id
of the target we are removing.

This patch just has a delay the freeing of the target_id until after
the scsi_remove_target has completed, so we know it's no longer in

Signed-off-by: Mike Christie <michael.christie@oracle.com>
 drivers/scsi/scsi_transport_iscsi.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff mbox series

diff --git a/drivers/scsi/scsi_transport_iscsi.c b/drivers/scsi/scsi_transport_iscsi.c
index bbf2eb7..2be28d8 100644
--- a/drivers/scsi/scsi_transport_iscsi.c
+++ b/drivers/scsi/scsi_transport_iscsi.c
@@ -2037,11 +2037,11 @@  static void __iscsi_unbind_session(struct work_struct *work)
 	spin_unlock_irqrestore(&session->lock, flags);
+	scsi_remove_target(&session->dev);
 	if (session->ida_used)
 		ida_simple_remove(&iscsi_sess_ida, target_id);
-	scsi_remove_target(&session->dev);
 	iscsi_session_event(session, ISCSI_KEVENT_UNBIND_SESSION);
 	ISCSI_DBG_TRANS_SESSION(session, "Completed target removal\n");