drm/msm: ratelimit crtc event overflow error
diff mbox series

Message ID 20200701203602.1272157-1-robdclark@gmail.com
State New
Headers show
Series
  • drm/msm: ratelimit crtc event overflow error
Related show

Commit Message

Rob Clark July 1, 2020, 8:36 p.m. UTC
From: Rob Clark <robdclark@chromium.org>

This can happen a lot when things go pear shaped.  Lets not flood dmesg
when this happens.

Signed-off-by: Rob Clark <robdclark@chromium.org>
---
 drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Abhinav Kumar July 1, 2020, 10:51 p.m. UTC | #1
On 2020-07-01 13:36, Rob Clark wrote:
> From: Rob Clark <robdclark@chromium.org>
> 
> This can happen a lot when things go pear shaped.  Lets not flood dmesg
> when this happens.
> 
> Signed-off-by: Rob Clark <robdclark@chromium.org>
Reviewed-by: Abhinav Kumar <abhinavk@codeaurora.org>
> ---
>  drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c
> b/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c
> index e15b42a780e0..969d95aa873c 100644
> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c
> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c
> @@ -389,7 +389,7 @@ static void dpu_crtc_frame_event_cb(void *data, u32 
> event)
>  	spin_unlock_irqrestore(&dpu_crtc->spin_lock, flags);
> 
>  	if (!fevent) {
> -		DRM_ERROR("crtc%d event %d overflow\n", crtc->base.id, event);
> +		DRM_ERROR_RATELIMITED("crtc%d event %d overflow\n", crtc->base.id, 
> event);
>  		return;
>  	}

Patch
diff mbox series

diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c
index e15b42a780e0..969d95aa873c 100644
--- a/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c
+++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c
@@ -389,7 +389,7 @@  static void dpu_crtc_frame_event_cb(void *data, u32 event)
 	spin_unlock_irqrestore(&dpu_crtc->spin_lock, flags);
 
 	if (!fevent) {
-		DRM_ERROR("crtc%d event %d overflow\n", crtc->base.id, event);
+		DRM_ERROR_RATELIMITED("crtc%d event %d overflow\n", crtc->base.id, event);
 		return;
 	}