[-next] sound: fix SND_HDA_GENERIC kconfig & build
diff mbox series

Message ID 01233744-9625-38b3-0342-1b37250dbc72@infradead.org
State New
Headers show
Series
  • [-next] sound: fix SND_HDA_GENERIC kconfig & build
Related show

Commit Message

Randy Dunlap July 1, 2020, 9:08 p.m. UTC
From: Randy Dunlap <rdunlap@infradead.org>

Fix kconfig warnings and lots of subsequent build errors by
adding yet another ugly select statement:

WARNING: unmet direct dependencies detected for LEDS_CLASS
  Depends on [n]: NEW_LEDS [=n]
  Selected by [y]:
  - SND_HDA_GENERIC [=y] && SOUND [=y] && !UML && SND [=y] && SND_HDA [=y] && SND_HDA_GENERIC_LEDS [=y]

WARNING: unmet direct dependencies detected for LEDS_TRIGGERS
  Depends on [n]: NEW_LEDS [=n] && LEDS_CLASS [=y]
  Selected by [y]:
  - SND_HDA_GENERIC [=y] && SOUND [=y] && !UML && SND [=y] && SND_HDA [=y] && SND_HDA_GENERIC_LEDS [=y]
  Selected by [m]:
  - MAC80211_LEDS [=y] && NET [=y] && WIRELESS [=y] && MAC80211 [=m] && LEDS_CLASS [=y]
  - IWLWIFI_LEDS [=y] && NETDEVICES [=y] && WLAN [=y] && WLAN_VENDOR_INTEL [=y] && IWLWIFI [=m] && (LEDS_CLASS [=y]=y || LEDS_CLASS [=y]=IWLWIFI [=m]) && (IWLMVM [=m] || IWLDVM [=m])

WARNING: unmet direct dependencies detected for LEDS_TRIGGER_AUDIO
  Depends on [n]: NEW_LEDS [=n] && LEDS_TRIGGERS [=y]
  Selected by [y]:
  - SND_HDA_GENERIC [=y] && SOUND [=y] && !UML && SND [=y] && SND_HDA [=y] && SND_HDA_GENERIC_LEDS [=y]

Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Jaroslav Kysela <perex@perex.cz>
Cc: Takashi Iwai <tiwai@suse.com>
Cc: alsa-devel@alsa-project.org
---
 sound/pci/hda/Kconfig |    1 +
 1 file changed, 1 insertion(+)

Comments

Takashi Iwai July 7, 2020, 8:26 a.m. UTC | #1
On Wed, 01 Jul 2020 23:08:23 +0200,
Randy Dunlap wrote:
> 
> From: Randy Dunlap <rdunlap@infradead.org>
> 
> Fix kconfig warnings and lots of subsequent build errors by
> adding yet another ugly select statement:
> 
> WARNING: unmet direct dependencies detected for LEDS_CLASS
>   Depends on [n]: NEW_LEDS [=n]
>   Selected by [y]:
>   - SND_HDA_GENERIC [=y] && SOUND [=y] && !UML && SND [=y] && SND_HDA [=y] && SND_HDA_GENERIC_LEDS [=y]
> 
> WARNING: unmet direct dependencies detected for LEDS_TRIGGERS
>   Depends on [n]: NEW_LEDS [=n] && LEDS_CLASS [=y]
>   Selected by [y]:
>   - SND_HDA_GENERIC [=y] && SOUND [=y] && !UML && SND [=y] && SND_HDA [=y] && SND_HDA_GENERIC_LEDS [=y]
>   Selected by [m]:
>   - MAC80211_LEDS [=y] && NET [=y] && WIRELESS [=y] && MAC80211 [=m] && LEDS_CLASS [=y]
>   - IWLWIFI_LEDS [=y] && NETDEVICES [=y] && WLAN [=y] && WLAN_VENDOR_INTEL [=y] && IWLWIFI [=m] && (LEDS_CLASS [=y]=y || LEDS_CLASS [=y]=IWLWIFI [=m]) && (IWLMVM [=m] || IWLDVM [=m])
> 
> WARNING: unmet direct dependencies detected for LEDS_TRIGGER_AUDIO
>   Depends on [n]: NEW_LEDS [=n] && LEDS_TRIGGERS [=y]
>   Selected by [y]:
>   - SND_HDA_GENERIC [=y] && SOUND [=y] && !UML && SND [=y] && SND_HDA [=y] && SND_HDA_GENERIC_LEDS [=y]
> 
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Jaroslav Kysela <perex@perex.cz>
> Cc: Takashi Iwai <tiwai@suse.com>
> Cc: alsa-devel@alsa-project.org

Applied now.  Thanks.


Takashi

Patch
diff mbox series

--- linux-next-20200701.orig/sound/pci/hda/Kconfig
+++ linux-next-20200701/sound/pci/hda/Kconfig
@@ -221,6 +221,7 @@  comment "Set to Y if you want auto-loadi
 
 config SND_HDA_GENERIC
 	tristate "Enable generic HD-audio codec parser"
+	select NEW_LEDS if SND_HDA_GENERIC_LEDS
 	select LEDS_CLASS if SND_HDA_GENERIC_LEDS
 	select LEDS_TRIGGERS if SND_HDA_GENERIC_LEDS
 	select LEDS_TRIGGER_AUDIO if SND_HDA_GENERIC_LEDS