[v2,11/14] drm/ast: Init cursors before creating modesetting structures
diff mbox series

Message ID 20200702115029.5281-12-tzimmermann@suse.de
State New
Headers show
  • drm/ast: Managed modesetting
Related show

Commit Message

Thomas Zimmermann July 2, 2020, 11:50 a.m. UTC
The cursor helpers reserve buffer objects in VRAM and update their
content. So although tied to modesetting, cursor helpers are more
of a memory manager. The modesetting's cursor plane requires this
functionality, so initialize cursors before modesetting.

While at it, also add an error check for ast_cursor_init().

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
 drivers/gpu/drm/ast/ast_mode.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff mbox series

diff --git a/drivers/gpu/drm/ast/ast_mode.c b/drivers/gpu/drm/ast/ast_mode.c
index 4724a38c001a..89d9ee0a9e81 100644
--- a/drivers/gpu/drm/ast/ast_mode.c
+++ b/drivers/gpu/drm/ast/ast_mode.c
@@ -1073,6 +1073,10 @@  int ast_mode_init(struct drm_device *dev)
 	struct ast_private *ast = to_ast_private(dev);
 	int ret;
+	ret = ast_cursor_init(ast);
+	if (ret)
+		return ret;
 	memset(&ast->primary_plane, 0, sizeof(ast->primary_plane));
 	ret = drm_universal_plane_init(dev, &ast->primary_plane, 0x01,
@@ -1098,7 +1102,6 @@  int ast_mode_init(struct drm_device *dev)
-	ast_cursor_init(ast);