| Message ID | 1593701576-28580-6-git-send-email-amittomer25@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Add MMC and DMA support for Actions S700 | expand |
On Thu, Jul 02, 2020 at 08:22:51PM +0530, Amit Singh Tomar wrote: > After commit 7cdf8446ed1d ("arm64: dts: actions: Add pinctrl node for > Actions Semi S700") following error has been observed while booting > Linux on Cubieboard7-lite(based on S700 SoC). > > [ 0.257415] pinctrl-s700 e01b0000.pinctrl: can't request region for > resource [mem 0xe01b0000-0xe01b0fff] > [ 0.266902] pinctrl-s700: probe of e01b0000.pinctrl failed with error -16 > > This is due to the fact that memory range for "sps" power domain controller > clashes with pinctrl. > > One way to fix it, is to limit pinctrl address range which is safe > to do as current pinctrl driver uses address range only up to 0x100. > > This commit limits the pinctrl address range to 0x100 so that it doesn't > conflict with sps range. > > Fixes: 7cdf8446ed1d ("arm64: dts: actions: Add pinctrl node for Actions > Semi S700") > > Suggested-by: Andre Przywara <andre.przywara@arm.com> > Signed-off-by: Amit Singh Tomar <amittomer25@gmail.com> Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> Thanks, Mani > --- > Changes since v4: > * Reordered it from 04/10 to 05/10. > Changes since v3: > * No change. > Changes since v2: > * this is no more don't merge and fixed > the broken S700 boot by limiting pinctrl > address range. > * Modified the subject to reflect the changes. > Changes since v1: > * No change. > Changes since RFC: > * kept as do not merge. > --- > arch/arm64/boot/dts/actions/s700.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/actions/s700.dtsi b/arch/arm64/boot/dts/actions/s700.dtsi > index 2006ad5424fa..f8eb72bb4125 100644 > --- a/arch/arm64/boot/dts/actions/s700.dtsi > +++ b/arch/arm64/boot/dts/actions/s700.dtsi > @@ -231,7 +231,7 @@ > > pinctrl: pinctrl@e01b0000 { > compatible = "actions,s700-pinctrl"; > - reg = <0x0 0xe01b0000 0x0 0x1000>; > + reg = <0x0 0xe01b0000 0x0 0x100>; > clocks = <&cmu CLK_GPIO>; > gpio-controller; > gpio-ranges = <&pinctrl 0 0 136>; > -- > 2.7.4 >
diff --git a/arch/arm64/boot/dts/actions/s700.dtsi b/arch/arm64/boot/dts/actions/s700.dtsi index 2006ad5424fa..f8eb72bb4125 100644 --- a/arch/arm64/boot/dts/actions/s700.dtsi +++ b/arch/arm64/boot/dts/actions/s700.dtsi @@ -231,7 +231,7 @@ pinctrl: pinctrl@e01b0000 { compatible = "actions,s700-pinctrl"; - reg = <0x0 0xe01b0000 0x0 0x1000>; + reg = <0x0 0xe01b0000 0x0 0x100>; clocks = <&cmu CLK_GPIO>; gpio-controller; gpio-ranges = <&pinctrl 0 0 136>;
After commit 7cdf8446ed1d ("arm64: dts: actions: Add pinctrl node for Actions Semi S700") following error has been observed while booting Linux on Cubieboard7-lite(based on S700 SoC). [ 0.257415] pinctrl-s700 e01b0000.pinctrl: can't request region for resource [mem 0xe01b0000-0xe01b0fff] [ 0.266902] pinctrl-s700: probe of e01b0000.pinctrl failed with error -16 This is due to the fact that memory range for "sps" power domain controller clashes with pinctrl. One way to fix it, is to limit pinctrl address range which is safe to do as current pinctrl driver uses address range only up to 0x100. This commit limits the pinctrl address range to 0x100 so that it doesn't conflict with sps range. Fixes: 7cdf8446ed1d ("arm64: dts: actions: Add pinctrl node for Actions Semi S700") Suggested-by: Andre Przywara <andre.przywara@arm.com> Signed-off-by: Amit Singh Tomar <amittomer25@gmail.com> --- Changes since v4: * Reordered it from 04/10 to 05/10. Changes since v3: * No change. Changes since v2: * this is no more don't merge and fixed the broken S700 boot by limiting pinctrl address range. * Modified the subject to reflect the changes. Changes since v1: * No change. Changes since RFC: * kept as do not merge. --- arch/arm64/boot/dts/actions/s700.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)