[v2,1/8] dt-bindings: pwm: samsung: Do not require interrupts on Exynos SoCs
diff mbox series

Message ID 20200702155149.12854-1-krzk@kernel.org
State Not Applicable
Headers show
Series
  • [v2,1/8] dt-bindings: pwm: samsung: Do not require interrupts on Exynos SoCs
Related show

Commit Message

Krzysztof Kozlowski July 2, 2020, 3:51 p.m. UTC
The bindings required interrupts for all SoCs but actually only the PWM
timer clocksource (for S3C/S5P SoCs) was using them.  This PWM timer
clocksource driver is not used on Exynos SoCs thus the interrupts can be
marked as optional.

Reported-by: Alim Akhtar <alim.akhtar@samsung.com>
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>

---

Changes since v1:
1. New patch
---
 .../devicetree/bindings/pwm/pwm-samsung.yaml  | 23 +++++++++++++++----
 1 file changed, 18 insertions(+), 5 deletions(-)

Comments

Uwe Kleine-König July 6, 2020, 9:41 a.m. UTC | #1
On Thu, Jul 02, 2020 at 05:51:42PM +0200, Krzysztof Kozlowski wrote:
> The bindings required interrupts for all SoCs but actually only the PWM
> timer clocksource (for S3C/S5P SoCs) was using them.  This PWM timer
> clocksource driver is not used on Exynos SoCs thus the interrupts can be
> marked as optional.
> 
> Reported-by: Alim Akhtar <alim.akhtar@samsung.com>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>

LGTM,

Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>

I'd expect it is ok to let this patch go in via whatever way the other
patches go. (But it's Thierry who has the authority here.)

Best regards
Uwe
Krzysztof Kozlowski July 7, 2020, 6:50 p.m. UTC | #2
On Mon, Jul 06, 2020 at 11:41:57AM +0200, Uwe Kleine-König wrote:
> On Thu, Jul 02, 2020 at 05:51:42PM +0200, Krzysztof Kozlowski wrote:
> > The bindings required interrupts for all SoCs but actually only the PWM
> > timer clocksource (for S3C/S5P SoCs) was using them.  This PWM timer
> > clocksource driver is not used on Exynos SoCs thus the interrupts can be
> > marked as optional.
> > 
> > Reported-by: Alim Akhtar <alim.akhtar@samsung.com>
> > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> 
> LGTM,
> 
> Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> 
> I'd expect it is ok to let this patch go in via whatever way the other
> patches go. (But it's Thierry who has the authority here.)

This patch is independent so it can go either through PWM tree or DT
bindings.  Usually the latter, so Rob was picking it up.

Thanks for ack.

Best regards,
Krzysztof
Rob Herring July 14, 2020, 2:46 a.m. UTC | #3
On Thu, 02 Jul 2020 17:51:42 +0200, Krzysztof Kozlowski wrote:
> The bindings required interrupts for all SoCs but actually only the PWM
> timer clocksource (for S3C/S5P SoCs) was using them.  This PWM timer
> clocksource driver is not used on Exynos SoCs thus the interrupts can be
> marked as optional.
> 
> Reported-by: Alim Akhtar <alim.akhtar@samsung.com>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> 
> ---
> 
> Changes since v1:
> 1. New patch
> ---
>  .../devicetree/bindings/pwm/pwm-samsung.yaml  | 23 +++++++++++++++----
>  1 file changed, 18 insertions(+), 5 deletions(-)
> 

Applied, thanks!

Patch
diff mbox series

diff --git a/Documentation/devicetree/bindings/pwm/pwm-samsung.yaml b/Documentation/devicetree/bindings/pwm/pwm-samsung.yaml
index fc799b0577d4..188679cb8b8c 100644
--- a/Documentation/devicetree/bindings/pwm/pwm-samsung.yaml
+++ b/Documentation/devicetree/bindings/pwm/pwm-samsung.yaml
@@ -18,9 +18,6 @@  description: |+
 
   Be aware that the clocksource driver supports only uniprocessor systems.
 
-allOf:
-  - $ref: pwm.yaml#
-
 properties:
   compatible:
     enum:
@@ -63,7 +60,8 @@  properties:
 
   interrupts:
     description:
-      One interrupt per timer, starting at timer 0.
+      One interrupt per timer, starting at timer 0. Necessary only for SoCs which
+      use PWM clocksource.
     minItems: 1
     maxItems: 5
 
@@ -88,12 +86,27 @@  required:
   - clocks
   - clock-names
   - compatible
-  - interrupts
   - "#pwm-cells"
   - reg
 
 additionalProperties: false
 
+allOf:
+  - $ref: pwm.yaml#
+
+  - if:
+      properties:
+        compatible:
+          contains:
+            enum:
+              - samsung,s3c2410-pwm
+              - samsung,s3c6400-pwm
+              - samsung,s5p6440-pwm
+              - samsung,s5pc100-pwm
+    then:
+      required:
+        - interrupts
+
 examples:
   - |
     pwm@7f006000 {