docs: block: update and fix tiny error for bfq
diff mbox series

Message ID 20200703061323.959519-1-yuyufen@huawei.com
State New
Headers show
Series
  • docs: block: update and fix tiny error for bfq
Related show

Commit Message

Yufen Yu July 3, 2020, 6:13 a.m. UTC
The max value of blkio.bfq.weight is 1000, rather than 10000.
And 'weights' have been remove from /sys/block/XXX/queue/iosched.

Signed-off-by: Yufen Yu <yuyufen@huawei.com>
---
 Documentation/block/bfq-iosched.rst | 9 +--------
 1 file changed, 1 insertion(+), 8 deletions(-)

Comments

Paolo Valente July 6, 2020, 7:17 a.m. UTC | #1
> Il giorno 3 lug 2020, alle ore 08:13, Yufen Yu <yuyufen@huawei.com> ha scritto:
> 
> The max value of blkio.bfq.weight is 1000, rather than 10000.
> And 'weights' have been remove from /sys/block/XXX/queue/iosched.
> 
Acked-by: Paolo Valente <paolo.valente@linaro.org>

Thanks!
Paolo

> Signed-off-by: Yufen Yu <yuyufen@huawei.com>
> ---
> Documentation/block/bfq-iosched.rst | 9 +--------
> 1 file changed, 1 insertion(+), 8 deletions(-)
> 
> diff --git a/Documentation/block/bfq-iosched.rst b/Documentation/block/bfq-iosched.rst
> index 0d237d402860..19d4d1570cee 100644
> --- a/Documentation/block/bfq-iosched.rst
> +++ b/Documentation/block/bfq-iosched.rst
> @@ -492,13 +492,6 @@ set max_budget to higher values than those to which BFQ would have set
> it with auto-tuning. An alternative way to achieve this goal is to
> just increase the value of timeout_sync, leaving max_budget equal to 0.
> 
> -weights
> --------
> -
> -Read-only parameter, used to show the weights of the currently active
> -BFQ queues.
> -
> -
> 4. Group scheduling with BFQ
> ============================
> 
> @@ -566,7 +559,7 @@ Parameters to set
> For each group, there is only the following parameter to set.
> 
> weight (namely blkio.bfq.weight or io.bfq-weight): the weight of the
> -group inside its parent. Available values: 1..10000 (default 100). The
> +group inside its parent. Available values: 1..1000 (default 100). The
> linear mapping between ioprio and weights, described at the beginning
> of the tunable section, is still valid, but all weights higher than
> IOPRIO_BE_NR*10 are mapped to ioprio 0.
> -- 
> 2.25.4
>
Jens Axboe July 6, 2020, 2:07 p.m. UTC | #2
On 7/3/20 12:13 AM, Yufen Yu wrote:
> The max value of blkio.bfq.weight is 1000, rather than 10000.
> And 'weights' have been remove from /sys/block/XXX/queue/iosched.

Applied, thanks.-- 
Jens Axboe
Jens Axboe July 6, 2020, 2:07 p.m. UTC | #3
On 7/3/20 12:13 AM, Yufen Yu wrote:
> The max value of blkio.bfq.weight is 1000, rather than 10000.
> And 'weights' have been remove from /sys/block/XXX/queue/iosched.

Applied, thanks.

Patch
diff mbox series

diff --git a/Documentation/block/bfq-iosched.rst b/Documentation/block/bfq-iosched.rst
index 0d237d402860..19d4d1570cee 100644
--- a/Documentation/block/bfq-iosched.rst
+++ b/Documentation/block/bfq-iosched.rst
@@ -492,13 +492,6 @@  set max_budget to higher values than those to which BFQ would have set
 it with auto-tuning. An alternative way to achieve this goal is to
 just increase the value of timeout_sync, leaving max_budget equal to 0.
 
-weights
--------
-
-Read-only parameter, used to show the weights of the currently active
-BFQ queues.
-
-
 4. Group scheduling with BFQ
 ============================
 
@@ -566,7 +559,7 @@  Parameters to set
 For each group, there is only the following parameter to set.
 
 weight (namely blkio.bfq.weight or io.bfq-weight): the weight of the
-group inside its parent. Available values: 1..10000 (default 100). The
+group inside its parent. Available values: 1..1000 (default 100). The
 linear mapping between ioprio and weights, described at the beginning
 of the tunable section, is still valid, but all weights higher than
 IOPRIO_BE_NR*10 are mapped to ioprio 0.