[RFC] MAINTAINERS: Cover the firmware JSON schema

Commit Message

Philippe Mathieu-Daudé July 3, 2020, 4:14 p.m. UTC

Add an entry to cover firmware.json (see commit 3a0adfc9bf:
schema that describes the different uses and properties of
virtual machine firmware).
Cc the libvirt maintainers if it ever changes.

Cc: Laszlo Ersek <[e-mail]>
Cc: Daniel P. Berrange <[e-mail]>
Cc: Gerd Hoffmann <[e-mail]>
Cc: Kashyap Chamarthy <[e-mail]>
Cc: Michael S. Tsirkin <[e-mail]>
Suggested-by: Laszlo Ersek <[e-mail]>
Signed-off-by: Philippe Mathieu-Daudé <[e-mail]>
---
Based on a comment from Laszlo:
https://www.mail-archive.com/[e-mail]/msg604925.html

I don't think Laszlo should be the sole maintainer, not sure
who else should be listed. Gerd and Kashyap? :)
Can we add it 'maintained' without specific maintainer?
---
 MAINTAINERS | 6 ++++++
 1 file changed, 6 insertions(+)

Comments

Daniel P. Berrangé July 3, 2020, 4:18 p.m. UTC | #1

On Fri, Jul 03, 2020 at 06:14:53PM +0200, Philippe Mathieu-Daudé wrote:
> Add an entry to cover firmware.json (see commit 3a0adfc9bf:
> schema that describes the different uses and properties of
> virtual machine firmware).
> Cc the libvirt maintainers if it ever changes.
> 
> Cc: Laszlo Ersek <[e-mail]>
> Cc: Daniel P. Berrange <[e-mail]>
> Cc: Gerd Hoffmann <[e-mail]>
> Cc: Kashyap Chamarthy <[e-mail]>
> Cc: Michael S. Tsirkin <[e-mail]>
> Suggested-by: Laszlo Ersek <[e-mail]>
> Signed-off-by: Philippe Mathieu-Daudé <[e-mail]>
> ---
> Based on a comment from Laszlo:
> https://www.mail-archive.com/[e-mail]/msg604925.html
> 
> I don't think Laszlo should be the sole maintainer, not sure
> who else should be listed. Gerd and Kashyap? :)
> Can we add it 'maintained' without specific maintainer?
> ---
>  MAINTAINERS | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index dec252f38b..57c90201df 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -2601,6 +2601,12 @@ F: include/hw/i2c/smbus_master.h
>  F: include/hw/i2c/smbus_slave.h
>  F: include/hw/i2c/smbus_eeprom.h
>  
> +Firmware schema specifications
> +M: Laszlo Ersek <[e-mail]>
> +R: [e-mail]

FWIW, I don't think libvirt needs to review this. Our firmware handling
code doesn't really care what specific files exist - it just follows the
declared logic to pick amongst whatever exists.


Regards,
Daniel

Kashyap Chamarthy July 3, 2020, 4:29 p.m. UTC | #2

On Fri, Jul 03, 2020 at 06:14:53PM +0200, Philippe Mathieu-Daudé wrote:
> Add an entry to cover firmware.json (see commit 3a0adfc9bf:
> schema that describes the different uses and properties of
> virtual machine firmware).
> Cc the libvirt maintainers if it ever changes.
> 
> Cc: Laszlo Ersek <[e-mail]>
> Cc: Daniel P. Berrange <[e-mail]>
> Cc: Gerd Hoffmann <[e-mail]>
> Cc: Kashyap Chamarthy <[e-mail]>
> Cc: Michael S. Tsirkin <[e-mail]>
> Suggested-by: Laszlo Ersek <[e-mail]>
> Signed-off-by: Philippe Mathieu-Daudé <[e-mail]>
> ---
> Based on a comment from Laszlo:
> https://www.mail-archive.com/[e-mail]/msg604925.html
> 
> I don't think Laszlo should be the sole maintainer, not sure
> who else should be listed. Gerd and Kashyap? :)

Hiya,

I'm a mere enthusiastic user of firmware.json. :-) The original design
heavy-lifting[*] was done by Dan, Gerd, and Laszlo.  That said, I'm
happy to be Cced on patches to it, and review changes to the extent I
can.

[*] https://lists.nongnu.org/archive/html/qemu-devel/2018-03/msg01978.html
    — [RFC] Defining firmware (OVMF, et al) metadata format & file

> Can we add it 'maintained' without specific maintainer?
> ---
>  MAINTAINERS | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index dec252f38b..57c90201df 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -2601,6 +2601,12 @@ F: include/hw/i2c/smbus_master.h
>  F: include/hw/i2c/smbus_slave.h
>  F: include/hw/i2c/smbus_eeprom.h
>  
> +Firmware schema specifications
> +M: Laszlo Ersek <[e-mail]>
> +R: [e-mail]
> +S: Maintained
> +F: docs/interop/firmware.json
> +
>  EDK2 Firmware
>  M: Laszlo Ersek <[e-mail]>
>  M: Philippe Mathieu-Daudé <[e-mail]>
> -- 
> 2.21.3
>

Laszlo Ersek July 3, 2020, 4:58 p.m. UTC | #3

On 07/03/20 18:18, Daniel P. Berrangé wrote:
> On Fri, Jul 03, 2020 at 06:14:53PM +0200, Philippe Mathieu-Daudé wrote:
>> Add an entry to cover firmware.json (see commit 3a0adfc9bf:
>> schema that describes the different uses and properties of
>> virtual machine firmware).
>> Cc the libvirt maintainers if it ever changes.
>>
>> Cc: Laszlo Ersek <[e-mail]>
>> Cc: Daniel P. Berrange <[e-mail]>
>> Cc: Gerd Hoffmann <[e-mail]>
>> Cc: Kashyap Chamarthy <[e-mail]>
>> Cc: Michael S. Tsirkin <[e-mail]>
>> Suggested-by: Laszlo Ersek <[e-mail]>
>> Signed-off-by: Philippe Mathieu-Daudé <[e-mail]>
>> ---
>> Based on a comment from Laszlo:
>> https://www.mail-archive.com/[e-mail]/msg604925.html
>>
>> I don't think Laszlo should be the sole maintainer, not sure
>> who else should be listed. Gerd and Kashyap? :)
>> Can we add it 'maintained' without specific maintainer?
>> ---
>>  MAINTAINERS | 6 ++++++
>>  1 file changed, 6 insertions(+)
>>
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index dec252f38b..57c90201df 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -2601,6 +2601,12 @@ F: include/hw/i2c/smbus_master.h
>>  F: include/hw/i2c/smbus_slave.h
>>  F: include/hw/i2c/smbus_eeprom.h
>>  
>> +Firmware schema specifications
>> +M: Laszlo Ersek <[e-mail]>
>> +R: [e-mail]
> 
> FWIW, I don't think libvirt needs to review this. Our firmware handling
> code doesn't really care what specific files exist - it just follows the
> declared logic to pick amongst whatever exists.

I request that

- Phil be listed please as another maintainer (so there are two people
that can send pull requests, if a 3rd person needs to patch this file
for whatever reason),

- Dan be listed please *at least* as an "R" person; the business logic
written up under the @Firmware element, and lots of the initial review
comments (in particular the suggestion to mention specific QEMU command
line switches in the schema), had come from him.

If Dan is willing to be an "M", then we can collapse both of my above
requests into one, and Phil wouldn't have to be listed (Dan could both
review suggested changes and submit pull requests). However, I'm raising
this only as a technical possibility; what really matters to me is that
Dan be CC'd on suggested changes, and that someone other than me can
submit PRs if necessary.

Thanks!
Laszlo

Daniel P. Berrangé July 3, 2020, 5:06 p.m. UTC | #4

On Fri, Jul 03, 2020 at 06:58:45PM +0200, Laszlo Ersek wrote:
> On 07/03/20 18:18, Daniel P. Berrangé wrote:
> > On Fri, Jul 03, 2020 at 06:14:53PM +0200, Philippe Mathieu-Daudé wrote:
> >> Add an entry to cover firmware.json (see commit 3a0adfc9bf:
> >> schema that describes the different uses and properties of
> >> virtual machine firmware).
> >> Cc the libvirt maintainers if it ever changes.
> >>
> >> Cc: Laszlo Ersek <[e-mail]>
> >> Cc: Daniel P. Berrange <[e-mail]>
> >> Cc: Gerd Hoffmann <[e-mail]>
> >> Cc: Kashyap Chamarthy <[e-mail]>
> >> Cc: Michael S. Tsirkin <[e-mail]>
> >> Suggested-by: Laszlo Ersek <[e-mail]>
> >> Signed-off-by: Philippe Mathieu-Daudé <[e-mail]>
> >> ---
> >> Based on a comment from Laszlo:
> >> https://www.mail-archive.com/[e-mail]/msg604925.html
> >>
> >> I don't think Laszlo should be the sole maintainer, not sure
> >> who else should be listed. Gerd and Kashyap? :)
> >> Can we add it 'maintained' without specific maintainer?
> >> ---
> >>  MAINTAINERS | 6 ++++++
> >>  1 file changed, 6 insertions(+)
> >>
> >> diff --git a/MAINTAINERS b/MAINTAINERS
> >> index dec252f38b..57c90201df 100644
> >> --- a/MAINTAINERS
> >> +++ b/MAINTAINERS
> >> @@ -2601,6 +2601,12 @@ F: include/hw/i2c/smbus_master.h
> >>  F: include/hw/i2c/smbus_slave.h
> >>  F: include/hw/i2c/smbus_eeprom.h
> >>  
> >> +Firmware schema specifications
> >> +M: Laszlo Ersek <[e-mail]>
> >> +R: [e-mail]
> > 
> > FWIW, I don't think libvirt needs to review this. Our firmware handling
> > code doesn't really care what specific files exist - it just follows the
> > declared logic to pick amongst whatever exists.
> 
> I request that
> 
> - Phil be listed please as another maintainer (so there are two people
> that can send pull requests, if a 3rd person needs to patch this file
> for whatever reason),
> 
> - Dan be listed please *at least* as an "R" person; the business logic
> written up under the @Firmware element, and lots of the initial review
> comments (in particular the suggestion to mention specific QEMU command
> line switches in the schema), had come from him.
> 
> If Dan is willing to be an "M", then we can collapse both of my above
> requests into one, and Phil wouldn't have to be listed (Dan could both
> review suggested changes and submit pull requests). However, I'm raising
> this only as a technical possibility; what really matters to me is that
> Dan be CC'd on suggested changes, and that someone other than me can
> submit PRs if necessary.

I'm fine with "R", but don't want to be "M" as I don't want to be
responsible for queueing patches, etc on more parts of QEMU.

Regards,
Daniel

Philippe Mathieu-Daudé July 3, 2020, 6:30 p.m. UTC | #5

On 7/3/20 7:06 PM, Daniel P. Berrangé wrote:
> On Fri, Jul 03, 2020 at 06:58:45PM +0200, Laszlo Ersek wrote:
>> On 07/03/20 18:18, Daniel P. Berrangé wrote:
>>> On Fri, Jul 03, 2020 at 06:14:53PM +0200, Philippe Mathieu-Daudé wrote:
>>>> Add an entry to cover firmware.json (see commit 3a0adfc9bf:
>>>> schema that describes the different uses and properties of
>>>> virtual machine firmware).
>>>> Cc the libvirt maintainers if it ever changes.
>>>>
>>>> Cc: Laszlo Ersek <[e-mail]>
>>>> Cc: Daniel P. Berrange <[e-mail]>
>>>> Cc: Gerd Hoffmann <[e-mail]>
>>>> Cc: Kashyap Chamarthy <[e-mail]>
>>>> Cc: Michael S. Tsirkin <[e-mail]>
>>>> Suggested-by: Laszlo Ersek <[e-mail]>
>>>> Signed-off-by: Philippe Mathieu-Daudé <[e-mail]>
>>>> ---
>>>> Based on a comment from Laszlo:
>>>> https://www.mail-archive.com/[e-mail]/msg604925.html
>>>>
>>>> I don't think Laszlo should be the sole maintainer, not sure
>>>> who else should be listed. Gerd and Kashyap? :)
>>>> Can we add it 'maintained' without specific maintainer?
>>>> ---
>>>>  MAINTAINERS | 6 ++++++
>>>>  1 file changed, 6 insertions(+)
>>>>
>>>> diff --git a/MAINTAINERS b/MAINTAINERS
>>>> index dec252f38b..57c90201df 100644
>>>> --- a/MAINTAINERS
>>>> +++ b/MAINTAINERS
>>>> @@ -2601,6 +2601,12 @@ F: include/hw/i2c/smbus_master.h
>>>>  F: include/hw/i2c/smbus_slave.h
>>>>  F: include/hw/i2c/smbus_eeprom.h
>>>>  
>>>> +Firmware schema specifications
>>>> +M: Laszlo Ersek <[e-mail]>
>>>> +R: [e-mail]
>>>
>>> FWIW, I don't think libvirt needs to review this. Our firmware handling
>>> code doesn't really care what specific files exist - it just follows the
>>> declared logic to pick amongst whatever exists.
>>
>> I request that
>>
>> - Phil be listed please as another maintainer (so there are two people
>> that can send pull requests, if a 3rd person needs to patch this file
>> for whatever reason),
>>
>> - Dan be listed please *at least* as an "R" person; the business logic
>> written up under the @Firmware element, and lots of the initial review
>> comments (in particular the suggestion to mention specific QEMU command
>> line switches in the schema), had come from him.
>>
>> If Dan is willing to be an "M", then we can collapse both of my above
>> requests into one, and Phil wouldn't have to be listed (Dan could both
>> review suggested changes and submit pull requests). However, I'm raising
>> this only as a technical possibility; what really matters to me is that
>> Dan be CC'd on suggested changes, and that someone other than me can
>> submit PRs if necessary.
> 
> I'm fine with "R", but don't want to be "M" as I don't want to be
> responsible for queueing patches, etc on more parts of QEMU.

Thanks all! I'm queuing this patch as:

Firmware schema specifications
M: Laszlo Ersek <[e-mail]>
M: Philippe Mathieu-Daudé <[e-mail]>
R: Daniel P. Berrange <[e-mail]>
R: Kashyap Chamarthy <[e-mail]>
S: Maintained
F: docs/interop/firmware.json

Regards,

Phil.

Patch

diff --git a/MAINTAINERS b/MAINTAINERS
index dec252f38b..57c90201df 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -2601,6 +2601,12 @@  F: include/hw/i2c/smbus_master.h
 F: include/hw/i2c/smbus_slave.h
 F: include/hw/i2c/smbus_eeprom.h
 
+Firmware schema specifications
+M: Laszlo Ersek <[e-mail]>
+R: [e-mail]
+S: Maintained
+F: docs/interop/firmware.json
+
 EDK2 Firmware
 M: Laszlo Ersek <[e-mail]>
 M: Philippe Mathieu-Daudé <[e-mail]>