[for-4.14] kdd: fix build again
diff mbox series

Message ID 20200703201001.56606-1-wl@xen.org
State New
Headers show
Series
  • [for-4.14] kdd: fix build again
Related show

Commit Message

Wei Liu July 3, 2020, 8:10 p.m. UTC
Restore Tim's patch. The one that was committed was recreated by me
because git didn't accept my saved copy. I made some mistakes while
recreating that patch and here we are.

Fixes: 3471cafbdda3 ("kdd: stop using [0] arrays to access packet contents")
Reported-by: Michael Young <m.a.young@durham.ac.uk>
Signed-off-by: Wei Liu <wl@xen.org>
---
Cc: Tim Deegan <tim@xen.org>
Cc: Paul Durrant <paul@xen.org>
Cc: Michael Young <m.a.young@durham.ac.uk>
---
 tools/debugger/kdd/kdd.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Tim Deegan July 3, 2020, 8:27 p.m. UTC | #1
At 20:10 +0000 on 03 Jul (1593807001), Wei Liu wrote:
> Restore Tim's patch. The one that was committed was recreated by me
> because git didn't accept my saved copy. I made some mistakes while
> recreating that patch and here we are.
> 
> Fixes: 3471cafbdda3 ("kdd: stop using [0] arrays to access packet contents")
> Reported-by: Michael Young <m.a.young@durham.ac.uk>
> Signed-off-by: Wei Liu <wl@xen.org>

Reviewed-by: Tim Deegan <tim@xen.org>

Thanks!

Tim.
Paul Durrant July 6, 2020, 6:58 a.m. UTC | #2
> -----Original Message-----
> From: Tim Deegan <tim@xen.org>
> Sent: 03 July 2020 21:27
> To: Wei Liu <wl@xen.org>
> Cc: Xen Development List <xen-devel@lists.xenproject.org>; Michael Young <m.a.young@durham.ac.uk>;
> Paul Durrant <paul@xen.org>; Ian Jackson <ian.jackson@eu.citrix.com>
> Subject: Re: [PATCH for-4.14] kdd: fix build again
> 
> At 20:10 +0000 on 03 Jul (1593807001), Wei Liu wrote:
> > Restore Tim's patch. The one that was committed was recreated by me
> > because git didn't accept my saved copy. I made some mistakes while
> > recreating that patch and here we are.
> >
> > Fixes: 3471cafbdda3 ("kdd: stop using [0] arrays to access packet contents")
> > Reported-by: Michael Young <m.a.young@durham.ac.uk>
> > Signed-off-by: Wei Liu <wl@xen.org>
> 
> Reviewed-by: Tim Deegan <tim@xen.org>
> 
> Thanks!
> 
> Tim.

Release-acked-by: Paul Durrant <paul@xen.org>

Patch
diff mbox series

diff --git a/tools/debugger/kdd/kdd.c b/tools/debugger/kdd/kdd.c
index 866532f0c770..a7d0976ea4a8 100644
--- a/tools/debugger/kdd/kdd.c
+++ b/tools/debugger/kdd/kdd.c
@@ -79,11 +79,11 @@  typedef struct {
 /* State of the debugger stub */
 typedef struct {
     union {
-        uint8_t txb[sizeof (kdd_hdr)];           /* Marshalling area for tx */
+        uint8_t txb[sizeof (kdd_pkt)];           /* Marshalling area for tx */
         kdd_pkt txp;                 /* Also readable as a packet structure */
     };
     union {
-        uint8_t rxb[sizeof (kdd_hdr)];           /* Marshalling area for rx */
+        uint8_t rxb[sizeof (kdd_pkt)];           /* Marshalling area for rx */
         kdd_pkt rxp;                 /* Also readable as a packet structure */
     };
     unsigned int cur;       /* Offset into rx where we'll put the next byte */