| Message ID | 20200704144943.18292-5-f4bug@amsat.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | hw/usb: Give it love, reduce 'hw/usb.h' inclusion out of hw/usb/ | expand |
On Sat, Jul 4, 2020 at 7:52 AM Philippe Mathieu-Daudé <f4bug@amsat.org> wrote: > > "exec/memory.h" is only required by "hw/usb/hcd-musb.h". > Include it there directly. > > Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> Reviewed-by: Alistair Francis <alistair.francis@wdc.com> Alistair > --- > include/hw/usb.h | 1 - > include/hw/usb/hcd-musb.h | 2 ++ > 2 files changed, 2 insertions(+), 1 deletion(-) > > diff --git a/include/hw/usb.h b/include/hw/usb.h > index 4f04a1a879..15b2ef300a 100644 > --- a/include/hw/usb.h > +++ b/include/hw/usb.h > @@ -25,7 +25,6 @@ > * THE SOFTWARE. > */ > > -#include "exec/memory.h" > #include "hw/qdev-core.h" > #include "qemu/iov.h" > #include "qemu/queue.h" > diff --git a/include/hw/usb/hcd-musb.h b/include/hw/usb/hcd-musb.h > index c874b9f292..ec3ee5c4b0 100644 > --- a/include/hw/usb/hcd-musb.h > +++ b/include/hw/usb/hcd-musb.h > @@ -13,6 +13,8 @@ > #ifndef HW_USB_MUSB_H > #define HW_USB_MUSB_H > > +#include "exec/memory.h" > + > enum musb_irq_source_e { > musb_irq_suspend = 0, > musb_irq_resume, > -- > 2.21.3 > >
diff --git a/include/hw/usb.h b/include/hw/usb.h index 4f04a1a879..15b2ef300a 100644 --- a/include/hw/usb.h +++ b/include/hw/usb.h @@ -25,7 +25,6 @@ * THE SOFTWARE. */ -#include "exec/memory.h" #include "hw/qdev-core.h" #include "qemu/iov.h" #include "qemu/queue.h" diff --git a/include/hw/usb/hcd-musb.h b/include/hw/usb/hcd-musb.h index c874b9f292..ec3ee5c4b0 100644 --- a/include/hw/usb/hcd-musb.h +++ b/include/hw/usb/hcd-musb.h @@ -13,6 +13,8 @@ #ifndef HW_USB_MUSB_H #define HW_USB_MUSB_H +#include "exec/memory.h" + enum musb_irq_source_e { musb_irq_suspend = 0, musb_irq_resume,
"exec/memory.h" is only required by "hw/usb/hcd-musb.h". Include it there directly. Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> --- include/hw/usb.h | 1 - include/hw/usb/hcd-musb.h | 2 ++ 2 files changed, 2 insertions(+), 1 deletion(-)