HID: lenovo: Fix spurious F23 key press report during resume from suspend
diff mbox series

Message ID 20200704201059.126823-2-hdegoede@redhat.com
State New
Delegated to: Jiri Kosina
Headers show
Series
  • HID: lenovo: Fix spurious F23 key press report during resume from suspend
Related show

Commit Message

Hans de Goede July 4, 2020, 8:10 p.m. UTC
The Ultrabook Keyboard sends a spurious F23 key-press when resuming
from suspend. GNOME uses F23 to toggle the touchpad on/off so this causes
the OSD graphics for the touchpad toggle to show on resume.

The keyboard does not actually have a F23 key, se we can simple fix it
by marking the 0x00070072 HID usage, which normally is F23, to be ignored.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
 drivers/hid/hid-lenovo.c | 7 +++++++
 1 file changed, 7 insertions(+)

Patch
diff mbox series

diff --git a/drivers/hid/hid-lenovo.c b/drivers/hid/hid-lenovo.c
index b5122ee46801..c6c8e20f3e8d 100644
--- a/drivers/hid/hid-lenovo.c
+++ b/drivers/hid/hid-lenovo.c
@@ -245,6 +245,13 @@  static int lenovo_input_mapping_tp10_ultrabook_kbd(struct hid_device *hdev,
 		}
 	}
 
+	/*
+	 * The Ultrabook Keyboard sends a spurious F23 key-press when resuming
+	 * from suspend and it does not actually have a F23 key, ignore it.
+	 */
+	if (usage->hid == 0x00070072)
+		return -1;
+
 	return 0;
 }