ARM: dts: vf610-zii-ssmb-dtu: Pass "no-sdio"/"no-sd" properties
diff mbox series

Message ID CAFXsbZoovWBavRFaEWEFcSkVjNx26BkKOkhcutNfzL8MrHwMTw@mail.gmail.com
State New
Headers show
Series
  • ARM: dts: vf610-zii-ssmb-dtu: Pass "no-sdio"/"no-sd" properties
Related show

Commit Message

Chris Healy July 5, 2020, 3:16 a.m. UTC
esdhc0 is connected to an eMMC, so it is safe to pass the "no-sdio"/"no-sd"
properties.

esdhc1 is wired to a standard SD socket, so pass the "no-sdio" property.

Signed-off-by: Chris Healy <cphealy@gmail.com>
---
 arch/arm/boot/dts/vf610-zii-ssmb-dtu.dts | 3 +++
 1 file changed, 3 insertions(+)

Comments

Fabio Estevam July 6, 2020, 11:15 p.m. UTC | #1
On Sun, Jul 5, 2020 at 12:16 AM Chris Healy <cphealy@gmail.com> wrote:
>
> esdhc0 is connected to an eMMC, so it is safe to pass the "no-sdio"/"no-sd"
> properties.
>
> esdhc1 is wired to a standard SD socket, so pass the "no-sdio" property.
>
> Signed-off-by: Chris Healy <cphealy@gmail.com>

Reviewed-by: Fabio Estevam <festevam@gmail.com>
Shawn Guo July 13, 2020, 6:36 a.m. UTC | #2
On Sat, Jul 04, 2020 at 08:16:10PM -0700, Chris Healy wrote:
> esdhc0 is connected to an eMMC, so it is safe to pass the "no-sdio"/"no-sd"
> properties.
> 
> esdhc1 is wired to a standard SD socket, so pass the "no-sdio" property.
> 
> Signed-off-by: Chris Healy <cphealy@gmail.com>

I would suggest something like below for patch subject.

  ARM: dts: vf610-zii-ssmb-dtu: Add no-sdio/no-sd properties

Also the patch doesn't apply to my branch.

Shawn

> ---
>  arch/arm/boot/dts/vf610-zii-ssmb-dtu.dts | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/vf610-zii-ssmb-dtu.dts
> b/arch/arm/boot/dts/vf610-zii-ssmb-dtu.dts
> index 0bb3dcff0b79..7d4ddfb6b5b5 100644
> --- a/arch/arm/boot/dts/vf610-zii-ssmb-dtu.dts
> +++ b/arch/arm/boot/dts/vf610-zii-ssmb-dtu.dts
> @@ -81,6 +81,8 @@
>      non-removable;
>      no-1-8-v;
>      keep-power-in-suspend;
> +    no-sdio;
> +    no-sd;
>      status = "okay";
>  };
> 
> @@ -88,6 +90,7 @@
>      pinctrl-names = "default";
>      pinctrl-0 = <&pinctrl_esdhc1>;
>      bus-width = <4>;
> +    no-sdio;
>      status = "okay";
>  };
> 
> -- 
> 2.21.3

Patch
diff mbox series

diff --git a/arch/arm/boot/dts/vf610-zii-ssmb-dtu.dts
b/arch/arm/boot/dts/vf610-zii-ssmb-dtu.dts
index 0bb3dcff0b79..7d4ddfb6b5b5 100644
--- a/arch/arm/boot/dts/vf610-zii-ssmb-dtu.dts
+++ b/arch/arm/boot/dts/vf610-zii-ssmb-dtu.dts
@@ -81,6 +81,8 @@ 
     non-removable;
     no-1-8-v;
     keep-power-in-suspend;
+    no-sdio;
+    no-sd;
     status = "okay";
 };

@@ -88,6 +90,7 @@ 
     pinctrl-names = "default";
     pinctrl-0 = <&pinctrl_esdhc1>;
     bus-width = <4>;
+    no-sdio;
     status = "okay";
 };