ARM: dts: vf610-zii-dev-rev-c.dts: Configure fibre port to 1000BaseX
diff mbox series

Message ID CAFXsbZrFRH2=+OgBARRkku2O0Okv=jg-uZaN+1Cv1tEwq-8k5Q@mail.gmail.com
State New
Headers show
Series
  • ARM: dts: vf610-zii-dev-rev-c.dts: Configure fibre port to 1000BaseX
Related show

Commit Message

Chris Healy July 6, 2020, 12:51 a.m. UTC
The SFF soldered onto the board expects the port to use 1000BaseX.  It
makes no sense to have the port set to SGMII, since it doesn't even
support that mode.

Signed-off-by: Chris Healy <cphealy@gmail.com>
---
 arch/arm/boot/dts/vf610-zii-dev-rev-c.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--
2.21.3

Comments

Fabio Estevam July 8, 2020, 6:40 p.m. UTC | #1
Hi Chris,

In the Subject you could remove the .dts from the dts name:

ARM: dts: vf610-zii-dev-rev-c: Configure fibre port to 1000BaseX

On Sun, Jul 5, 2020 at 9:51 PM Chris Healy <cphealy@gmail.com> wrote:
>
> The SFF soldered onto the board expects the port to use 1000BaseX.  It
> makes no sense to have the port set to SGMII, since it doesn't even
> support that mode.
>
> Signed-off-by: Chris Healy <cphealy@gmail.com>
> ---
>  arch/arm/boot/dts/vf610-zii-dev-rev-c.dts | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/vf610-zii-dev-rev-c.dts
> b/arch/arm/boot/dts/vf610-zii-dev-rev-c.dts
> index 778e02c000d1..de79dcfd32e6 100644
> --- a/arch/arm/boot/dts/vf610-zii-dev-rev-c.dts
> +++ b/arch/arm/boot/dts/vf610-zii-dev-rev-c.dts
> @@ -164,7 +164,7 @@
>                      port@9 {
>                          reg = <9>;
>                          label = "sff2";
> -                        phy-mode = "sgmii";
> +                        phy-mode = "1000base-x";

Looks like tabs were converted to spaces.
Chris Healy July 8, 2020, 6:52 p.m. UTC | #2
On Wed, Jul 8, 2020 at 11:41 AM Fabio Estevam <festevam@gmail.com> wrote:
>
> Hi Chris,
>
> In the Subject you could remove the .dts from the dts name:
>
> ARM: dts: vf610-zii-dev-rev-c: Configure fibre port to 1000BaseX
>
> On Sun, Jul 5, 2020 at 9:51 PM Chris Healy <cphealy@gmail.com> wrote:
> >
> > The SFF soldered onto the board expects the port to use 1000BaseX.  It
> > makes no sense to have the port set to SGMII, since it doesn't even
> > support that mode.
> >
> > Signed-off-by: Chris Healy <cphealy@gmail.com>
> > ---
> >  arch/arm/boot/dts/vf610-zii-dev-rev-c.dts | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/arm/boot/dts/vf610-zii-dev-rev-c.dts
> > b/arch/arm/boot/dts/vf610-zii-dev-rev-c.dts
> > index 778e02c000d1..de79dcfd32e6 100644
> > --- a/arch/arm/boot/dts/vf610-zii-dev-rev-c.dts
> > +++ b/arch/arm/boot/dts/vf610-zii-dev-rev-c.dts
> > @@ -164,7 +164,7 @@
> >                      port@9 {
> >                          reg = <9>;
> >                          label = "sff2";
> > -                        phy-mode = "sgmii";
> > +                        phy-mode = "1000base-x";
>
> Looks like tabs were converted to spaces.

I'll make both changes and submit a v2, thanks.

Patch
diff mbox series

diff --git a/arch/arm/boot/dts/vf610-zii-dev-rev-c.dts
b/arch/arm/boot/dts/vf610-zii-dev-rev-c.dts
index 778e02c000d1..de79dcfd32e6 100644
--- a/arch/arm/boot/dts/vf610-zii-dev-rev-c.dts
+++ b/arch/arm/boot/dts/vf610-zii-dev-rev-c.dts
@@ -164,7 +164,7 @@ 
                     port@9 {
                         reg = <9>;
                         label = "sff2";
-                        phy-mode = "sgmii";
+                        phy-mode = "1000base-x";
                         managed = "in-band-status";
                         sfp = <&sff2>;
                     };