Message ID | 20200706125054.2619012-1-berrange@redhat.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
Series | scripts: improve message when TAP based tests fail | expand |
On 06/07/20 14:50, Daniel P. Berrangé wrote: > If one of the qtests fails, the TAP driver prints out a message like: > > ERROR - too few tests run (expected 3, got 1) > > which fails to tell you which test program failed. This is a critical > ommission when many tests are running in parallel as their output is > interleaved. The improved message is: > > ERROR endianness-test - too few tests run (expected 3, got 1) > > Signed-off-by: Daniel P. Berrangé <berrange@redhat.com> > --- > scripts/tap-driver.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/scripts/tap-driver.pl b/scripts/tap-driver.pl > index 6621a5cd67..b1d3880c50 100755 > --- a/scripts/tap-driver.pl > +++ b/scripts/tap-driver.pl > @@ -217,7 +217,7 @@ sub report ($;$) > > sub testsuite_error ($) > { > - report "ERROR", "- $_[0]"; > + report "ERROR", "$test_name - $_[0]"; > } > > sub handle_tap_result ($) > Queued, thanks. Paolo
diff --git a/scripts/tap-driver.pl b/scripts/tap-driver.pl index 6621a5cd67..b1d3880c50 100755 --- a/scripts/tap-driver.pl +++ b/scripts/tap-driver.pl @@ -217,7 +217,7 @@ sub report ($;$) sub testsuite_error ($) { - report "ERROR", "- $_[0]"; + report "ERROR", "$test_name - $_[0]"; } sub handle_tap_result ($)
If one of the qtests fails, the TAP driver prints out a message like: ERROR - too few tests run (expected 3, got 1) which fails to tell you which test program failed. This is a critical ommission when many tests are running in parallel as their output is interleaved. The improved message is: ERROR endianness-test - too few tests run (expected 3, got 1) Signed-off-by: Daniel P. Berrangé <berrange@redhat.com> --- scripts/tap-driver.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)