From patchwork Tue Jul 7 19:23:10 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Pierre-Louis Bossart X-Patchwork-Id: 11649905 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 5E8A613B4 for ; Tue, 7 Jul 2020 19:25:23 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E975020720 for ; Tue, 7 Jul 2020 19:25:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="pgTl9btG" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E975020720 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 7D8E116C9; Tue, 7 Jul 2020 21:24:34 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 7D8E116C9 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1594149921; bh=ftiznkGhVf0jDKPK0eeSfPVmWxF7EPcySZcMur+bFTs=; h=From:To:Subject:Date:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=pgTl9btG6tqL4ecybVLtsbDB6vaLa/2oWjXo3hfuXGaacA3onvGYZT/pR98eSfNVU Zfw11n+4pA1/sRX76U2o0PGOEgTLAVeWz2AYu5VVg7NICPKAMWkeSWv9FkQz2tuW15 bt1wi/1z8naXqGlsvCev/a0jrEHQJMT9JtrAj2yI= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 3A8A5F800DF; Tue, 7 Jul 2020 21:23:41 +0200 (CEST) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa1.perex.cz (Postfix, from userid 50401) id 08F88F80264; Tue, 7 Jul 2020 21:23:39 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on alsa1.perex.cz X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=SPF_HELO_NONE,SPF_NONE, URIBL_BLOCKED autolearn=disabled version=3.4.0 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 951E1F801F9 for ; Tue, 7 Jul 2020 21:23:32 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 951E1F801F9 IronPort-SDR: MtCZoju1H1yxTH1EtxmM/UcpQkq6Z54JNltjFMPsVOIiEUChTytoQMblH15UasqRfAseAY4SoJ scU6XT3Nd08Q== X-IronPort-AV: E=McAfee;i="6000,8403,9675"; a="145187062" X-IronPort-AV: E=Sophos;i="5.75,324,1589266800"; d="scan'208";a="145187062" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Jul 2020 12:23:29 -0700 IronPort-SDR: K33tZHbvjJJz+antiIUzSPM8PCsbQXC/0det2ssOH3Ql+QVJxbrxSEX7yRQ07VjmGga7TrT+CC VjVS0Z0i/9qg== X-IronPort-AV: E=Sophos;i="5.75,324,1589266800"; d="scan'208";a="266915978" Received: from mrtorger-mobl1.amr.corp.intel.com (HELO pbossart-mobl3.amr.corp.intel.com) ([10.254.77.62]) by fmsmga007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Jul 2020 12:23:28 -0700 From: Pierre-Louis Bossart To: alsa-devel@alsa-project.org Subject: [PATCH 3/3] ASoC: meson: axg-spdifin: remove comparison always false warning Date: Tue, 7 Jul 2020 14:23:10 -0500 Message-Id: <20200707192310.98663-4-pierre-louis.bossart@linux.intel.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200707192310.98663-1-pierre-louis.bossart@linux.intel.com> References: <20200707192310.98663-1-pierre-louis.bossart@linux.intel.com> MIME-Version: 1.0 Cc: open list , tiwai@suse.de, Kevin Hilman , Takashi Iwai , Liam Girdwood , Pierre-Louis Bossart , broonie@kernel.org, "open list:ARM/Amlogic Meson SoC support" , Lee Jones , "moderated list:ARM/Amlogic Meson SoC support" , Jerome Brunet X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" Fix W=1 warning: sound/soc/meson/axg-spdifin.c: In function ‘axg_spdifin_write_mode_param’: include/linux/bits.h:26:28: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits] Cast width to an int to avoid checking if an unsigned value is lower than zero. Signed-off-by: Pierre-Louis Bossart --- sound/soc/meson/axg-spdifin.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/meson/axg-spdifin.c b/sound/soc/meson/axg-spdifin.c index d0d09f945b48..5fa411d4e985 100644 --- a/sound/soc/meson/axg-spdifin.c +++ b/sound/soc/meson/axg-spdifin.c @@ -154,7 +154,7 @@ static void axg_spdifin_write_mode_param(struct regmap *map, int mode, reg = offset * regmap_get_reg_stride(map) + base_reg; shift = width * (num_per_reg - 1 - rem); - regmap_update_bits(map, reg, GENMASK(width - 1, 0) << shift, + regmap_update_bits(map, reg, GENMASK((int)width - 1, 0) << shift, val << shift); }