| Message ID | 20200707202628.113142-1-pierre-louis.bossart@linux.intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | regmap: add missing dependency on SoundWire | expand |
On Tue, Jul 07, 2020 at 03:26:28PM -0500, Pierre-Louis Bossart wrote: > CONFIG_REGMAP is not selected when no other serial bus is supported. > It's largely academic since CONFIG_I2C is usually selected e.g. by > DRM, but still this can break randconfig so let's be explicit. > > Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> > --- > drivers/base/regmap/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/base/regmap/Kconfig b/drivers/base/regmap/Kconfig > index 0fd6f97ee523..1d1d26b0d279 100644 > --- a/drivers/base/regmap/Kconfig > +++ b/drivers/base/regmap/Kconfig > @@ -4,7 +4,7 @@ > # subsystems should select the appropriate symbols. > > config REGMAP > - default y if (REGMAP_I2C || REGMAP_SPI || REGMAP_SPMI || REGMAP_W1 || REGMAP_AC97 || REGMAP_MMIO || REGMAP_IRQ || REGMAP_SCCB || REGMAP_I3C) > + default y if (REGMAP_I2C || REGMAP_SPI || REGMAP_SPMI || REGMAP_W1 || REGMAP_AC97 || REGMAP_MMIO || REGMAP_IRQ || REGMAP_SOUNDWIRE || REGMAP_SCCB || REGMAP_I3C) Any reason you didn't add it to the end of the list instead of adding it to the middle?
On 7/8/20 2:14 AM, Greg Kroah-Hartman wrote: > On Tue, Jul 07, 2020 at 03:26:28PM -0500, Pierre-Louis Bossart wrote: >> CONFIG_REGMAP is not selected when no other serial bus is supported. >> It's largely academic since CONFIG_I2C is usually selected e.g. by >> DRM, but still this can break randconfig so let's be explicit. >> >> Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> >> --- >> drivers/base/regmap/Kconfig | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/base/regmap/Kconfig b/drivers/base/regmap/Kconfig >> index 0fd6f97ee523..1d1d26b0d279 100644 >> --- a/drivers/base/regmap/Kconfig >> +++ b/drivers/base/regmap/Kconfig >> @@ -4,7 +4,7 @@ >> # subsystems should select the appropriate symbols. >> >> config REGMAP >> - default y if (REGMAP_I2C || REGMAP_SPI || REGMAP_SPMI || REGMAP_W1 || REGMAP_AC97 || REGMAP_MMIO || REGMAP_IRQ || REGMAP_SCCB || REGMAP_I3C) >> + default y if (REGMAP_I2C || REGMAP_SPI || REGMAP_SPMI || REGMAP_W1 || REGMAP_AC97 || REGMAP_MMIO || REGMAP_IRQ || REGMAP_SOUNDWIRE || REGMAP_SCCB || REGMAP_I3C) > > Any reason you didn't add it to the end of the list instead of adding it > to the middle? yes, I followed the config order in the same file: grep config Kconfig config REGMAP config REGCACHE_COMPRESSED config REGMAP_AC97 config REGMAP_I2C config REGMAP_SLIMBUS config REGMAP_SPI config REGMAP_SPMI config REGMAP_W1 config REGMAP_MMIO config REGMAP_IRQ config REGMAP_SOUNDWIRE config REGMAP_SCCB config REGMAP_I3C
On Tue, 7 Jul 2020 15:26:28 -0500, Pierre-Louis Bossart wrote: > CONFIG_REGMAP is not selected when no other serial bus is supported. > It's largely academic since CONFIG_I2C is usually selected e.g. by > DRM, but still this can break randconfig so let's be explicit. Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regmap.git for-next Thanks! [1/1] regmap: add missing dependency on SoundWire commit: 443a34ba68e8a627c15f9987b11cfa01f3e1ba0a All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark
diff --git a/drivers/base/regmap/Kconfig b/drivers/base/regmap/Kconfig index 0fd6f97ee523..1d1d26b0d279 100644 --- a/drivers/base/regmap/Kconfig +++ b/drivers/base/regmap/Kconfig @@ -4,7 +4,7 @@ # subsystems should select the appropriate symbols. config REGMAP - default y if (REGMAP_I2C || REGMAP_SPI || REGMAP_SPMI || REGMAP_W1 || REGMAP_AC97 || REGMAP_MMIO || REGMAP_IRQ || REGMAP_SCCB || REGMAP_I3C) + default y if (REGMAP_I2C || REGMAP_SPI || REGMAP_SPMI || REGMAP_W1 || REGMAP_AC97 || REGMAP_MMIO || REGMAP_IRQ || REGMAP_SOUNDWIRE || REGMAP_SCCB || REGMAP_I3C) select IRQ_DOMAIN if REGMAP_IRQ bool
CONFIG_REGMAP is not selected when no other serial bus is supported. It's largely academic since CONFIG_I2C is usually selected e.g. by DRM, but still this can break randconfig so let's be explicit. Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> --- drivers/base/regmap/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)