| Message ID | 20200707210014.927691-6-mathieu.poirier@linaro.org (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | remoteproc: Add support for attaching with rproc | expand |
On 7/7/20 11:00 PM, Mathieu Poirier wrote: > Add a new function to assert the general health of the remote > processor before handing it to the remoteproc core. > > Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org> Reviewed-by: Arnaud Pouliquen <arnaud.pouliquen@st.com> Thanks, Arnaud > --- > drivers/remoteproc/remoteproc_core.c | 41 ++++++++++++++++++++++++++++ > 1 file changed, 41 insertions(+) > > diff --git a/drivers/remoteproc/remoteproc_core.c b/drivers/remoteproc/remoteproc_core.c > index fd424662801f..ad500c291d5f 100644 > --- a/drivers/remoteproc/remoteproc_core.c > +++ b/drivers/remoteproc/remoteproc_core.c > @@ -2040,6 +2040,43 @@ struct rproc *rproc_get_by_phandle(phandle phandle) > #endif > EXPORT_SYMBOL(rproc_get_by_phandle); > > +static int rproc_validate(struct rproc *rproc) > +{ > + switch (rproc->state) { > + case RPROC_OFFLINE: > + /* > + * An offline processor without a start() > + * function makes no sense. > + */ > + if (!rproc->ops->start) > + return -EINVAL; > + break; > + case RPROC_DETACHED: > + /* > + * A remote processor in a detached state without an > + * attach() function makes not sense. > + */ > + if (!rproc->ops->attach) > + return -EINVAL; > + /* > + * When attaching to a remote processor the device memory > + * is already available and as such there is no need to have a > + * cached table. > + */ > + if (rproc->cached_table) > + return -EINVAL; > + break; > + default: > + /* > + * When adding a remote processor, the state of the device > + * can be offline or detached, nothing else. > + */ > + return -EINVAL; > + } > + > + return 0; > +} > + > /** > * rproc_add() - register a remote processor > * @rproc: the remote processor handle to register > @@ -2069,6 +2106,10 @@ int rproc_add(struct rproc *rproc) > if (ret < 0) > return ret; > > + ret = rproc_validate(rproc); > + if (ret < 0) > + return ret; > + > dev_info(dev, "%s is available\n", rproc->name); > > /* create debugfs entries */ >
diff --git a/drivers/remoteproc/remoteproc_core.c b/drivers/remoteproc/remoteproc_core.c index fd424662801f..ad500c291d5f 100644 --- a/drivers/remoteproc/remoteproc_core.c +++ b/drivers/remoteproc/remoteproc_core.c @@ -2040,6 +2040,43 @@ struct rproc *rproc_get_by_phandle(phandle phandle) #endif EXPORT_SYMBOL(rproc_get_by_phandle); +static int rproc_validate(struct rproc *rproc) +{ + switch (rproc->state) { + case RPROC_OFFLINE: + /* + * An offline processor without a start() + * function makes no sense. + */ + if (!rproc->ops->start) + return -EINVAL; + break; + case RPROC_DETACHED: + /* + * A remote processor in a detached state without an + * attach() function makes not sense. + */ + if (!rproc->ops->attach) + return -EINVAL; + /* + * When attaching to a remote processor the device memory + * is already available and as such there is no need to have a + * cached table. + */ + if (rproc->cached_table) + return -EINVAL; + break; + default: + /* + * When adding a remote processor, the state of the device + * can be offline or detached, nothing else. + */ + return -EINVAL; + } + + return 0; +} + /** * rproc_add() - register a remote processor * @rproc: the remote processor handle to register @@ -2069,6 +2106,10 @@ int rproc_add(struct rproc *rproc) if (ret < 0) return ret; + ret = rproc_validate(rproc); + if (ret < 0) + return ret; + dev_info(dev, "%s is available\n", rproc->name); /* create debugfs entries */
Add a new function to assert the general health of the remote processor before handing it to the remoteproc core. Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org> --- drivers/remoteproc/remoteproc_core.c | 41 ++++++++++++++++++++++++++++ 1 file changed, 41 insertions(+)