[v3,04/16] dt-bindings: pinctrl: sunxi: make gpio banks supplies required
diff mbox series

Message ID 20200708071942.22595-5-frank@allwinnertech.com
State New
Headers show
Series
  • Allwinner A100 Initial support
Related show

Commit Message

Frank Lee July 8, 2020, 7:19 a.m. UTC
Since we don't really have to care about the existing DT for boards,
it would be great to make the gpio banks supplies required.

Signed-off-by: Frank Lee <frank@allwinnertech.com>
---
 .../devicetree/bindings/pinctrl/allwinner,sun4i-a10-pinctrl.yaml         | 1 +
 1 file changed, 1 insertion(+)

Comments

Rob Herring July 9, 2020, 4:52 p.m. UTC | #1
On Wed, 08 Jul 2020 15:19:30 +0800, Frank Lee wrote:
> Since we don't really have to care about the existing DT for boards,
> it would be great to make the gpio banks supplies required.
> 
> Signed-off-by: Frank Lee <frank@allwinnertech.com>
> ---
>  .../devicetree/bindings/pinctrl/allwinner,sun4i-a10-pinctrl.yaml         | 1 +
>  1 file changed, 1 insertion(+)
> 


My bot found errors running 'make dt_binding_check' on your patch:

/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/pinctrl/allwinner,sun4i-a10-pinctrl.yaml: required:2: '^vcc-p[a-hlm]-supply$' does not match '^([a-zA-Z#][a-zA-Z0-9,+\\-._@]{0,63}|\\$nodename)$'
Documentation/devicetree/bindings/Makefile:20: recipe for target 'Documentation/devicetree/bindings/pinctrl/allwinner,sun4i-a10-pinctrl.example.dts' failed
make[1]: *** [Documentation/devicetree/bindings/pinctrl/allwinner,sun4i-a10-pinctrl.example.dts] Error 1
make[1]: *** Waiting for unfinished jobs....
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/pinctrl/allwinner,sun4i-a10-pinctrl.yaml: ignoring, error in schema: required: 2
warning: no schema found in file: ./Documentation/devicetree/bindings/pinctrl/allwinner,sun4i-a10-pinctrl.yaml
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/pinctrl/allwinner,sun4i-a10-pinctrl.yaml: ignoring, error in schema: required: 2
warning: no schema found in file: ./Documentation/devicetree/bindings/pinctrl/allwinner,sun4i-a10-pinctrl.yaml
Makefile:1347: recipe for target 'dt_binding_check' failed
make: *** [dt_binding_check] Error 2


See https://patchwork.ozlabs.org/patch/1325057

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure dt-schema is up to date:

pip3 install git+https://github.com/devicetree-org/dt-schema.git@master --upgrade

Please check and re-submit.
Rob Herring July 9, 2020, 4:54 p.m. UTC | #2
On Wed, Jul 08, 2020 at 03:19:30PM +0800, Frank Lee wrote:
> Since we don't really have to care about the existing DT for boards,
> it would be great to make the gpio banks supplies required.
> 
> Signed-off-by: Frank Lee <frank@allwinnertech.com>
> ---
>  .../devicetree/bindings/pinctrl/allwinner,sun4i-a10-pinctrl.yaml         | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/pinctrl/allwinner,sun4i-a10-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/allwinner,sun4i-a10-pinctrl.yaml
> index 226aba0..c30a7b7 100644
> --- a/Documentation/devicetree/bindings/pinctrl/allwinner,sun4i-a10-pinctrl.yaml
> +++ b/Documentation/devicetree/bindings/pinctrl/allwinner,sun4i-a10-pinctrl.yaml
> @@ -134,6 +134,7 @@ patternProperties:
>  required:
>    - "#gpio-cells"
>    - "#interrupt-cells"
> +  - "^vcc-p[a-hlm]-supply$"

Patterns aren't supported here. It's something the json-schema folks 
are working on. For now, You have to list out the specific properties.

>    - compatible
>    - reg
>    - interrupts
> -- 
> 1.9.1
>
Ondřej Jirman July 9, 2020, 5:17 p.m. UTC | #3
Hello,

On Wed, Jul 08, 2020 at 03:19:30PM +0800, Frank Lee wrote:
> Since we don't really have to care about the existing DT for boards,
> it would be great to make the gpio banks supplies required.

What if the borad doesn't use one of the banks? How would
I describe such a board if defining supplies for all banks
is required?

regards,
	o.

> Signed-off-by: Frank Lee <frank@allwinnertech.com>
> ---
>  .../devicetree/bindings/pinctrl/allwinner,sun4i-a10-pinctrl.yaml         | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/pinctrl/allwinner,sun4i-a10-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/allwinner,sun4i-a10-pinctrl.yaml
> index 226aba0..c30a7b7 100644
> --- a/Documentation/devicetree/bindings/pinctrl/allwinner,sun4i-a10-pinctrl.yaml
> +++ b/Documentation/devicetree/bindings/pinctrl/allwinner,sun4i-a10-pinctrl.yaml
> @@ -134,6 +134,7 @@ patternProperties:
>  required:
>    - "#gpio-cells"
>    - "#interrupt-cells"
> +  - "^vcc-p[a-hlm]-supply$"
>    - compatible
>    - reg
>    - interrupts
> -- 
> 1.9.1
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Maxime Ripard July 10, 2020, 12:37 p.m. UTC | #4
Hi,

On Thu, Jul 09, 2020 at 07:17:13PM +0200, Ondřej Jirman wrote:
> Hello,
> 
> On Wed, Jul 08, 2020 at 03:19:30PM +0800, Frank Lee wrote:
> > Since we don't really have to care about the existing DT for boards,
> > it would be great to make the gpio banks supplies required.
> 
> What if the borad doesn't use one of the banks? How would
> I describe such a board if defining supplies for all banks
> is required?

If that case ever comes up, we can always drop the requirement, it's going to be backward
compatible.

Maxime

Patch
diff mbox series

diff --git a/Documentation/devicetree/bindings/pinctrl/allwinner,sun4i-a10-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/allwinner,sun4i-a10-pinctrl.yaml
index 226aba0..c30a7b7 100644
--- a/Documentation/devicetree/bindings/pinctrl/allwinner,sun4i-a10-pinctrl.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/allwinner,sun4i-a10-pinctrl.yaml
@@ -134,6 +134,7 @@  patternProperties:
 required:
   - "#gpio-cells"
   - "#interrupt-cells"
+  - "^vcc-p[a-hlm]-supply$"
   - compatible
   - reg
   - interrupts