[1/5] echoaudio: Remove redundant check
diff mbox series

Message ID 20200708101848.3457-1-mark@xwax.org
State New
Headers show
Series
  • [1/5] echoaudio: Remove redundant check
Related show

Commit Message

Mark Hills July 8, 2020, 10:18 a.m. UTC
This check is always false, as it's not the responsibilty of the
device-specific code to make this check. It is already checked
in snd_echo_digital_mode_put.

I do not have a Mona interface to test this change.

This patch is in preparation for follow-up patch to modify the
behavior of "opencount".

Signed-off-by: Mark Hills <mark@xwax.org>
---
 sound/pci/echoaudio/mona_dsp.c | 5 -----
 1 file changed, 5 deletions(-)

Comments

Takashi Iwai July 9, 2020, 11 a.m. UTC | #1
On Wed, 08 Jul 2020 12:18:44 +0200,
Mark Hills wrote:
> 
> This check is always false, as it's not the responsibilty of the
> device-specific code to make this check. It is already checked
> in snd_echo_digital_mode_put.
> 
> I do not have a Mona interface to test this change.
> 
> This patch is in preparation for follow-up patch to modify the
> behavior of "opencount".
> 
> Signed-off-by: Mark Hills <mark@xwax.org>

Applied now.  Thanks.


Takashi

Patch
diff mbox series

diff --git a/sound/pci/echoaudio/mona_dsp.c b/sound/pci/echoaudio/mona_dsp.c
index dce9e57d01c4..f77db83dd73d 100644
--- a/sound/pci/echoaudio/mona_dsp.c
+++ b/sound/pci/echoaudio/mona_dsp.c
@@ -300,11 +300,6 @@  static int set_input_clock(struct echoaudio *chip, u16 clock)
 	u32 control_reg, clocks_from_dsp;
 	int err;
 
-
-	/* Prevent two simultaneous calls to switch_asic() */
-	if (atomic_read(&chip->opencount))
-		return -EAGAIN;
-
 	/* Mask off the clock select bits */
 	control_reg = le32_to_cpu(chip->comm_page->control_register) &
 		GML_CLOCK_CLEAR_MASK;