From patchwork Wed Jul 8 10:18:44 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mark Hills X-Patchwork-Id: 11651283 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 1EE9C60D for ; Wed, 8 Jul 2020 10:19:48 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6BFB520760 for ; Wed, 8 Jul 2020 10:19:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="NSYJl02+"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=pogo.org.uk header.i=@pogo.org.uk header.b="K/jyssWS" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6BFB520760 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=xwax.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id EA9311670; Wed, 8 Jul 2020 12:18:58 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz EA9311670 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1594203586; bh=0BOxeo0NsnXb+G5/X7MZvSietyacdEjKd06EfAWnF5M=; h=From:To:Subject:Date:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=NSYJl02+BdQqGAjWgTNJyRm8wsRWQrHlmjUb6rZsjGGEoATq0b63fAtqHfBUK0iB7 3OjwfGH98gy3Lf197cCNiYZTeC+T514wm6Kmq88d5/+VvOu0Xe3+a7S6q+L6pJHhGX GtJ/4hn0/jLHnEdj6Psxpx/UT0qnqlhTRMBBDkHk= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 04AD3F8011F; Wed, 8 Jul 2020 12:18:58 +0200 (CEST) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa1.perex.cz (Postfix, from userid 50401) id 36193F80161; Wed, 8 Jul 2020 12:18:56 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on alsa1.perex.cz X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=disabled version=3.4.0 Received: from jazz.pogo.org.uk (jazz.pogo.org.uk [213.138.114.167]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id A90B9F8011F for ; Wed, 8 Jul 2020 12:18:49 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz A90B9F8011F Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=pogo.org.uk header.i=@pogo.org.uk header.b="K/jyssWS" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=pogo.org.uk ; s=a; h=References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender: Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=ViH/Mvvn/vkw0THcuwQj+htjgooqeoV5+Xy8sjVDlkA=; b=K/jyssWScZL9if+uebPUiP9oFa /Qhod6AJdseQnQY9gMv9hCkD55tNgV7/u8GB4hAki2AmfBveJWTN7zyvO6yKCRFruV5jz2l/pbr07 T6X6C8WXMthiBxVLqKy7fCUDifnv7vYAVPmhpnTB+iFVdV1XKZ73FRvK3ch49lFSn7ctIA6n5RFHK YsHPIcBHJj44utCYI9pDqJmGcH2RL/lmwzzqclUnpnH6kwHuzC9Jco0UlaiseGpWTlDE5nLfDVzAo qUD1YM2FkR6cM3f8s1ADm5PA7uYNqPhtY00UGlhhtYkPG8nLBldFRhL7NtALhfDYTr2wenVucGtKK t/nYTGzg==; Received: from cpc1-hari17-2-0-cust102.20-2.cable.virginm.net ([86.18.4.103] helo=stax.localdomain) by jazz.pogo.org.uk with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94 (FreeBSD)) (envelope-from ) id 1jt7A8-0002Q4-Fy; Wed, 08 Jul 2020 11:18:48 +0100 Received: from mark by stax.localdomain with local (Exim 4.84) (envelope-from ) id 1jt7A8-0000uQ-3r; Wed, 08 Jul 2020 11:18:48 +0100 From: Mark Hills To: Takashi Iwai Subject: [PATCH 1/5] echoaudio: Remove redundant check Date: Wed, 8 Jul 2020 11:18:44 +0100 Message-Id: <20200708101848.3457-1-mark@xwax.org> X-Mailer: git-send-email 2.17.5 In-Reply-To: <2007081115280.3085@stax.localdomain> References: <2007081115280.3085@stax.localdomain> Cc: alsa-devel@alsa-project.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" This check is always false, as it's not the responsibilty of the device-specific code to make this check. It is already checked in snd_echo_digital_mode_put. I do not have a Mona interface to test this change. This patch is in preparation for follow-up patch to modify the behavior of "opencount". Signed-off-by: Mark Hills --- sound/pci/echoaudio/mona_dsp.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/sound/pci/echoaudio/mona_dsp.c b/sound/pci/echoaudio/mona_dsp.c index dce9e57d01c4..f77db83dd73d 100644 --- a/sound/pci/echoaudio/mona_dsp.c +++ b/sound/pci/echoaudio/mona_dsp.c @@ -300,11 +300,6 @@ static int set_input_clock(struct echoaudio *chip, u16 clock) u32 control_reg, clocks_from_dsp; int err; - - /* Prevent two simultaneous calls to switch_asic() */ - if (atomic_read(&chip->opencount)) - return -EAGAIN; - /* Mask off the clock select bits */ control_reg = le32_to_cpu(chip->comm_page->control_register) & GML_CLOCK_CLEAR_MASK;