| Message ID | 248e7089f7fbb3727e83a1dfb43820d96a69e8c2.1594231056.git.mirq-linux@rere.qmqm.pl (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | 30517ffeb3bff842e1355cbc32f1959d9dbb5414 |
| Headers | show |
| Series | usb: gadget: udc: atmel: assorted fixes | expand |
On 08/07/2020 20:04:09+0200, Michał Mirosław wrote: > Fixed commit moved the assignment of 'req', but did not update a > reference in the DBG() call. Use the argument as it was renamed. > > Fixes: 5fb694f96e7c ("usb: gadget: udc: atmel: fix possible oops when unloading module") > Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl> Acked-by: Alexandre Belloni <alexandre.belloni@bootlin.com> > --- > drivers/usb/gadget/udc/atmel_usba_udc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/gadget/udc/atmel_usba_udc.c b/drivers/usb/gadget/udc/atmel_usba_udc.c > index 9153e220848d..9342a3d24963 100644 > --- a/drivers/usb/gadget/udc/atmel_usba_udc.c > +++ b/drivers/usb/gadget/udc/atmel_usba_udc.c > @@ -865,7 +865,7 @@ static int usba_ep_dequeue(struct usb_ep *_ep, struct usb_request *_req) > u32 status; > > DBG(DBG_GADGET | DBG_QUEUE, "ep_dequeue: %s, req %p\n", > - ep->ep.name, req); > + ep->ep.name, _req); > > spin_lock_irqsave(&udc->lock, flags); > > -- > 2.20.1 >
On 7/16/20 12:45 AM, Alexandre Belloni wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > On 08/07/2020 20:04:09+0200, Michał Mirosław wrote: >> Fixed commit moved the assignment of 'req', but did not update a >> reference in the DBG() call. Use the argument as it was renamed. >> >> Fixes: 5fb694f96e7c ("usb: gadget: udc: atmel: fix possible oops when unloading module") >> Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl> > Acked-by: Alexandre Belloni <alexandre.belloni@bootlin.com> Acked-by: Cristian Birsan <cristian.birsan@microchip.com> > >> --- >> drivers/usb/gadget/udc/atmel_usba_udc.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/usb/gadget/udc/atmel_usba_udc.c b/drivers/usb/gadget/udc/atmel_usba_udc.c >> index 9153e220848d..9342a3d24963 100644 >> --- a/drivers/usb/gadget/udc/atmel_usba_udc.c >> +++ b/drivers/usb/gadget/udc/atmel_usba_udc.c >> @@ -865,7 +865,7 @@ static int usba_ep_dequeue(struct usb_ep *_ep, struct usb_request *_req) >> u32 status; >> >> DBG(DBG_GADGET | DBG_QUEUE, "ep_dequeue: %s, req %p\n", >> - ep->ep.name, req); >> + ep->ep.name, _req); >> >> spin_lock_irqsave(&udc->lock, flags); >> >> -- >> 2.20.1 >> > > -- > Alexandre Belloni, Bootlin > Embedded Linux and Kernel engineering > https://bootlin.com >
diff --git a/drivers/usb/gadget/udc/atmel_usba_udc.c b/drivers/usb/gadget/udc/atmel_usba_udc.c index 9153e220848d..9342a3d24963 100644 --- a/drivers/usb/gadget/udc/atmel_usba_udc.c +++ b/drivers/usb/gadget/udc/atmel_usba_udc.c @@ -865,7 +865,7 @@ static int usba_ep_dequeue(struct usb_ep *_ep, struct usb_request *_req) u32 status; DBG(DBG_GADGET | DBG_QUEUE, "ep_dequeue: %s, req %p\n", - ep->ep.name, req); + ep->ep.name, _req); spin_lock_irqsave(&udc->lock, flags);
Fixed commit moved the assignment of 'req', but did not update a reference in the DBG() call. Use the argument as it was renamed. Fixes: 5fb694f96e7c ("usb: gadget: udc: atmel: fix possible oops when unloading module") Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl> --- drivers/usb/gadget/udc/atmel_usba_udc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)