[v2] ARM: dts: vf610-zii-dev-rev-c: Configure fiber port to 1000BaseX
diff mbox series

Message ID 20200708232501.6200-1-cphealy@gmail.com
State Mainlined
Commit bcf9d4672916a84f2856572fad3e3b76e426147d
Headers show
Series
  • [v2] ARM: dts: vf610-zii-dev-rev-c: Configure fiber port to 1000BaseX
Related show

Commit Message

Chris Healy July 8, 2020, 11:25 p.m. UTC
The SFF soldered onto the board expects the port to use 1000BaseX.  It
makes no sense to have the port set to SGMII, since it doesn't even
support that mode.

Signed-off-by: Chris Healy <cphealy@gmail.com>
---
v2:
- convert spaces back to tabs
- remove .dts from subject line

 arch/arm/boot/dts/vf610-zii-dev-rev-c.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Fabio Estevam July 9, 2020, 12:11 a.m. UTC | #1
On Wed, Jul 8, 2020 at 8:25 PM Chris Healy <cphealy@gmail.com> wrote:
>
> The SFF soldered onto the board expects the port to use 1000BaseX.  It
> makes no sense to have the port set to SGMII, since it doesn't even
> support that mode.
>
> Signed-off-by: Chris Healy <cphealy@gmail.com>

Reviewed-by: Fabio Estevam <festevam@gmail.com>
Shawn Guo July 13, 2020, 8:23 a.m. UTC | #2
On Wed, Jul 08, 2020 at 04:25:01PM -0700, Chris Healy wrote:
> The SFF soldered onto the board expects the port to use 1000BaseX.  It
> makes no sense to have the port set to SGMII, since it doesn't even
> support that mode.
> 
> Signed-off-by: Chris Healy <cphealy@gmail.com>

Applied, thanks.

Patch
diff mbox series

diff --git a/arch/arm/boot/dts/vf610-zii-dev-rev-c.dts b/arch/arm/boot/dts/vf610-zii-dev-rev-c.dts
index 778e02c000d1..de79dcfd32e6 100644
--- a/arch/arm/boot/dts/vf610-zii-dev-rev-c.dts
+++ b/arch/arm/boot/dts/vf610-zii-dev-rev-c.dts
@@ -164,7 +164,7 @@ 
 					port@9 {
 						reg = <9>;
 						label = "sff2";
-						phy-mode = "sgmii";
+						phy-mode = "1000base-x";
 						managed = "in-band-status";
 						sfp = <&sff2>;
 					};