xfs_quota: display warning limits when printing quota type information
diff mbox series

Message ID 20200709161124.GP7606@magnolia
State Superseded
Headers show
Series
  • xfs_quota: display warning limits when printing quota type information
Related show

Commit Message

Darrick J. Wong July 9, 2020, 4:11 p.m. UTC
From: Darrick J. Wong <darrick.wong@oracle.com>

We should dump the default warning limits when we're printing quota
information.

Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
---
 quota/state.c |   14 ++++++++++++++
 1 file changed, 14 insertions(+)

Comments

Christoph Hellwig July 10, 2020, 8:59 a.m. UTC | #1
On Thu, Jul 09, 2020 at 09:11:24AM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@oracle.com>
> 
> We should dump the default warning limits when we're printing quota
> information.

This looks sensible.  Do we need any xfstests changes for thew new
output, though?

Reviewed-by: Christoph Hellwig <hch@lst.de>
Darrick J. Wong July 10, 2020, 3:42 p.m. UTC | #2
On Fri, Jul 10, 2020 at 09:59:06AM +0100, Christoph Hellwig wrote:
> On Thu, Jul 09, 2020 at 09:11:24AM -0700, Darrick J. Wong wrote:
> > From: Darrick J. Wong <darrick.wong@oracle.com>
> > 
> > We should dump the default warning limits when we're printing quota
> > information.
> 
> This looks sensible.  Do we need any xfstests changes for thew new
> output, though?
> 
> Reviewed-by: Christoph Hellwig <hch@lst.de>

Yep.  I'll throw that series in at the end of the next round of the
quota refactoring.

--D

Patch
diff mbox series

diff --git a/quota/state.c b/quota/state.c
index 8f9718f1..a90b0d9e 100644
--- a/quota/state.c
+++ b/quota/state.c
@@ -130,6 +130,16 @@  state_timelimit(
 		time_to_string(timelimit, VERBOSE_FLAG | ABSOLUTE_FLAG));
 }
 
+static void
+state_warnlimit(
+	FILE		*fp,
+	uint		form,
+	uint16_t	warnlimit)
+{
+	fprintf(fp, _("%s max warnings: %u\n"),
+		form_to_string(form), warnlimit);
+}
+
 /*
  * fs_quota_stat holds a subset of fs_quota_statv; this copies
  * the smaller into the larger, leaving any not-present fields
@@ -218,7 +228,11 @@  state_quotafile_mount(
 				sv.qs_flags & XFS_QUOTA_PDQ_ENFD);
 
 	state_timelimit(fp, XFS_BLOCK_QUOTA, sv.qs_btimelimit);
+	state_warnlimit(fp, XFS_BLOCK_QUOTA, sv.qs_bwarnlimit);
+
 	state_timelimit(fp, XFS_INODE_QUOTA, sv.qs_itimelimit);
+	state_warnlimit(fp, XFS_INODE_QUOTA, sv.qs_iwarnlimit);
+
 	state_timelimit(fp, XFS_RTBLOCK_QUOTA, sv.qs_rtbtimelimit);
 }