[36/38] ci: run tests with SHA-256
diff mbox series

Message ID 20200710024728.3100527-37-sandals@crustytoothpaste.net
State New
Headers show
Series
  • SHA-256, part 3/3
Related show

Commit Message

brian m. carlson July 10, 2020, 2:47 a.m. UTC
Now that we have Git supporting SHA-256, we'd like to make sure that we
don't regress that state.  Unfortunately, it's easy to do so, so to
help, let's run one of our CI jobs with SHA-256 as the default hash.
This will help us detect any problems that may occur.

Signed-off-by: brian m. carlson <sandals@crustytoothpaste.net>
---
 ci/run-build-and-tests.sh | 1 +
 1 file changed, 1 insertion(+)

Comments

Derrick Stolee July 10, 2020, 3:09 p.m. UTC | #1
On 7/9/2020 10:47 PM, brian m. carlson wrote:
> Now that we have Git supporting SHA-256, we'd like to make sure that we
> don't regress that state.  Unfortunately, it's easy to do so, so to
> help, let's run one of our CI jobs with SHA-256 as the default hash.
> This will help us detect any problems that may occur.
> 
> Signed-off-by: brian m. carlson <sandals@crustytoothpaste.net>
> ---
>  ci/run-build-and-tests.sh | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/ci/run-build-and-tests.sh b/ci/run-build-and-tests.sh
> index 17e25aade9..b41b527b15 100755
> --- a/ci/run-build-and-tests.sh
> +++ b/ci/run-build-and-tests.sh
> @@ -22,6 +22,7 @@ linux-gcc)
>  	export GIT_TEST_COMMIT_GRAPH_CHANGED_PATHS=1
>  	export GIT_TEST_MULTI_PACK_INDEX=1
>  	export GIT_TEST_ADD_I_USE_BUILTIN=1
> +	export GIT_TEST_DEFAULT_HASH=sha256

I was hoping that we'd have a default hash setting available
in CI, and this delivers!

However, this place changes the mode along with a bunch of
other "optional" GIT_TEST_* variables, so the sha256 mode is
not being tested on its own.

I think that the SHA-256 support is a big enough task that
perhaps it should be part of the "matrix" in the jobs list
inside .github/workflows/main.yml. Of course, I don't
understand that system enough to contribute my own patch.
For that reason, this patch is an excellent first step!

Let's keep my thoughts on creating new parallel builds for
SHA-256 mode as a future enhancement.

Thanks,
-Stolee

Patch
diff mbox series

diff --git a/ci/run-build-and-tests.sh b/ci/run-build-and-tests.sh
index 17e25aade9..b41b527b15 100755
--- a/ci/run-build-and-tests.sh
+++ b/ci/run-build-and-tests.sh
@@ -22,6 +22,7 @@  linux-gcc)
 	export GIT_TEST_COMMIT_GRAPH_CHANGED_PATHS=1
 	export GIT_TEST_MULTI_PACK_INDEX=1
 	export GIT_TEST_ADD_I_USE_BUILTIN=1
+	export GIT_TEST_DEFAULT_HASH=sha256
 	make test
 	;;
 linux-gcc-4.8)