diff mbox series

[3/5] power: supply: core: add wireless signal strength property

Message ID 20200710084841.1933254-3-yanziily@gmail.com (mailing list archive)
State Not Applicable, archived
Headers show
Series [1/5] power: supply: core: add quick charge type property | expand

Commit Message

Qiwu Huang July 10, 2020, 8:48 a.m. UTC
From: Qiwu Huang <huangqiwu@xiaomi.com>

reports wireless signal strength.
The value show degree of coupling between tx and rx.

Signed-off-by: Qiwu Huang <huangqiwu@xiaomi.com>
---
 Documentation/ABI/testing/sysfs-class-power | 9 ++++++++-
 drivers/power/supply/power_supply_sysfs.c   | 1 +
 include/linux/power_supply.h                | 1 +
 3 files changed, 10 insertions(+), 1 deletion(-)

Comments

Greg KH July 10, 2020, 10:01 a.m. UTC | #1
On Fri, Jul 10, 2020 at 04:48:39PM +0800, Qiwu Huang wrote:
> From: Qiwu Huang <huangqiwu@xiaomi.com>
> 
> reports wireless signal strength.
> The value show degree of coupling between tx and rx.
> 
> Signed-off-by: Qiwu Huang <huangqiwu@xiaomi.com>
> ---
>  Documentation/ABI/testing/sysfs-class-power | 9 ++++++++-
>  drivers/power/supply/power_supply_sysfs.c   | 1 +
>  include/linux/power_supply.h                | 1 +
>  3 files changed, 10 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/ABI/testing/sysfs-class-power b/Documentation/ABI/testing/sysfs-class-power
> index 2099cf194a89..1f42aa0c071e 100644
> --- a/Documentation/ABI/testing/sysfs-class-power
> +++ b/Documentation/ABI/testing/sysfs-class-power
> @@ -730,4 +730,11 @@ Description:
>  
>  		Access: Read-Only
>  		Valid values: "ADAPTER_NONE", "ADAPTER_SDP", "ADAPTER_DCP", "ADAPTER_CDP",
> -		"ADAPTER_QC2", "ADAPTER_QC3", "ADAPTER_PD" or other private adapter.
> \ No newline at end of file
> +		"ADAPTER_QC2", "ADAPTER_QC3", "ADAPTER_PD" or other private adapter.
> +
> +What:		/sys/class/power_supply/<supply_name>/signal_strength
> +Date:		Jul 2020
> +Contact:	Fei Jiang <jiangfei1@xiaomi.com>
> +Description:
> +		Reports wireless signal strength.
> +		The value show degree of coupling.

What units are this in?  The "value" means what?

thanks,

greg k-h
Fei1 Jiang 蒋飞 July 10, 2020, 11:03 a.m. UTC | #2
Hi Greg,

/sys/class/power_supply/<supply_name>/signal_strength
What units are this in?  The "value" means what?

--> Unit is KHZ, the return value is also integer, the "value" means the working frequency of receiver chip of wireless charging.

B&R
Fei Jiang

-----邮件原件-----
发件人: Greg KH <gregkh@linuxfoundation.org>
发送时间: 2020年7月10日 18:01
收件人: Qiwu Huang <yanziily@gmail.com>
抄送: sre@kernel.org; linux-pm@vger.kernel.org; linux-kernel@vger.kernel.org; Fei1 Jiang 蒋飞 <jiangfei1@xiaomi.com>; 黄其武 <huangqiwu@xiaomi.com>
主题: [External Mail]Re: [PATCH 3/5] power: supply: core: add wireless signal strength property

On Fri, Jul 10, 2020 at 04:48:39PM +0800, Qiwu Huang wrote:
> From: Qiwu Huang <huangqiwu@xiaomi.com>
>
> reports wireless signal strength.
> The value show degree of coupling between tx and rx.
>
> Signed-off-by: Qiwu Huang <huangqiwu@xiaomi.com>
> ---
>  Documentation/ABI/testing/sysfs-class-power | 9 ++++++++-
>  drivers/power/supply/power_supply_sysfs.c   | 1 +
>  include/linux/power_supply.h                | 1 +
>  3 files changed, 10 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/ABI/testing/sysfs-class-power b/Documentation/ABI/testing/sysfs-class-power
> index 2099cf194a89..1f42aa0c071e 100644
> --- a/Documentation/ABI/testing/sysfs-class-power
> +++ b/Documentation/ABI/testing/sysfs-class-power
> @@ -730,4 +730,11 @@ Description:
>
>  Access: Read-Only
>  Valid values: "ADAPTER_NONE", "ADAPTER_SDP", "ADAPTER_DCP", "ADAPTER_CDP",
> -"ADAPTER_QC2", "ADAPTER_QC3", "ADAPTER_PD" or other private adapter.
> \ No newline at end of file
> +"ADAPTER_QC2", "ADAPTER_QC3", "ADAPTER_PD" or other private adapter.
> +
> +What:/sys/class/power_supply/<supply_name>/signal_strength
> +Date:Jul 2020
> +Contact:Fei Jiang <jiangfei1@xiaomi.com>
> +Description:
> +Reports wireless signal strength.
> +The value show degree of coupling.

What units are this in?  The "value" means what?

thanks,

greg k-h
#/******本邮件及其附件含有小米公司的保密信息,仅限于发送给上面地址中列出的个人或群组。禁止任何其他人以任何形式使用(包括但不限于全部或部分地泄露、复制、或散发)本邮件中的信息。如果您错收了本邮件,请您立即电话或邮件通知发件人并删除本邮件! This e-mail and its attachments contain confidential information from XIAOMI, which is intended only for the person or entity whose address is listed above. Any use of the information contained herein in any way (including, but not limited to, total or partial disclosure, reproduction, or dissemination) by persons other than the intended recipient(s) is prohibited. If you receive this e-mail in error, please notify the sender by phone or email immediately and delete it!******/#
diff mbox series

Patch

diff --git a/Documentation/ABI/testing/sysfs-class-power b/Documentation/ABI/testing/sysfs-class-power
index 2099cf194a89..1f42aa0c071e 100644
--- a/Documentation/ABI/testing/sysfs-class-power
+++ b/Documentation/ABI/testing/sysfs-class-power
@@ -730,4 +730,11 @@  Description:
 
 		Access: Read-Only
 		Valid values: "ADAPTER_NONE", "ADAPTER_SDP", "ADAPTER_DCP", "ADAPTER_CDP",
-		"ADAPTER_QC2", "ADAPTER_QC3", "ADAPTER_PD" or other private adapter.
\ No newline at end of file
+		"ADAPTER_QC2", "ADAPTER_QC3", "ADAPTER_PD" or other private adapter.
+
+What:		/sys/class/power_supply/<supply_name>/signal_strength
+Date:		Jul 2020
+Contact:	Fei Jiang <jiangfei1@xiaomi.com>
+Description:
+		Reports wireless signal strength.
+		The value show degree of coupling.
\ No newline at end of file
diff --git a/drivers/power/supply/power_supply_sysfs.c b/drivers/power/supply/power_supply_sysfs.c
index c864a14829ec..42fbe1b68255 100644
--- a/drivers/power/supply/power_supply_sysfs.c
+++ b/drivers/power/supply/power_supply_sysfs.c
@@ -208,6 +208,7 @@  static struct power_supply_attr power_supply_attrs[] = {
 	POWER_SUPPLY_ATTR(SERIAL_NUMBER),
 	POWER_SUPPLY_ATTR(quick_charge_type),
 	POWER_SUPPLY_ATTR(tx_adapter),
+	POWER_SUPPLY_ATTR(signal_strength),
 };
 
 static struct attribute *
diff --git a/include/linux/power_supply.h b/include/linux/power_supply.h
index 2de9a4c93723..397fb8e96b03 100644
--- a/include/linux/power_supply.h
+++ b/include/linux/power_supply.h
@@ -169,6 +169,7 @@  enum power_supply_property {
 	POWER_SUPPLY_PROP_SERIAL_NUMBER,
 	POWER_SUPPLY_PROP_QUICK_CHARGE_TYPE,
 	POWER_SUPPLY_PROP_TX_ADAPTER,
+	POWER_SUPPLY_PROP_SIGNAL_STRENGTH,
 };
 
 enum power_supply_type {