[RFC,1/4] dt-bindings:thermal:Add cold trip point type
diff mbox series

Message ID 20200710135154.181454-2-thara.gopinath@linaro.org
State New
Headers show
Series
  • thermal: Introduce support for monitoring falling temperature
Related show

Commit Message

Thara Gopinath July 10, 2020, 1:51 p.m. UTC
Extend thermal trip point type property to include "cold" trip type
indicating point in the temperature domain below which a warming action
must be intiated.

Signed-off-by: Thara Gopinath <thara.gopinath@linaro.org>
---
 Documentation/devicetree/bindings/thermal/thermal.txt | 1 +
 1 file changed, 1 insertion(+)

Comments

Daniel Lezcano July 13, 2020, 3:05 p.m. UTC | #1
On 10/07/2020 15:51, Thara Gopinath wrote:
> Extend thermal trip point type property to include "cold" trip type
> indicating point in the temperature domain below which a warming action
> must be intiated.
> 
> Signed-off-by: Thara Gopinath <thara.gopinath@linaro.org>
> ---
>  Documentation/devicetree/bindings/thermal/thermal.txt | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/thermal/thermal.txt b/Documentation/devicetree/bindings/thermal/thermal.txt
> index f78bec19ca35..1689d9ba1471 100644
> --- a/Documentation/devicetree/bindings/thermal/thermal.txt
> +++ b/Documentation/devicetree/bindings/thermal/thermal.txt
> @@ -87,6 +87,7 @@ Required properties:
>  	"active":	A trip point to enable active cooling
>  	"passive":	A trip point to enable passive cooling
>  	"hot":		A trip point to notify emergency
> +	"cold":		A trip point to enable warming
>  	"critical":	Hardware not reliable.
>    Type: string


thermal.txt should have been removed. Perhaps, a patch is missing. The
thermal.txt has been converted into 3 yaml schema.

The change should be in thermal-zones.yaml.
Thara Gopinath July 13, 2020, 5:01 p.m. UTC | #2
On 7/13/20 11:05 AM, Daniel Lezcano wrote:
> On 10/07/2020 15:51, Thara Gopinath wrote:
>> Extend thermal trip point type property to include "cold" trip type
>> indicating point in the temperature domain below which a warming action
>> must be intiated.
>>
>> Signed-off-by: Thara Gopinath <thara.gopinath@linaro.org>
>> ---
>>   Documentation/devicetree/bindings/thermal/thermal.txt | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/Documentation/devicetree/bindings/thermal/thermal.txt b/Documentation/devicetree/bindings/thermal/thermal.txt
>> index f78bec19ca35..1689d9ba1471 100644
>> --- a/Documentation/devicetree/bindings/thermal/thermal.txt
>> +++ b/Documentation/devicetree/bindings/thermal/thermal.txt
>> @@ -87,6 +87,7 @@ Required properties:
>>   	"active":	A trip point to enable active cooling
>>   	"passive":	A trip point to enable passive cooling
>>   	"hot":		A trip point to notify emergency
>> +	"cold":		A trip point to enable warming
>>   	"critical":	Hardware not reliable.
>>     Type: string
> 
> 
> thermal.txt should have been removed. Perhaps, a patch is missing. The
> thermal.txt has been converted into 3 yaml schema.
> 
> The change should be in thermal-zones.yaml.

Hi Daniel..

Thanks for the review. My bad.. I will fix this in the next version.
I can send a patch removing thermal.txt as well


> 
>
Daniel Lezcano July 13, 2020, 5:03 p.m. UTC | #3
On 13/07/2020 19:01, Thara Gopinath wrote:
> 
> 
> On 7/13/20 11:05 AM, Daniel Lezcano wrote:
>> On 10/07/2020 15:51, Thara Gopinath wrote:
>>> Extend thermal trip point type property to include "cold" trip type
>>> indicating point in the temperature domain below which a warming action
>>> must be intiated.
>>>
>>> Signed-off-by: Thara Gopinath <thara.gopinath@linaro.org>
>>> ---
>>>   Documentation/devicetree/bindings/thermal/thermal.txt | 1 +
>>>   1 file changed, 1 insertion(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/thermal/thermal.txt
>>> b/Documentation/devicetree/bindings/thermal/thermal.txt
>>> index f78bec19ca35..1689d9ba1471 100644
>>> --- a/Documentation/devicetree/bindings/thermal/thermal.txt
>>> +++ b/Documentation/devicetree/bindings/thermal/thermal.txt
>>> @@ -87,6 +87,7 @@ Required properties:
>>>       "active":    A trip point to enable active cooling
>>>       "passive":    A trip point to enable passive cooling
>>>       "hot":        A trip point to notify emergency
>>> +    "cold":        A trip point to enable warming
>>>       "critical":    Hardware not reliable.
>>>     Type: string
>>
>>
>> thermal.txt should have been removed. Perhaps, a patch is missing. The
>> thermal.txt has been converted into 3 yaml schema.
>>
>> The change should be in thermal-zones.yaml.
> 
> Hi Daniel..
> 
> Thanks for the review. My bad.. I will fix this in the next version.
> I can send a patch removing thermal.txt as well

Yes, sure.

Thanks

Patch
diff mbox series

diff --git a/Documentation/devicetree/bindings/thermal/thermal.txt b/Documentation/devicetree/bindings/thermal/thermal.txt
index f78bec19ca35..1689d9ba1471 100644
--- a/Documentation/devicetree/bindings/thermal/thermal.txt
+++ b/Documentation/devicetree/bindings/thermal/thermal.txt
@@ -87,6 +87,7 @@  Required properties:
 	"active":	A trip point to enable active cooling
 	"passive":	A trip point to enable passive cooling
 	"hot":		A trip point to notify emergency
+	"cold":		A trip point to enable warming
 	"critical":	Hardware not reliable.
   Type: string