[v3] ALSA: hda/realtek: enable headset mic of ASUS ROG Zephyrus G14(G401) series with ALC289
diff mbox series

Message ID 20200711110557.18681-1-zappel@retarded.farm
State New
Headers show
Series
  • [v3] ALSA: hda/realtek: enable headset mic of ASUS ROG Zephyrus G14(G401) series with ALC289
Related show

Commit Message

Armas Spann July 11, 2020, 11:05 a.m. UTC
Signed-off-by: Armas Spann <zappel@retarded.farm>
---
 Description:
 This patch adds support for headset mic to the ASUS ROG Zephyrus G14(GA401) 
 notebook series by adding the corresponding vendor/pci_device id, as well as
 adding a new fixup for the used realtek ALC289. The fixup stets the correct
 pin to get the headset mic correctly recognized on audio-jack.

 Changelog:
 v1: initial
 v2: added missing vendor and device(pci) id
 v3: added description

 sound/pci/hda/patch_realtek.c | 9 +++++++++
 1 file changed, 9 insertions(+)

Comments

Takashi Iwai July 11, 2020, 11:34 a.m. UTC | #1
On Sat, 11 Jul 2020 13:05:57 +0200,
Armas Spann wrote:
> 
> Signed-off-by: Armas Spann <zappel@retarded.farm>
> ---
>  Description:
>  This patch adds support for headset mic to the ASUS ROG Zephyrus G14(GA401) 
>  notebook series by adding the corresponding vendor/pci_device id, as well as
>  adding a new fixup for the used realtek ALC289. The fixup stets the correct
>  pin to get the headset mic correctly recognized on audio-jack.

I applied this version with the description above moved in the
right place now.  Also added Cc to stable as it's a simple fix.


Thanks!

Takashi
Armas Spann July 11, 2020, 11:37 a.m. UTC | #2
Am Samstag, den 11.07.2020, 13:34 +0200 schrieb Takashi Iwai:
> On Sat, 11 Jul 2020 13:05:57 +0200,
> Armas Spann wrote:
> > Signed-off-by: Armas Spann <
> > zappel@retarded.farm
> > >
> > ---
> >  Description:
> >  This patch adds support for headset mic to the ASUS ROG Zephyrus
> > G14(GA401) 
> >  notebook series by adding the corresponding vendor/pci_device id, as well
> > as
> >  adding a new fixup for the used realtek ALC289. The fixup stets the correct
> >  pin to get the headset mic correctly recognized on audio-jack.
> 
> I applied this version with the description above moved in the
> right place now.  Also added Cc to stable as it's a simple fix.
> 
> 
> Thanks!
> 
> Takashi
> 

Many Thanks! 

Next time I'll respect all the tips you gave me. Thanks for your feedback and
support on this "simple" task.


Best Regards,
Armas Spann

Patch
diff mbox series

diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 194ffa8c66ce..ff4f3eeedfd0 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -6152,6 +6152,7 @@  enum {
 	ALC269VC_FIXUP_ACER_VCOPPERBOX_PINS,
 	ALC269VC_FIXUP_ACER_HEADSET_MIC,
 	ALC269VC_FIXUP_ACER_MIC_NO_PRESENCE,
+	ALC289_FIXUP_ASUS_G401,
 };
 
 static const struct hda_fixup alc269_fixups[] = {
@@ -7359,6 +7360,13 @@  static const struct hda_fixup alc269_fixups[] = {
 		.chained = true,
 		.chain_id = ALC269_FIXUP_HEADSET_MIC
 	},
+	[ALC289_FIXUP_ASUS_G401] = {
+		.type = HDA_FIXUP_PINS,
+		.v.pins = (const struct hda_pintbl[]) {
+			{ 0x19, 0x03a11020 }, /* headset mic with jack detect */
+			{ }
+		},
+	},
 };
 
 static const struct snd_pci_quirk alc269_fixup_tbl[] = {
@@ -7539,6 +7547,7 @@  static const struct snd_pci_quirk alc269_fixup_tbl[] = {
 	SND_PCI_QUIRK(0x1043, 0x1bbd, "ASUS Z550MA", ALC255_FIXUP_ASUS_MIC_NO_PRESENCE),
 	SND_PCI_QUIRK(0x1043, 0x1c23, "Asus X55U", ALC269_FIXUP_LIMIT_INT_MIC_BOOST),
 	SND_PCI_QUIRK(0x1043, 0x1ccd, "ASUS X555UB", ALC256_FIXUP_ASUS_MIC),
+	SND_PCI_QUIRK(0x1043, 0x1f11, "ASUS Zephyrus G14", ALC289_FIXUP_ASUS_G401),
 	SND_PCI_QUIRK(0x1043, 0x3030, "ASUS ZN270IE", ALC256_FIXUP_ASUS_AIO_GPIO2),
 	SND_PCI_QUIRK(0x1043, 0x831a, "ASUS P901", ALC269_FIXUP_STEREO_DMIC),
 	SND_PCI_QUIRK(0x1043, 0x834a, "ASUS S101", ALC269_FIXUP_STEREO_DMIC),