Staging: vc04_services: Fix code indent error
diff mbox series

Message ID 20200713072224.7648-1-kundubaidya99@gmail.com
State New
Headers show
Series
  • Staging: vc04_services: Fix code indent error
Related show

Commit Message

Baidyanath Kundu July 13, 2020, 7:22 a.m. UTC
This patch fixes the checkpatch.pl error:

ERROR: code indent should use tabs where possible

Signed-off-by: Baidyanath Kundu <kundubaidya99@gmail.com>
---
 .../staging/vc04_services/vchiq-mmal/mmal-vchiq.c  | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

Comments

Greg KH July 13, 2020, 1:35 p.m. UTC | #1
On Mon, Jul 13, 2020 at 12:52:24PM +0530, Baidyanath Kundu wrote:
> This patch fixes the checkpatch.pl error:
> 
> ERROR: code indent should use tabs where possible
> 
> Signed-off-by: Baidyanath Kundu <kundubaidya99@gmail.com>
> ---
>  .../staging/vc04_services/vchiq-mmal/mmal-vchiq.c  | 14 +++++++-------
>  1 file changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c b/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c
> index a075cd63da7f..86c00b68f099 100644
> --- a/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c
> +++ b/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c
> @@ -294,13 +294,13 @@ static void buffer_to_host_work_cb(struct work_struct *work)
>  	/* queue the bulk submission */
>  	vchiq_use_service(instance->service_handle);
>  	ret = vchiq_bulk_receive(instance->service_handle,
> -				 msg_context->u.bulk.buffer->buffer,
> -			         /* Actual receive needs to be a multiple
> -			          * of 4 bytes
> -			          */
> -			         (len + 3) & ~3,
> -			         msg_context,
> -			         VCHIQ_BULK_MODE_CALLBACK);
> +				msg_context->u.bulk.buffer->buffer,
> +				/* Actual receive needs to be a multiple
> +				 * of 4 bytes
> +				 */
> +				(len + 3) & ~3,
> +				msg_context,
> +				VCHIQ_BULK_MODE_CALLBACK);

Close, you need one more space for these lines, right?

thanks,

greg k-h
Dan Carpenter July 13, 2020, 1:38 p.m. UTC | #2
On Mon, Jul 13, 2020 at 03:35:27PM +0200, Greg Kroah-Hartman wrote:
> On Mon, Jul 13, 2020 at 12:52:24PM +0530, Baidyanath Kundu wrote:
> > This patch fixes the checkpatch.pl error:
> > 
> > ERROR: code indent should use tabs where possible
> > 
> > Signed-off-by: Baidyanath Kundu <kundubaidya99@gmail.com>
> > ---
> >  .../staging/vc04_services/vchiq-mmal/mmal-vchiq.c  | 14 +++++++-------
> >  1 file changed, 7 insertions(+), 7 deletions(-)
> > 
> > diff --git a/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c b/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c
> > index a075cd63da7f..86c00b68f099 100644
> > --- a/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c
> > +++ b/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c
> > @@ -294,13 +294,13 @@ static void buffer_to_host_work_cb(struct work_struct *work)
> >  	/* queue the bulk submission */
> >  	vchiq_use_service(instance->service_handle);
> >  	ret = vchiq_bulk_receive(instance->service_handle,
> > -				 msg_context->u.bulk.buffer->buffer,
> > -			         /* Actual receive needs to be a multiple
> > -			          * of 4 bytes
> > -			          */
> > -			         (len + 3) & ~3,
> > -			         msg_context,
> > -			         VCHIQ_BULK_MODE_CALLBACK);
> > +				msg_context->u.bulk.buffer->buffer,
> > +				/* Actual receive needs to be a multiple
> > +				 * of 4 bytes
> > +				 */
> > +				(len + 3) & ~3,
> > +				msg_context,
> > +				VCHIQ_BULK_MODE_CALLBACK);
> 
> Close, you need one more space for these lines, right?
> 

Yeah.  The original has the space and looks correct.

regards,
dan carpenter

Patch
diff mbox series

diff --git a/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c b/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c
index a075cd63da7f..86c00b68f099 100644
--- a/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c
+++ b/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c
@@ -294,13 +294,13 @@  static void buffer_to_host_work_cb(struct work_struct *work)
 	/* queue the bulk submission */
 	vchiq_use_service(instance->service_handle);
 	ret = vchiq_bulk_receive(instance->service_handle,
-				 msg_context->u.bulk.buffer->buffer,
-			         /* Actual receive needs to be a multiple
-			          * of 4 bytes
-			          */
-			         (len + 3) & ~3,
-			         msg_context,
-			         VCHIQ_BULK_MODE_CALLBACK);
+				msg_context->u.bulk.buffer->buffer,
+				/* Actual receive needs to be a multiple
+				 * of 4 bytes
+				 */
+				(len + 3) & ~3,
+				msg_context,
+				VCHIQ_BULK_MODE_CALLBACK);
 
 	vchiq_release_service(instance->service_handle);