From patchwork Mon Jul 13 14:36:53 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Baidyanath Kundu X-Patchwork-Id: 11659937 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id A70CC722 for ; Mon, 13 Jul 2020 14:38:54 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7E90820738 for ; Mon, 13 Jul 2020 14:38:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="WfzfHbhg"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="BXkjoQfx" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7E90820738 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:MIME-Version:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Owner; bh=54vlDK9p4OuGud8DNIdMePHp0f5qaTC28BwrL2xGynY=; b=WfzfHbhgcmL5Ozwpt8H/BLzRr8 9dUiIXtVO8gO2Mjo+aVJ8mZIKuk4lDlIj5ciS4JOD8Bhf0xcgHQXQDqugingIWcyeedSV5DnZP7YC 9bWTY5ahnUy0rA6RCtJ1a3RkYCdojUKpjNHiETdfZoym/NaIkTqjGAGblUzvPZjsAktwc1MCq/IOk EC+Z1vDf8NY2q/27QykOGKkl/wXiPD/Udvdx07Lxikud4o4vaEY45eby1vxNbLv6ctS9imdxfKOCa s7Om777NJlV5F0fD9uPpByr9BqIKWMG48DuANrx+IQsgHtOR0B4BvG7H+QfdUFsQaPHtJp+a088Ae /fal/nnA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1juza5-0004Ak-9K; Mon, 13 Jul 2020 14:37:21 +0000 Received: from mail-pj1-x1041.google.com ([2607:f8b0:4864:20::1041]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1juza1-00049u-OD; Mon, 13 Jul 2020 14:37:18 +0000 Received: by mail-pj1-x1041.google.com with SMTP id md7so6355265pjb.1; Mon, 13 Jul 2020 07:37:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=6h4nc4PcIrIUv15+ByYYiTsFlJJxjA7wtMBBwHQX5v0=; b=BXkjoQfx48H2e6nBUni5xxwkx5mRQrvIrPnoDE+R8Qva8vJwI+BS0BPVCEmsH2q+yr I461L736DFMAP+3S4jPi5ynyR4LyBhETmOpXzWTiiqyk4YmxNBwsq0WEd7oO3+VhErRV KgrrHOYFYzLdSRBB2j/v9xLwH3OW5YWoNyrbPKjI29gNCrTPxpsUaYZwSPPZ0Z8pq02M YjiCkTmMqXlm5j4kXJARs4goGChtn3lzj25n4TcqDtII8yUu78H+SZnMSq68BFAFOBon mlZfie0wJtmVDmzqmRxXeiCsHE5S5v1g9drYRQGuj6IdyRPTxwrIzGsxDYLqZJ+yxZWU tFvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=6h4nc4PcIrIUv15+ByYYiTsFlJJxjA7wtMBBwHQX5v0=; b=D3jV+Vw9x0ul0UQDQHqEp3kKuGQbhfSP+9HwdVLLsQF5RENxBgCevmb8t41rVEyOzW 1U4rkaeZi0fqPak05qWIpji/PB7C2uQfr7nwZDexuIeWVj9nbMXPsDAyEf8t6DiSIgLX p3PgRlPcIz5IJfdOhPzMXkmExDeYLZCiWM6Y2dMWX1NY4hrsSxESpWyqPU+tUR+iPL6+ 8e0vbLZch34vEAqtLWDA8nLERM6xinoWepF/fDF1CzCgyFvkoXYY887xauHR7FotyRIG i3S2AkcJ61mLDEwH6kCiGw6M4Flsl11wb1J32ZYms6qn9mxvefBTi0l/C3U88hFmI05F NanA== X-Gm-Message-State: AOAM531xhUUyICATCa7oU+qPpIuFNzn/0SU89TQ9LXXY5XzVy/J2TTyr aZtB8TpKNkfg1XZVHmazoCU= X-Google-Smtp-Source: ABdhPJxlYOPflhEqsOIGOMz/15FQEGURw1GaUxETKRiOmGKPsMhrDUr8X9XyvRWLjRPkZMdC/uXvvQ== X-Received: by 2002:a17:902:b113:: with SMTP id q19mr1388plr.170.1594651035151; Mon, 13 Jul 2020 07:37:15 -0700 (PDT) Received: from localhost.localdomain ([103.88.59.5]) by smtp.googlemail.com with ESMTPSA id b13sm15094820pjl.7.2020.07.13.07.37.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Jul 2020 07:37:14 -0700 (PDT) From: Baidyanath Kundu To: Greg Kroah-Hartman , Nicolas Saenz Julienne , Florian Fainelli , Ray Jui , Scott Branden Subject: [PATCH] Staging: vc04_services: Fix unsigned int warnings Date: Mon, 13 Jul 2020 20:06:53 +0530 Message-Id: <20200713143653.32332-1-kundubaidya99@gmail.com> X-Mailer: git-send-email 2.17.1 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200713_103717_825302_4A3B6893 X-CRM114-Status: GOOD ( 14.63 ) X-Spam-Score: 0.1 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (0.1 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2607:f8b0:4864:20:0:0:0:1041 listed in] [list.dnswl.org] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider [kundubaidya99[at]gmail.com] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.2 FREEMAIL_ENVFROM_END_DIGIT Envelope-from freemail username ends in digit [kundubaidya99[at]gmail.com] -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devel@driverdev.osuosl.org, Baidyanath Kundu , linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org This patch fixes the checkpatch.pl warning: WARNING: Prefer 'unsigned int' to bare use of 'unsigned' Signed-off-by: Baidyanath Kundu --- .../staging/vc04_services/bcm2835-audio/bcm2835-vchiq.c | 4 ++-- .../vc04_services/include/linux/raspberrypi/vchiq.h | 8 ++++---- .../vc04_services/interface/vchiq_arm/vchiq_core.c | 6 +++--- drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c | 4 ++-- 4 files changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/staging/vc04_services/bcm2835-audio/bcm2835-vchiq.c b/drivers/staging/vc04_services/bcm2835-audio/bcm2835-vchiq.c index 8c9ddd86fbbd..292fcee9d6f2 100644 --- a/drivers/staging/vc04_services/bcm2835-audio/bcm2835-vchiq.c +++ b/drivers/staging/vc04_services/bcm2835-audio/bcm2835-vchiq.c @@ -9,7 +9,7 @@ struct bcm2835_audio_instance { struct device *dev; - unsigned service_handle; + unsigned int service_handle; struct completion msg_avail_comp; struct mutex vchi_mutex; struct bcm2835_alsa_stream *alsa_stream; @@ -91,7 +91,7 @@ static int bcm2835_audio_send_simple(struct bcm2835_audio_instance *instance, static enum vchiq_status audio_vchi_callback(enum vchiq_reason reason, struct vchiq_header *header, - unsigned handle, void *userdata) + unsigned int handle, void *userdata) { struct bcm2835_audio_instance *instance = vchiq_get_service_userdata(handle); struct vc_audio_msg *m; diff --git a/drivers/staging/vc04_services/include/linux/raspberrypi/vchiq.h b/drivers/staging/vc04_services/include/linux/raspberrypi/vchiq.h index cb9ef9a4150b..18d63df368c4 100644 --- a/drivers/staging/vc04_services/include/linux/raspberrypi/vchiq.h +++ b/drivers/staging/vc04_services/include/linux/raspberrypi/vchiq.h @@ -84,11 +84,11 @@ extern enum vchiq_status vchiq_open_service(struct vchiq_instance *instance, extern enum vchiq_status vchiq_close_service(unsigned int service); extern enum vchiq_status vchiq_use_service(unsigned int service); extern enum vchiq_status vchiq_release_service(unsigned int service); -extern void vchiq_msg_queue_push(unsigned handle, struct vchiq_header *header); +extern void vchiq_msg_queue_push(unsigned int handle, struct vchiq_header *header); extern void vchiq_release_message(unsigned int service, struct vchiq_header *header); -extern int vchiq_queue_kernel_message(unsigned handle, void *data, - unsigned size); +extern int vchiq_queue_kernel_message(unsigned int handle, void *data, + unsigned int size); extern enum vchiq_status vchiq_bulk_transmit(unsigned int service, const void *data, unsigned int size, void *userdata, enum vchiq_bulk_mode mode); @@ -98,6 +98,6 @@ extern enum vchiq_status vchiq_bulk_receive(unsigned int service, extern void *vchiq_get_service_userdata(unsigned int service); extern enum vchiq_status vchiq_get_peer_version(unsigned int handle, short *peer_version); -extern struct vchiq_header *vchiq_msg_hold(unsigned handle); +extern struct vchiq_header *vchiq_msg_hold(unsigned int handle); #endif /* VCHIQ_H */ diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c index 1bc4ce577614..af64cde82d36 100644 --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c @@ -2275,7 +2275,7 @@ vchiq_init_state(struct vchiq_state *state, struct vchiq_slot_zero *slot_zero) return VCHIQ_ERROR; } -void vchiq_msg_queue_push(unsigned handle, struct vchiq_header *header) +void vchiq_msg_queue_push(unsigned int handle, struct vchiq_header *header) { struct vchiq_service *service = find_service_by_handle(handle); int pos; @@ -2293,7 +2293,7 @@ void vchiq_msg_queue_push(unsigned handle, struct vchiq_header *header) } EXPORT_SYMBOL(vchiq_msg_queue_push); -struct vchiq_header *vchiq_msg_hold(unsigned handle) +struct vchiq_header *vchiq_msg_hold(unsigned int handle) { struct vchiq_service *service = find_service_by_handle(handle); struct vchiq_header *header; @@ -3214,7 +3214,7 @@ vchiq_queue_message(unsigned int handle, return status; } -int vchiq_queue_kernel_message(unsigned handle, void *data, unsigned size) +int vchiq_queue_kernel_message(unsigned int handle, void *data, unsigned int size) { enum vchiq_status status; diff --git a/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c b/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c index a075cd63da7f..dc767730db43 100644 --- a/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c +++ b/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c @@ -163,7 +163,7 @@ struct mmal_msg_context { }; struct vchiq_mmal_instance { - unsigned service_handle; + unsigned int service_handle; /* ensure serialised access to service */ struct mutex vchiq_mutex; @@ -548,7 +548,7 @@ static void bulk_abort_cb(struct vchiq_mmal_instance *instance, /* incoming event service callback */ static enum vchiq_status service_callback(enum vchiq_reason reason, struct vchiq_header *header, - unsigned handle, void *bulk_ctx) + unsigned int handle, void *bulk_ctx) { struct vchiq_mmal_instance *instance = vchiq_get_service_userdata(handle); u32 msg_len;