| Message ID | 1594674941-32092-1-git-send-email-loberman@redhat.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | iscsi: qedi (qed_int.c) disable "MFW indication via attention" SPAM every 5 minutes | expand |
From: Laurence Oberman <loberman@redhat.com> Date: Mon, 13 Jul 2020 17:15:41 -0400 > This is likely firmware causing this but its starting to annoy customers. > Change the message level to verbose to prevent the spam. > > Signed-off-by: Laurence Oberman <loberman@redhat.com> "iscsi:" doesn't belong in this Subject line. Please look at recent changes to this driver and what commit header line subsystem prefixes and layout is being used. Thanks.
On Mon, 2020-07-13 at 17:58 -0700, David Miller wrote: > From: Laurence Oberman <loberman@redhat.com> > Date: Mon, 13 Jul 2020 17:15:41 -0400 > > > This is likely firmware causing this but its starting to annoy > customers. > > Change the message level to verbose to prevent the spam. > > > > Signed-off-by: Laurence Oberman <loberman@redhat.com> > > "iscsi:" doesn't belong in this Subject line. > > Please look at recent changes to this driver and what commit header > line subsystem prefixes and layout is being used. > > Thanks. > Hi Dave, I will resend. The challenge is that while the proposed fix is in qed_int.c it only manifests when the ISCSI persinality is enabled on the card. I will set as appropriate header but mention the qedi ISCSI connection in the V2 of this patch. Thanks Laurence
diff --git a/drivers/net/ethernet/qlogic/qed/qed_int.c b/drivers/net/ethernet/qlogic/qed/qed_int.c index b7b974f..d853eb9 100644 --- a/drivers/net/ethernet/qlogic/qed/qed_int.c +++ b/drivers/net/ethernet/qlogic/qed/qed_int.c @@ -1193,7 +1193,8 @@ static int qed_int_attentions(struct qed_hwfn *p_hwfn) index, attn_bits, attn_acks, asserted_bits, deasserted_bits, p_sb_attn_sw->known_attn); } else if (asserted_bits == 0x100) { - DP_INFO(p_hwfn, "MFW indication via attention\n"); + DP_VERBOSE(p_hwfn, NETIF_MSG_INTR, + "MFW indication via attention\n"); } else { DP_VERBOSE(p_hwfn, NETIF_MSG_INTR, "MFW indication [deassertion]\n");
This is likely firmware causing this but its starting to annoy customers. Change the message level to verbose to prevent the spam. Signed-off-by: Laurence Oberman <loberman@redhat.com> --- drivers/net/ethernet/qlogic/qed/qed_int.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)