| Message ID | 20200714090644.13011-2-chris.packham@alliedtelesis.co.nz (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/2] doc: filesystems: proc: Remove stray '-' preventing table output | expand |
On Tue, Jul 14, 2020 at 09:06:44PM +1200, Chris Packham wrote: > Sphinx complains > > Documentation/filesystems/proc.rst:2194: WARNING: Inconsistent literal block quoting. > > Update the command line snippets to be properly formed literal blocks. > > Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz> Acked-by: Mike Rapoport <rppt@linux.ibm.com> > --- > Documentation/filesystems/proc.rst | 38 +++++++++++++++++------------- > 1 file changed, 21 insertions(+), 17 deletions(-) > > diff --git a/Documentation/filesystems/proc.rst b/Documentation/filesystems/proc.rst > index 53a0230a08e2..6027dc94755f 100644 > --- a/Documentation/filesystems/proc.rst > +++ b/Documentation/filesystems/proc.rst > @@ -2190,25 +2190,27 @@ mountpoints within the same namespace. > > :: > > -# grep ^proc /proc/mounts > -proc /proc proc rw,relatime,hidepid=2 0 0 > + # grep ^proc /proc/mounts > + proc /proc proc rw,relatime,hidepid=2 0 0 > > -# strace -e mount mount -o hidepid=1 -t proc proc /tmp/proc > -mount("proc", "/tmp/proc", "proc", 0, "hidepid=1") = 0 > -+++ exited with 0 +++ > + # strace -e mount mount -o hidepid=1 -t proc proc /tmp/proc > + mount("proc", "/tmp/proc", "proc", 0, "hidepid=1") = 0 > + +++ exited with 0 +++ > > -# grep ^proc /proc/mounts > -proc /proc proc rw,relatime,hidepid=2 0 0 > -proc /tmp/proc proc rw,relatime,hidepid=2 0 0 > + # grep ^proc /proc/mounts > + proc /proc proc rw,relatime,hidepid=2 0 0 > + proc /tmp/proc proc rw,relatime,hidepid=2 0 0 > > and only after remounting procfs mount options will change at all > mountpoints. > > -# mount -o remount,hidepid=1 -t proc proc /tmp/proc > +:: > + > + # mount -o remount,hidepid=1 -t proc proc /tmp/proc > > -# grep ^proc /proc/mounts > -proc /proc proc rw,relatime,hidepid=1 0 0 > -proc /tmp/proc proc rw,relatime,hidepid=1 0 0 > + # grep ^proc /proc/mounts > + proc /proc proc rw,relatime,hidepid=1 0 0 > + proc /tmp/proc proc rw,relatime,hidepid=1 0 0 > > This behavior is different from the behavior of other filesystems. > > @@ -2217,8 +2219,10 @@ creates a new procfs instance. Mount options affect own procfs instance. > It means that it became possible to have several procfs instances > displaying tasks with different filtering options in one pid namespace. > > -# mount -o hidepid=invisible -t proc proc /proc > -# mount -o hidepid=noaccess -t proc proc /tmp/proc > -# grep ^proc /proc/mounts > -proc /proc proc rw,relatime,hidepid=invisible 0 0 > -proc /tmp/proc proc rw,relatime,hidepid=noaccess 0 0 > +:: > + > + # mount -o hidepid=invisible -t proc proc /proc > + # mount -o hidepid=noaccess -t proc proc /tmp/proc > + # grep ^proc /proc/mounts > + proc /proc proc rw,relatime,hidepid=invisible 0 0 > + proc /tmp/proc proc rw,relatime,hidepid=noaccess 0 0 > -- > 2.27.0 >
Hi Jon, On 14/07/20 9:06 pm, Chris Packham wrote: > Sphinx complains > > Documentation/filesystems/proc.rst:2194: WARNING: Inconsistent literal block quoting. > > Update the command line snippets to be properly formed literal blocks. > > Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz> > --- > Documentation/filesystems/proc.rst | 38 +++++++++++++++++------------- > 1 file changed, 21 insertions(+), 17 deletions(-) > > diff --git a/Documentation/filesystems/proc.rst b/Documentation/filesystems/proc.rst > index 53a0230a08e2..6027dc94755f 100644 > --- a/Documentation/filesystems/proc.rst > +++ b/Documentation/filesystems/proc.rst > @@ -2190,25 +2190,27 @@ mountpoints within the same namespace. > > :: > > -# grep ^proc /proc/mounts > -proc /proc proc rw,relatime,hidepid=2 0 0 > + # grep ^proc /proc/mounts > + proc /proc proc rw,relatime,hidepid=2 0 0 > > -# strace -e mount mount -o hidepid=1 -t proc proc /tmp/proc > -mount("proc", "/tmp/proc", "proc", 0, "hidepid=1") = 0 > -+++ exited with 0 +++ > + # strace -e mount mount -o hidepid=1 -t proc proc /tmp/proc > + mount("proc", "/tmp/proc", "proc", 0, "hidepid=1") = 0 > + +++ exited with 0 +++ > > -# grep ^proc /proc/mounts > -proc /proc proc rw,relatime,hidepid=2 0 0 > -proc /tmp/proc proc rw,relatime,hidepid=2 0 0 > + # grep ^proc /proc/mounts > + proc /proc proc rw,relatime,hidepid=2 0 0 > + proc /tmp/proc proc rw,relatime,hidepid=2 0 0 > > and only after remounting procfs mount options will change at all > mountpoints. > > -# mount -o remount,hidepid=1 -t proc proc /tmp/proc > +:: > + > + # mount -o remount,hidepid=1 -t proc proc /tmp/proc > > -# grep ^proc /proc/mounts > -proc /proc proc rw,relatime,hidepid=1 0 0 > -proc /tmp/proc proc rw,relatime,hidepid=1 0 0 > + # grep ^proc /proc/mounts > + proc /proc proc rw,relatime,hidepid=1 0 0 > + proc /tmp/proc proc rw,relatime,hidepid=1 0 0 > > This behavior is different from the behavior of other filesystems. > > @@ -2217,8 +2219,10 @@ creates a new procfs instance. Mount options affect own procfs instance. > It means that it became possible to have several procfs instances > displaying tasks with different filtering options in one pid namespace. > > -# mount -o hidepid=invisible -t proc proc /proc > -# mount -o hidepid=noaccess -t proc proc /tmp/proc > -# grep ^proc /proc/mounts > -proc /proc proc rw,relatime,hidepid=invisible 0 0 > -proc /tmp/proc proc rw,relatime,hidepid=noaccess 0 0 > +:: > + > + # mount -o hidepid=invisible -t proc proc /proc > + # mount -o hidepid=noaccess -t proc proc /tmp/proc > + # grep ^proc /proc/mounts > + proc /proc proc rw,relatime,hidepid=invisible 0 0 > + proc /tmp/proc proc rw,relatime,hidepid=noaccess 0 0 Looks like Mauro also fixed this so this can be dropped too.
diff --git a/Documentation/filesystems/proc.rst b/Documentation/filesystems/proc.rst index 53a0230a08e2..6027dc94755f 100644 --- a/Documentation/filesystems/proc.rst +++ b/Documentation/filesystems/proc.rst @@ -2190,25 +2190,27 @@ mountpoints within the same namespace. :: -# grep ^proc /proc/mounts -proc /proc proc rw,relatime,hidepid=2 0 0 + # grep ^proc /proc/mounts + proc /proc proc rw,relatime,hidepid=2 0 0 -# strace -e mount mount -o hidepid=1 -t proc proc /tmp/proc -mount("proc", "/tmp/proc", "proc", 0, "hidepid=1") = 0 -+++ exited with 0 +++ + # strace -e mount mount -o hidepid=1 -t proc proc /tmp/proc + mount("proc", "/tmp/proc", "proc", 0, "hidepid=1") = 0 + +++ exited with 0 +++ -# grep ^proc /proc/mounts -proc /proc proc rw,relatime,hidepid=2 0 0 -proc /tmp/proc proc rw,relatime,hidepid=2 0 0 + # grep ^proc /proc/mounts + proc /proc proc rw,relatime,hidepid=2 0 0 + proc /tmp/proc proc rw,relatime,hidepid=2 0 0 and only after remounting procfs mount options will change at all mountpoints. -# mount -o remount,hidepid=1 -t proc proc /tmp/proc +:: + + # mount -o remount,hidepid=1 -t proc proc /tmp/proc -# grep ^proc /proc/mounts -proc /proc proc rw,relatime,hidepid=1 0 0 -proc /tmp/proc proc rw,relatime,hidepid=1 0 0 + # grep ^proc /proc/mounts + proc /proc proc rw,relatime,hidepid=1 0 0 + proc /tmp/proc proc rw,relatime,hidepid=1 0 0 This behavior is different from the behavior of other filesystems. @@ -2217,8 +2219,10 @@ creates a new procfs instance. Mount options affect own procfs instance. It means that it became possible to have several procfs instances displaying tasks with different filtering options in one pid namespace. -# mount -o hidepid=invisible -t proc proc /proc -# mount -o hidepid=noaccess -t proc proc /tmp/proc -# grep ^proc /proc/mounts -proc /proc proc rw,relatime,hidepid=invisible 0 0 -proc /tmp/proc proc rw,relatime,hidepid=noaccess 0 0 +:: + + # mount -o hidepid=invisible -t proc proc /proc + # mount -o hidepid=noaccess -t proc proc /tmp/proc + # grep ^proc /proc/mounts + proc /proc proc rw,relatime,hidepid=invisible 0 0 + proc /tmp/proc proc rw,relatime,hidepid=noaccess 0 0
Sphinx complains Documentation/filesystems/proc.rst:2194: WARNING: Inconsistent literal block quoting. Update the command line snippets to be properly formed literal blocks. Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz> --- Documentation/filesystems/proc.rst | 38 +++++++++++++++++------------- 1 file changed, 21 insertions(+), 17 deletions(-)