| Message ID | 20200714160627.1269-1-sean@poorly.run (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/i915: Avoid modeset when content protection changes | expand |
On 2020-07-14 at 21:36:27 +0530, Sean Paul wrote: > From: Sean Paul <seanpaul@chromium.org> > > Instead of doing a full modeset to enable/disable content protection, > simply go through the update_pipe flow which was introduced in the > related patch below. This avoids flashing the screen every time the user > starts viewing protected content. > > Related: 634852d1f468 ("drm/i915: HDCP state handling in ddi_update_pipe") > Cc: Ramalingam C <ramalingam.c@intel.com> > Cc: Daniel Vetter <daniel.vetter@ffwll.ch> > Cc: Jani Nikula <jani.nikula@linux.intel.com> > Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com> > Cc: Rodrigo Vivi <rodrigo.vivi@intel.com> > Cc: intel-gfx@lists.freedesktop.org > Signed-off-by: Sean Paul <seanpaul@chromium.org> > --- > drivers/gpu/drm/i915/display/intel_hdcp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_hdcp.c b/drivers/gpu/drm/i915/display/intel_hdcp.c > index 89a4d294822d..839ce1715253 100644 > --- a/drivers/gpu/drm/i915/display/intel_hdcp.c > +++ b/drivers/gpu/drm/i915/display/intel_hdcp.c > @@ -2191,7 +2191,7 @@ void intel_hdcp_atomic_check(struct drm_connector *connector, > return; > } > > - crtc_state->mode_changed = true; > + to_intel_crtc_state(crtc_state)->update_pipe = true; IMHO intel_crtc_check_fastset() make sure that every crtc_state->mode_changed will not turn up to a modeset. It seems it is already being taken care. Thanks, Anshuman Gupta. > } > > /* Handles the CP_IRQ raised from the DP HDCP sink */ > -- > Sean Paul, Software Engineer, Google / Chromium OS > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
diff --git a/drivers/gpu/drm/i915/display/intel_hdcp.c b/drivers/gpu/drm/i915/display/intel_hdcp.c index 89a4d294822d..839ce1715253 100644 --- a/drivers/gpu/drm/i915/display/intel_hdcp.c +++ b/drivers/gpu/drm/i915/display/intel_hdcp.c @@ -2191,7 +2191,7 @@ void intel_hdcp_atomic_check(struct drm_connector *connector, return; } - crtc_state->mode_changed = true; + to_intel_crtc_state(crtc_state)->update_pipe = true; } /* Handles the CP_IRQ raised from the DP HDCP sink */