[10/10] ALSA: usb-audio: Replace blacklist word
diff mbox series

Message ID 20200714172631.25371-11-tiwai@suse.de
State New
Headers show
Series
  • ALSA: Replace words for inclusive terminalogy guideline
Related show

Commit Message

Takashi Iwai July 14, 2020, 5:26 p.m. UTC
Follow the recent inclusive terminology guidelines and replace the
word "blacklist" appropriately.

Only a comment fix, no functional changes.

Signed-off-by: Takashi Iwai <tiwai@suse.de>
---
 sound/usb/quirks-table.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Alexander Tsoy July 15, 2020, 5:04 p.m. UTC | #1
В Вт, 14/07/2020 в 19:26 +0200, Takashi Iwai пишет:
> Follow the recent inclusive terminology guidelines and replace the
> word "blacklist" appropriately.
> 
> Only a comment fix, no functional changes.
> 
> Signed-off-by: Takashi Iwai <tiwai@suse.de>
> ---
>  sound/usb/quirks-table.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/usb/quirks-table.h b/sound/usb/quirks-table.h
> index 4ec491011b19..336d81bb5fd1 100644
> --- a/sound/usb/quirks-table.h
> +++ b/sound/usb/quirks-table.h
> @@ -127,7 +127,7 @@
>  /*
>   * HP Wireless Audio
>   * When not ignored, causes instability issues for some users,
> forcing them to
> - * blacklist the entire module.
> + * skip the entire module.

Maybe something like "disable loading" is more appropriate here?
"blacklist" here means literally "blacklist" option in modprobe.d
or modprobe.blacklist= cmdline option.

>   */
>  {
>  	USB_DEVICE(0x0424, 0xb832),
Takashi Iwai July 15, 2020, 5:20 p.m. UTC | #2
On Wed, 15 Jul 2020 19:04:37 +0200,
Alexander Tsoy wrote:
> 
> В Вт, 14/07/2020 в 19:26 +0200, Takashi Iwai пишет:
> > Follow the recent inclusive terminology guidelines and replace the
> > word "blacklist" appropriately.
> > 
> > Only a comment fix, no functional changes.
> > 
> > Signed-off-by: Takashi Iwai <tiwai@suse.de>
> > ---
> >  sound/usb/quirks-table.h | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/sound/usb/quirks-table.h b/sound/usb/quirks-table.h
> > index 4ec491011b19..336d81bb5fd1 100644
> > --- a/sound/usb/quirks-table.h
> > +++ b/sound/usb/quirks-table.h
> > @@ -127,7 +127,7 @@
> >  /*
> >   * HP Wireless Audio
> >   * When not ignored, causes instability issues for some users,
> > forcing them to
> > - * blacklist the entire module.
> > + * skip the entire module.
> 
> Maybe something like "disable loading" is more appropriate here?
> "blacklist" here means literally "blacklist" option in modprobe.d
> or modprobe.blacklist= cmdline option.

Well, in the end the behavior is same: the driver skips the probe and
quits.  I don't mind much about the choice of the words, but IMO the
difference here is too subtle to discuss.


thanks,

Takashi

Patch
diff mbox series

diff --git a/sound/usb/quirks-table.h b/sound/usb/quirks-table.h
index 4ec491011b19..336d81bb5fd1 100644
--- a/sound/usb/quirks-table.h
+++ b/sound/usb/quirks-table.h
@@ -127,7 +127,7 @@ 
 /*
  * HP Wireless Audio
  * When not ignored, causes instability issues for some users, forcing them to
- * blacklist the entire module.
+ * skip the entire module.
  */
 {
 	USB_DEVICE(0x0424, 0xb832),