| Message ID | 20200715160209.652-2-linux.amoon@gmail.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Enable RTC on Odroid N2 | expand |
Hi, On 15/07/2020 18:02, Anand Moon wrote: > Enable RTC PCF8563 node on Odroid-N2 SBC, In order > to support the RTC wakealarm feature for suspend and resume. > > Cc: Neil Armstrong <narmstrong@baylibre.com> > Cc: Kevin Hilman <khilman@baylibre.com> > Signed-off-by: Anand Moon <linux.amoon@gmail.com> > --- > $ sudo hwclock -r && date > 2020-07-15 13:11:53.862508+00:00 > Wed Jul 15 13:11:54 UTC 2020 > > $ hwclock --show > 2020-07-15 13:17:30.903300+00:00 > > But RTC wake up is not working at my end. > Any inputs are welcome. > > $ time rtcwake -s 30 -m mem > rtcwake: /dev/rtc0 not enabled for wakeup events > > real 0m0.002s > user 0m0.002s > sys 0m0.000s > --- > .../boot/dts/amlogic/meson-g12b-odroid-n2.dts | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > > diff --git a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts > index 169ea283d4ee..a447cba4dd53 100644 > --- a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts > +++ b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts > @@ -391,6 +391,20 @@ hdmi_tx_tmds_out: endpoint { > }; > }; > > +&i2c3 { > + pinctrl-0 = <&i2c3_sda_a_pins>, <&i2c3_sck_a_pins>; > + pinctrl-names = "default"; > + status = "okay"; > + > + rtc: rtc@51 { > + reg = <0x51>; > + compatible = "nxp,pcf8563"; > + #clock-cells = <0>; > + clock-frequency = <32768>; > + clock-output-names = "rtc_clkout"; The clkout output is not used, so I don't think these 3 lines are needed. > + }; > +}; > + > &ir { > status = "okay"; > pinctrl-0 = <&remote_input_ao_pins>; > Neil
Hi Neil, Thanks for your review comments. On Thu, 16 Jul 2020 at 12:38, Neil Armstrong <narmstrong@baylibre.com> wrote: > > Hi, > > On 15/07/2020 18:02, Anand Moon wrote: > > Enable RTC PCF8563 node on Odroid-N2 SBC, In order > > to support the RTC wakealarm feature for suspend and resume. > > > > Cc: Neil Armstrong <narmstrong@baylibre.com> > > Cc: Kevin Hilman <khilman@baylibre.com> > > Signed-off-by: Anand Moon <linux.amoon@gmail.com> > > --- > > $ sudo hwclock -r && date > > 2020-07-15 13:11:53.862508+00:00 > > Wed Jul 15 13:11:54 UTC 2020 > > > > $ hwclock --show > > 2020-07-15 13:17:30.903300+00:00 > > > > But RTC wake up is not working at my end. > > Any inputs are welcome. > > > > $ time rtcwake -s 30 -m mem > > rtcwake: /dev/rtc0 not enabled for wakeup events > > > > real 0m0.002s > > user 0m0.002s > > sys 0m0.000s > > --- > > .../boot/dts/amlogic/meson-g12b-odroid-n2.dts | 14 ++++++++++++++ > > 1 file changed, 14 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts > > index 169ea283d4ee..a447cba4dd53 100644 > > --- a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts > > +++ b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts > > @@ -391,6 +391,20 @@ hdmi_tx_tmds_out: endpoint { > > }; > > }; > > > > +&i2c3 { > > + pinctrl-0 = <&i2c3_sda_a_pins>, <&i2c3_sck_a_pins>; > > + pinctrl-names = "default"; > > + status = "okay"; > > + > > + rtc: rtc@51 { > > + reg = <0x51>; > > + compatible = "nxp,pcf8563"; > > + #clock-cells = <0>; > > + clock-frequency = <32768>; > > + clock-output-names = "rtc_clkout"; > > The clkout output is not used, so I don't think these 3 lines are needed. Ok Thanks I will drop these 3 clock lines. > > > + }; > > +}; > > + > > &ir { > > status = "okay"; > > pinctrl-0 = <&remote_input_ao_pins>; > > > > Neil -Anand
On Wed 15 Jul 2020 at 18:02, Anand Moon <linux.amoon@gmail.com> wrote: > Enable RTC PCF8563 node on Odroid-N2 SBC, In order > to support the RTC wakealarm feature for suspend and resume. > > Cc: Neil Armstrong <narmstrong@baylibre.com> > Cc: Kevin Hilman <khilman@baylibre.com> > Signed-off-by: Anand Moon <linux.amoon@gmail.com> > --- > $ sudo hwclock -r && date > 2020-07-15 13:11:53.862508+00:00 > Wed Jul 15 13:11:54 UTC 2020 > > $ hwclock --show > 2020-07-15 13:17:30.903300+00:00 > > But RTC wake up is not working at my end. > Any inputs are welcome. > > $ time rtcwake -s 30 -m mem > rtcwake: /dev/rtc0 not enabled for wakeup events > > real 0m0.002s > user 0m0.002s > sys 0m0.000s > --- > .../boot/dts/amlogic/meson-g12b-odroid-n2.dts | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > > diff --git a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts > index 169ea283d4ee..a447cba4dd53 100644 > --- a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts > +++ b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts > @@ -391,6 +391,20 @@ hdmi_tx_tmds_out: endpoint { > }; > }; > > +&i2c3 { > + pinctrl-0 = <&i2c3_sda_a_pins>, <&i2c3_sck_a_pins>; > + pinctrl-names = "default"; > + status = "okay"; > + > + rtc: rtc@51 { > + reg = <0x51>; > + compatible = "nxp,pcf8563"; > + #clock-cells = <0>; > + clock-frequency = <32768>; > + clock-output-names = "rtc_clkout"; > + }; This rtc being on a connector, optional and not fitted by default, should it really be enabled for all odroid-n2 ? We tend not do that usually > +}; > + > &ir { > status = "okay"; > pinctrl-0 = <&remote_input_ao_pins>;
Hi Jerome, Thanks for your review comments. On Thu, 16 Jul 2020 at 13:38, Jerome Brunet <jbrunet@baylibre.com> wrote: > > > On Wed 15 Jul 2020 at 18:02, Anand Moon <linux.amoon@gmail.com> wrote: > > > Enable RTC PCF8563 node on Odroid-N2 SBC, In order > > to support the RTC wakealarm feature for suspend and resume. > > > > Cc: Neil Armstrong <narmstrong@baylibre.com> > > Cc: Kevin Hilman <khilman@baylibre.com> > > Signed-off-by: Anand Moon <linux.amoon@gmail.com> > > --- > > $ sudo hwclock -r && date > > 2020-07-15 13:11:53.862508+00:00 > > Wed Jul 15 13:11:54 UTC 2020 > > > > $ hwclock --show > > 2020-07-15 13:17:30.903300+00:00 > > > > But RTC wake up is not working at my end. > > Any inputs are welcome. > > > > $ time rtcwake -s 30 -m mem > > rtcwake: /dev/rtc0 not enabled for wakeup events > > > > real 0m0.002s > > user 0m0.002s > > sys 0m0.000s > > --- > > .../boot/dts/amlogic/meson-g12b-odroid-n2.dts | 14 ++++++++++++++ > > 1 file changed, 14 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts > > index 169ea283d4ee..a447cba4dd53 100644 > > --- a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts > > +++ b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts > > @@ -391,6 +391,20 @@ hdmi_tx_tmds_out: endpoint { > > }; > > }; > > > > +&i2c3 { > > + pinctrl-0 = <&i2c3_sda_a_pins>, <&i2c3_sck_a_pins>; > > + pinctrl-names = "default"; > > + status = "okay"; > > + > > + rtc: rtc@51 { > > + reg = <0x51>; > > + compatible = "nxp,pcf8563"; > > + #clock-cells = <0>; > > + clock-frequency = <32768>; > > + clock-output-names = "rtc_clkout"; > > + }; > > This rtc being on a connector, optional and not fitted by default, > should it really be enabled for all odroid-n2 ? > > We tend not do that usually My thought process was there will be an Internal primary interrupt pin that handles RTC wakeup and is connected to the CPU and IO peripherals.. -Anand
diff --git a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts index 169ea283d4ee..a447cba4dd53 100644 --- a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts +++ b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts @@ -391,6 +391,20 @@ hdmi_tx_tmds_out: endpoint { }; }; +&i2c3 { + pinctrl-0 = <&i2c3_sda_a_pins>, <&i2c3_sck_a_pins>; + pinctrl-names = "default"; + status = "okay"; + + rtc: rtc@51 { + reg = <0x51>; + compatible = "nxp,pcf8563"; + #clock-cells = <0>; + clock-frequency = <32768>; + clock-output-names = "rtc_clkout"; + }; +}; + &ir { status = "okay"; pinctrl-0 = <&remote_input_ao_pins>;
Enable RTC PCF8563 node on Odroid-N2 SBC, In order to support the RTC wakealarm feature for suspend and resume. Cc: Neil Armstrong <narmstrong@baylibre.com> Cc: Kevin Hilman <khilman@baylibre.com> Signed-off-by: Anand Moon <linux.amoon@gmail.com> --- $ sudo hwclock -r && date 2020-07-15 13:11:53.862508+00:00 Wed Jul 15 13:11:54 UTC 2020 $ hwclock --show 2020-07-15 13:17:30.903300+00:00 But RTC wake up is not working at my end. Any inputs are welcome. $ time rtcwake -s 30 -m mem rtcwake: /dev/rtc0 not enabled for wakeup events real 0m0.002s user 0m0.002s sys 0m0.000s --- .../boot/dts/amlogic/meson-g12b-odroid-n2.dts | 14 ++++++++++++++ 1 file changed, 14 insertions(+)