diff mbox series

[for-5.1,3/3] file-posix: Fix leaked fd in raw_open_common() error path

Message ID 20200717105426.51134-4-kwolf@redhat.com (mailing list archive)
State New, archived
Headers show
Series file-posix: Fix check_hdev_writable() with auto-read-only | expand

Commit Message

Kevin Wolf July 17, 2020, 10:54 a.m. UTC 
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
 block/file-posix.c | 3 +++
 1 file changed, 3 insertions(+)

Comments

Max Reitz July 17, 2020, 11:55 a.m. UTC | #1 
On 17.07.20 12:54, Kevin Wolf wrote:
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
>  block/file-posix.c | 3 +++
>  1 file changed, 3 insertions(+)

Reviewed-by: Max Reitz <mreitz@redhat.com>
diff mbox series

Patch

diff --git a/block/file-posix.c b/block/file-posix.c
index 659f780570..b2ed9d7eb2 100644
--- a/block/file-posix.c
+++ b/block/file-posix.c
@@ -749,6 +749,9 @@  static int raw_open_common(BlockDriverState *bs, QDict *options,
     }
     ret = 0;
 fail:
+    if (ret < 0 && s->fd != -1) {
+        qemu_close(s->fd);
+    }
     if (filename && (bdrv_flags & BDRV_O_TEMPORARY)) {
         unlink(filename);
     }