| Message ID | 20200717165538.3275050-4-lee.jones@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Second batch of W=1 fixes for IIO | expand |
On Fri, 17 Jul 2020 17:55:11 +0100 Lee Jones <lee.jones@linaro.org> wrote: > Fixes the following W=1 kernel build warning(s): > > drivers/iio/adc/twl4030-madc.c:170: warning: Function parameter or member 'usb3v1' not described in 'twl4030_madc_data' > > Cc: J Keerthy <j-keerthy@ti.com> > Cc: Mikko Ylinen <mikko.k.ylinen@nokia.com> > Cc: Amit Kucheria <amit.kucheria@canonical.com> > Signed-off-by: Lee Jones <lee.jones@linaro.org> Applied with a note that this also cleans up the duplicate docs for lock. Thanks, Jonathan > --- > drivers/iio/adc/twl4030-madc.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/iio/adc/twl4030-madc.c b/drivers/iio/adc/twl4030-madc.c > index 826d8295e9b3c..882a678b44690 100644 > --- a/drivers/iio/adc/twl4030-madc.c > +++ b/drivers/iio/adc/twl4030-madc.c > @@ -153,7 +153,7 @@ enum sample_type { > * struct twl4030_madc_data - a container for madc info > * @dev: Pointer to device structure for madc > * @lock: Mutex protecting this data structure > - * @regulator: Pointer to bias regulator for madc > + * @usb3v1: Pointer to bias regulator for madc > * @requests: Array of request struct corresponding to SW1, SW2 and RT > * @use_second_irq: IRQ selection (main or co-processor) > * @imr: Interrupt mask register of MADC > @@ -161,7 +161,7 @@ enum sample_type { > */ > struct twl4030_madc_data { > struct device *dev; > - struct mutex lock; /* mutex protecting this data structure */ > + struct mutex lock; > struct regulator *usb3v1; > struct twl4030_madc_request requests[TWL4030_MADC_NUM_METHODS]; > bool use_second_irq;
diff --git a/drivers/iio/adc/twl4030-madc.c b/drivers/iio/adc/twl4030-madc.c index 826d8295e9b3c..882a678b44690 100644 --- a/drivers/iio/adc/twl4030-madc.c +++ b/drivers/iio/adc/twl4030-madc.c @@ -153,7 +153,7 @@ enum sample_type { * struct twl4030_madc_data - a container for madc info * @dev: Pointer to device structure for madc * @lock: Mutex protecting this data structure - * @regulator: Pointer to bias regulator for madc + * @usb3v1: Pointer to bias regulator for madc * @requests: Array of request struct corresponding to SW1, SW2 and RT * @use_second_irq: IRQ selection (main or co-processor) * @imr: Interrupt mask register of MADC @@ -161,7 +161,7 @@ enum sample_type { */ struct twl4030_madc_data { struct device *dev; - struct mutex lock; /* mutex protecting this data structure */ + struct mutex lock; struct regulator *usb3v1; struct twl4030_madc_request requests[TWL4030_MADC_NUM_METHODS]; bool use_second_irq;
Fixes the following W=1 kernel build warning(s): drivers/iio/adc/twl4030-madc.c:170: warning: Function parameter or member 'usb3v1' not described in 'twl4030_madc_data' Cc: J Keerthy <j-keerthy@ti.com> Cc: Mikko Ylinen <mikko.k.ylinen@nokia.com> Cc: Amit Kucheria <amit.kucheria@canonical.com> Signed-off-by: Lee Jones <lee.jones@linaro.org> --- drivers/iio/adc/twl4030-madc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)