[v4,3/6] dt-bindings: remoteproc: Add common TI SCI rproc bindings
diff mbox series

Message ID 20200717234800.9423-4-s-anna@ti.com
State New
Headers show
Series
  • TI K3 DSP remoteproc driver for C66x DSPs
Related show

Commit Message

Suman Anna July 17, 2020, 11:47 p.m. UTC
Add a bindings document that lists the common TI SCI properties
used by the K3 R5F and DSP remoteproc devices.

Signed-off-by: Suman Anna <s-anna@ti.com>
---
v4: Addressed both of Rob's review comments on ti,sci-proc-ids property
v3: https://patchwork.kernel.org/patch/11602317/

 .../bindings/remoteproc/ti,k3-sci-proc.yaml   | 48 +++++++++++++++++++
 1 file changed, 48 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/remoteproc/ti,k3-sci-proc.yaml

Comments

Rob Herring July 20, 2020, 10:17 p.m. UTC | #1
On Fri, 17 Jul 2020 18:47:57 -0500, Suman Anna wrote:
> Add a bindings document that lists the common TI SCI properties
> used by the K3 R5F and DSP remoteproc devices.
> 
> Signed-off-by: Suman Anna <s-anna@ti.com>
> ---
> v4: Addressed both of Rob's review comments on ti,sci-proc-ids property
> v3: https://patchwork.kernel.org/patch/11602317/
> 
>  .../bindings/remoteproc/ti,k3-sci-proc.yaml   | 48 +++++++++++++++++++
>  1 file changed, 48 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/remoteproc/ti,k3-sci-proc.yaml
> 

Please add Acked-by/Reviewed-by tags when posting new versions. However,
there's no need to repost patches *only* to add the tags. The upstream
maintainer will do that for acks received on the version they apply.

If a tag was not added on purpose, please state why and what changed.
Suman Anna July 20, 2020, 11:26 p.m. UTC | #2
On 7/20/20 5:17 PM, Rob Herring wrote:
> On Fri, 17 Jul 2020 18:47:57 -0500, Suman Anna wrote:
>> Add a bindings document that lists the common TI SCI properties
>> used by the K3 R5F and DSP remoteproc devices.
>>
>> Signed-off-by: Suman Anna <s-anna@ti.com>
>> ---
>> v4: Addressed both of Rob's review comments on ti,sci-proc-ids property
>> v3: https://patchwork.kernel.org/patch/11602317/
>>
>>   .../bindings/remoteproc/ti,k3-sci-proc.yaml   | 48 +++++++++++++++++++
>>   1 file changed, 48 insertions(+)
>>   create mode 100644 Documentation/devicetree/bindings/remoteproc/ti,k3-sci-proc.yaml
>>
> 
> Please add Acked-by/Reviewed-by tags when posting new versions. However,
> there's no need to repost patches *only* to add the tags. The upstream
> maintainer will do that for acks received on the version they apply.
> 
> If a tag was not added on purpose, please state why and what changed.

Rob,

You seem to have added your Reviewed-by tag by mistake on this 
particular patch [1], that's why I actually dropped it.

I do use pwclient, so the tags do get picked up automatically for my 
newer versions.

regards
Suman

[1] https://patchwork.kernel.org/comment/23484127/
Rob Herring July 21, 2020, 2:32 a.m. UTC | #3
On Fri, 17 Jul 2020 18:47:57 -0500, Suman Anna wrote:
> Add a bindings document that lists the common TI SCI properties
> used by the K3 R5F and DSP remoteproc devices.
> 
> Signed-off-by: Suman Anna <s-anna@ti.com>
> ---
> v4: Addressed both of Rob's review comments on ti,sci-proc-ids property
> v3: https://patchwork.kernel.org/patch/11602317/
> 
>  .../bindings/remoteproc/ti,k3-sci-proc.yaml   | 48 +++++++++++++++++++
>  1 file changed, 48 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/remoteproc/ti,k3-sci-proc.yaml
> 

Reviewed-by: Rob Herring <robh@kernel.org>
Rob Herring July 21, 2020, 3:53 p.m. UTC | #4
On Fri, Jul 17, 2020 at 5:48 PM Suman Anna <s-anna@ti.com> wrote:
>
> Add a bindings document that lists the common TI SCI properties
> used by the K3 R5F and DSP remoteproc devices.
>
> Signed-off-by: Suman Anna <s-anna@ti.com>
> ---
> v4: Addressed both of Rob's review comments on ti,sci-proc-ids property
> v3: https://patchwork.kernel.org/patch/11602317/
>
>  .../bindings/remoteproc/ti,k3-sci-proc.yaml   | 48 +++++++++++++++++++
>  1 file changed, 48 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/remoteproc/ti,k3-sci-proc.yaml
>
> diff --git a/Documentation/devicetree/bindings/remoteproc/ti,k3-sci-proc.yaml b/Documentation/devicetree/bindings/remoteproc/ti,k3-sci-proc.yaml
> new file mode 100644
> index 000000000000..0dca2ffdbc48
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/remoteproc/ti,k3-sci-proc.yaml
> @@ -0,0 +1,48 @@
> +# SPDX-License-Identifier: (GPL-2.0-only or BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/remoteproc/ti,k3-sci-proc.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Common TI K3 remote processor device bindings
> +
> +maintainers:
> +  - Suman Anna <s-anna@ti.com>
> +
> +description: |
> +  The TI K3 family of SoCs usually have one or more remote processor sub-systems
> +  like the dual-core R5F sub-system or a C66x or C71x DSP processor subsystem.
> +  The device management of these remote processors is managed by a dedicated
> +  System Processor, and the communication with that processor is managed through
> +  the TI-SCI protocol.
> +
> +  Each remote processor device node should define a common set of properties
> +  that allows the System Processor firmware to perform the device management
> +  such as powering the IPs, asserting/deasserting the resets for each of these
> +  processors.
> +
> +properties:
> +  ti,sci:
> +    $ref: /schemas/types.yaml#/definitions/phandle
> +    description:
> +      Should be a phandle to the TI-SCI System Controller node
> +
> +  ti,sci-dev-id:
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    description: |
> +      Should contain the TI-SCI device id corresponding to the remote processor
> +      core. Please refer to the corresponding System Controller documentation
> +      for valid values.

These also apply on Lokesh's series converting ti,sci-int[ra]
bindings. Please rework to use for both.

> +
> +  ti,sci-proc-ids:
> +    description: Should contain a single tuple of <proc_id host_id>.
> +    $ref: /schemas/types.yaml#/definitions/uint32-array
> +    items:
> +      - description: TI-SCI processor id for the remote processor device
> +      - description: TI-SCI host id to which processor control ownership
> +                     should be transferred to
> +
> +required:
> +  - ti,sci
> +  - ti,sci-dev-id
> +  - ti,sci-proc-ids
> --
> 2.26.0
>
Suman Anna July 21, 2020, 4:40 p.m. UTC | #5
Hi Rob,

On 7/21/20 10:53 AM, Rob Herring wrote:
> On Fri, Jul 17, 2020 at 5:48 PM Suman Anna <s-anna@ti.com> wrote:
>>
>> Add a bindings document that lists the common TI SCI properties
>> used by the K3 R5F and DSP remoteproc devices.
>>
>> Signed-off-by: Suman Anna <s-anna@ti.com>
>> ---
>> v4: Addressed both of Rob's review comments on ti,sci-proc-ids property
>> v3: https://patchwork.kernel.org/patch/11602317/
>>
>>   .../bindings/remoteproc/ti,k3-sci-proc.yaml   | 48 +++++++++++++++++++
>>   1 file changed, 48 insertions(+)
>>   create mode 100644 Documentation/devicetree/bindings/remoteproc/ti,k3-sci-proc.yaml
>>
>> diff --git a/Documentation/devicetree/bindings/remoteproc/ti,k3-sci-proc.yaml b/Documentation/devicetree/bindings/remoteproc/ti,k3-sci-proc.yaml
>> new file mode 100644
>> index 000000000000..0dca2ffdbc48
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/remoteproc/ti,k3-sci-proc.yaml
>> @@ -0,0 +1,48 @@
>> +# SPDX-License-Identifier: (GPL-2.0-only or BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/remoteproc/ti,k3-sci-proc.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Common TI K3 remote processor device bindings
>> +
>> +maintainers:
>> +  - Suman Anna <s-anna@ti.com>
>> +
>> +description: |
>> +  The TI K3 family of SoCs usually have one or more remote processor sub-systems
>> +  like the dual-core R5F sub-system or a C66x or C71x DSP processor subsystem.
>> +  The device management of these remote processors is managed by a dedicated
>> +  System Processor, and the communication with that processor is managed through
>> +  the TI-SCI protocol.
>> +
>> +  Each remote processor device node should define a common set of properties
>> +  that allows the System Processor firmware to perform the device management
>> +  such as powering the IPs, asserting/deasserting the resets for each of these
>> +  processors.
>> +
>> +properties:
>> +  ti,sci:
>> +    $ref: /schemas/types.yaml#/definitions/phandle
>> +    description:
>> +      Should be a phandle to the TI-SCI System Controller node
>> +
>> +  ti,sci-dev-id:
>> +    $ref: /schemas/types.yaml#/definitions/uint32
>> +    description: |
>> +      Should contain the TI-SCI device id corresponding to the remote processor
>> +      core. Please refer to the corresponding System Controller documentation
>> +      for valid values.
> 
> These also apply on Lokesh's series converting ti,sci-int[ra]
> bindings. Please rework to use for both.

OK.

> 
>> +
>> +  ti,sci-proc-ids:
>> +    description: Should contain a single tuple of <proc_id host_id>.
>> +    $ref: /schemas/types.yaml#/definitions/uint32-array
>> +    items:
>> +      - description: TI-SCI processor id for the remote processor device
>> +      - description: TI-SCI host id to which processor control ownership
>> +                     should be transferred to

This property is not required for the ti,sci-int[ra].

I can plan to move this to a common location like 
Documentation/devicetree/bindings/arm/keystone/ and let the individual 
bindings define the required properties. Does that sound ok to you?

regards
Suman

>> +
>> +required:
>> +  - ti,sci
>> +  - ti,sci-dev-id
>> +  - ti,sci-proc-ids
>> --
>> 2.26.0
>>
Suman Anna July 21, 2020, 10:44 p.m. UTC | #6
Hi Rob,

On 7/21/20 11:40 AM, Suman Anna wrote:
> Hi Rob,
> 
> On 7/21/20 10:53 AM, Rob Herring wrote:
>> On Fri, Jul 17, 2020 at 5:48 PM Suman Anna <s-anna@ti.com> wrote:
>>>
>>> Add a bindings document that lists the common TI SCI properties
>>> used by the K3 R5F and DSP remoteproc devices.
>>>
>>> Signed-off-by: Suman Anna <s-anna@ti.com>
>>> ---
>>> v4: Addressed both of Rob's review comments on ti,sci-proc-ids property
>>> v3: https://patchwork.kernel.org/patch/11602317/
>>>
>>>   .../bindings/remoteproc/ti,k3-sci-proc.yaml   | 48 +++++++++++++++++++
>>>   1 file changed, 48 insertions(+)
>>>   create mode 100644 
>>> Documentation/devicetree/bindings/remoteproc/ti,k3-sci-proc.yaml
>>>
>>> diff --git 
>>> a/Documentation/devicetree/bindings/remoteproc/ti,k3-sci-proc.yaml 
>>> b/Documentation/devicetree/bindings/remoteproc/ti,k3-sci-proc.yaml
>>> new file mode 100644
>>> index 000000000000..0dca2ffdbc48
>>> --- /dev/null
>>> +++ b/Documentation/devicetree/bindings/remoteproc/ti,k3-sci-proc.yaml
>>> @@ -0,0 +1,48 @@
>>> +# SPDX-License-Identifier: (GPL-2.0-only or BSD-2-Clause)
>>> +%YAML 1.2
>>> +---
>>> +$id: http://devicetree.org/schemas/remoteproc/ti,k3-sci-proc.yaml#
>>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>>> +
>>> +title: Common TI K3 remote processor device bindings
>>> +
>>> +maintainers:
>>> +  - Suman Anna <s-anna@ti.com>
>>> +
>>> +description: |
>>> +  The TI K3 family of SoCs usually have one or more remote processor 
>>> sub-systems
>>> +  like the dual-core R5F sub-system or a C66x or C71x DSP processor 
>>> subsystem.
>>> +  The device management of these remote processors is managed by a 
>>> dedicated
>>> +  System Processor, and the communication with that processor is 
>>> managed through
>>> +  the TI-SCI protocol.
>>> +
>>> +  Each remote processor device node should define a common set of 
>>> properties
>>> +  that allows the System Processor firmware to perform the device 
>>> management
>>> +  such as powering the IPs, asserting/deasserting the resets for 
>>> each of these
>>> +  processors.
>>> +
>>> +properties:
>>> +  ti,sci:
>>> +    $ref: /schemas/types.yaml#/definitions/phandle
>>> +    description:
>>> +      Should be a phandle to the TI-SCI System Controller node
>>> +
>>> +  ti,sci-dev-id:
>>> +    $ref: /schemas/types.yaml#/definitions/uint32
>>> +    description: |
>>> +      Should contain the TI-SCI device id corresponding to the 
>>> remote processor
>>> +      core. Please refer to the corresponding System Controller 
>>> documentation
>>> +      for valid values.
>>
>> These also apply on Lokesh's series converting ti,sci-int[ra]
>> bindings. Please rework to use for both.
> 
> OK.

OK, I have reworked for this and posted it [1] as part of v5 of this series.

regards
Suman

[1] https://patchwork.kernel.org/patch/11676821/

> 
>>
>>> +
>>> +  ti,sci-proc-ids:
>>> +    description: Should contain a single tuple of <proc_id host_id>.
>>> +    $ref: /schemas/types.yaml#/definitions/uint32-array
>>> +    items:
>>> +      - description: TI-SCI processor id for the remote processor 
>>> device
>>> +      - description: TI-SCI host id to which processor control 
>>> ownership
>>> +                     should be transferred to
> 
> This property is not required for the ti,sci-int[ra].
> 
> I can plan to move this to a common location like 
> Documentation/devicetree/bindings/arm/keystone/ and let the individual 
> bindings define the required properties. Does that sound ok to you?
> 
> regards
> Suman
> 
>>> +
>>> +required:
>>> +  - ti,sci
>>> +  - ti,sci-dev-id
>>> +  - ti,sci-proc-ids
>>> -- 
>>> 2.26.0
>>>
>

Patch
diff mbox series

diff --git a/Documentation/devicetree/bindings/remoteproc/ti,k3-sci-proc.yaml b/Documentation/devicetree/bindings/remoteproc/ti,k3-sci-proc.yaml
new file mode 100644
index 000000000000..0dca2ffdbc48
--- /dev/null
+++ b/Documentation/devicetree/bindings/remoteproc/ti,k3-sci-proc.yaml
@@ -0,0 +1,48 @@ 
+# SPDX-License-Identifier: (GPL-2.0-only or BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/remoteproc/ti,k3-sci-proc.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Common TI K3 remote processor device bindings
+
+maintainers:
+  - Suman Anna <s-anna@ti.com>
+
+description: |
+  The TI K3 family of SoCs usually have one or more remote processor sub-systems
+  like the dual-core R5F sub-system or a C66x or C71x DSP processor subsystem.
+  The device management of these remote processors is managed by a dedicated
+  System Processor, and the communication with that processor is managed through
+  the TI-SCI protocol.
+
+  Each remote processor device node should define a common set of properties
+  that allows the System Processor firmware to perform the device management
+  such as powering the IPs, asserting/deasserting the resets for each of these
+  processors.
+
+properties:
+  ti,sci:
+    $ref: /schemas/types.yaml#/definitions/phandle
+    description:
+      Should be a phandle to the TI-SCI System Controller node
+
+  ti,sci-dev-id:
+    $ref: /schemas/types.yaml#/definitions/uint32
+    description: |
+      Should contain the TI-SCI device id corresponding to the remote processor
+      core. Please refer to the corresponding System Controller documentation
+      for valid values.
+
+  ti,sci-proc-ids:
+    description: Should contain a single tuple of <proc_id host_id>.
+    $ref: /schemas/types.yaml#/definitions/uint32-array
+    items:
+      - description: TI-SCI processor id for the remote processor device
+      - description: TI-SCI host id to which processor control ownership
+                     should be transferred to
+
+required:
+  - ti,sci
+  - ti,sci-dev-id
+  - ti,sci-proc-ids