@@ -1030,12 +1030,15 @@ static void rsxx_pci_remove(struct pci_dev *dev)
kfree(card);
}
-static int rsxx_pci_suspend(struct pci_dev *dev, pm_message_t state)
+static int __maybe_unused rsxx_pci_suspend(
+ __attribute__((unused)) struct device *dev)
{
/* We don't support suspend at this time. */
return -ENOSYS;
}
+#define rsxx_pci_resume NULL
+
static void rsxx_pci_shutdown(struct pci_dev *dev)
{
struct rsxx_cardinfo *card = pci_get_drvdata(dev);
@@ -1071,12 +1074,14 @@ static const struct pci_device_id rsxx_pci_ids[] = {
MODULE_DEVICE_TABLE(pci, rsxx_pci_ids);
+static SIMPLE_DEV_PM_OPS(rsxx_pci_pm_ops, rsxx_pci_suspend, rsxx_pci_resume);
+
static struct pci_driver rsxx_pci_driver = {
.name = DRIVER_NAME,
.id_table = rsxx_pci_ids,
.probe = rsxx_pci_probe,
.remove = rsxx_pci_remove,
- .suspend = rsxx_pci_suspend,
+ .driver.pm = &rsxx_pci_pm_ops,
.shutdown = rsxx_pci_shutdown,
.err_handler = &rsxx_err_handler,
};
Drivers using legacy PM have to manage PCI states and device's PM states themselves. They also need to take care of configuration registers. With improved and powerful support of generic PM, PCI Core takes care of above mentioned, device-independent, jobs. This driver has not defined .resume(), hence define it as NULL. Change function parameter in both .suspend() to "struct device*" type and mark the parameter as "__attribute__((unused)) " as the function body is empty. Compile-tested only. Signed-off-by: Vaibhav Gupta <vaibhavgupta40@gmail.com> --- drivers/block/rsxx/core.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-)