diff mbox series

[3/3] README: Add steps to build cip-security image

Message ID 20200721081645.1789-3-venkata.pyla@toshiba-tsip.com (mailing list archive)
State Accepted
Headers show
Series [1/3] cip-security: Add packages for IEC-62443-4-2 Evaluation. | expand

Commit Message

Venkata Pyla July 21, 2020, 8:16 a.m. UTC 
From: venkata <venkata.pyla@toshiba-tsip.com>

Signed-off-by: venkata <venkata.pyla@toshiba-tsip.com>
---
 README.md | 10 ++++++++++
 1 file changed, 10 insertions(+)

Comments

Jan Kiszka July 23, 2020, 10:40 a.m. UTC | #1 
On 21.07.20 10:16, Venkata Pyla wrote:
> From: venkata <venkata.pyla@toshiba-tsip.com>
> 
> Signed-off-by: venkata <venkata.pyla@toshiba-tsip.com>
> ---
>   README.md | 10 ++++++++++
>   1 file changed, 10 insertions(+)
> 
> diff --git a/README.md b/README.md
> index bbad1a0..b2c4166 100644
> --- a/README.md
> +++ b/README.md
> @@ -36,6 +36,16 @@ card, run
>       dd if=build/tmp/deploy/images/bbb/cip-core-image-cip-core-buster-bbb.wic.img \
>          of=/dev/<medium-device> bs=1M status=progress
>   
> +## Building Security target images
> +Building images for QEMU x86-64bit machine
> +
> +    ./kas-docker --isar build --target cip-core-image-security kas.yml:board-qemu-amd64.yml
> +
> +Run the generated securiy images on QEMU (x86-64bit)
> +
> +    TARGET_IMAGE=cip-core-image-security ./start-qemu.sh amd64
> +
> +
>   ## Community Resources
>   
>   TBD
> 

This patch is fine, but I'm missing 4/4: Add this image to CI (same 
comment as I had on the MR on gitlab).

Jan
Venkata Pyla July 24, 2020, 6:58 a.m. UTC | #2 
Hi Jan,

On Thu, Jul 23, 2020 at 04:10 PM, Jan Kiszka wrote:

>
> On 21.07.20 10:16, Venkata Pyla wrote:
> > From: venkata <venkata.pyla@toshiba-tsip.com>
> > 
> > Signed-off-by: venkata <venkata.pyla@toshiba-tsip.com>
> > ---
> >   README.md | 10 ++++++++++
> >   1 file changed, 10 insertions(+)
> > 
> > diff --git a/README.md b/README.md
> > index bbad1a0..b2c4166 100644
> > --- a/README.md
> > +++ b/README.md
> > @@ -36,6 +36,16 @@ card, run
> >       dd
> if=build/tmp/deploy/images/bbb/cip-core-image-cip-core-buster-bbb.wic.img \
> >          of=/dev/<medium-device> bs=1M status=progress
> >   
> > +## Building Security target images
> > +Building images for QEMU x86-64bit machine
> > +
> > +    ./kas-docker --isar build --target cip-core-image-security
> kas.yml:board-qemu-amd64.yml
> > +
> > +Run the generated securiy images on QEMU (x86-64bit)
> > +
> > +    TARGET_IMAGE=cip-core-image-security ./start-qemu.sh amd64
> > +
> > +
> >   ## Community Resources
> >   
> >   TBD
> > 
> 
> This patch is fine, but I'm missing 4/4: Add this image to CI (same 
> comment as I had on the MR on gitlab).
> 

Adding cip security image to CI, 
i need some suggestions to use the current format present in .gitlab-ci.yml

Currently i have the below problem for using script deploy-cip-core.sh:
1. image name formation in the script should have another variable
         .../$IMG_PREFIX-cip-core-$RELEASE-$TARGET
         where $IMG_PREFIX is default to "cip-core-image"  if not specified
          for security image it will be passed as 4th argument "cip-core-image-security"
2. currently scrit is expecting the image format in *.wic.img so,
       for qemu i think we should have wks file to generate image with format .wic.img

or for this security image do we need to deploy it seperatley?
please guide me

Thanks

> Jan
> 
> -- 
> Siemens AG, Corporate Technology, CT RDA IOT SES-DE
> Corporate Competence Center Embedded Linux
>
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#4992): https://lists.cip-project.org/g/cip-dev/message/4992
Mute This Topic: https://lists.cip-project.org/mt/75699595/4520428
Group Owner: cip-dev+owner@lists.cip-project.org
Unsubscribe: https://lists.cip-project.org/g/cip-dev/leave/8129116/1171672734/xyzzy  [patchwork-cip-dev@patchwork.kernel.org]
-=-=-=-=-=-=-=-=-=-=-=-
Daniel Sangorrin July 30, 2020, 12:07 a.m. UTC | #3 
Hi Venkata-san

Maybe Jan didn't see your e-mail because he wasn't in the CC.

> -----Original Message-----
> From: cip-dev@lists.cip-project.org <cip-dev@lists.cip-project.org> On Behalf Of Venkata Pyla
> Sent: Friday, July 24, 2020 3:58 PM
> To: cip-dev@lists.cip-project.org
> Subject: Re: [cip-dev] [PATCH 3/3] README: Add steps to build cip-security image
> 
> Hi Jan,
> 
> On Thu, Jul 23, 2020 at 04:10 PM, Jan Kiszka wrote:
> 
> >
> > On 21.07.20 10:16, Venkata Pyla wrote:
> > > From: venkata <venkata.pyla@toshiba-tsip.com>
> > >
> > > Signed-off-by: venkata <venkata.pyla@toshiba-tsip.com>
> > > ---
> > >   README.md | 10 ++++++++++
> > >   1 file changed, 10 insertions(+)
> > >
> > > diff --git a/README.md b/README.md
> > > index bbad1a0..b2c4166 100644
> > > --- a/README.md
> > > +++ b/README.md
> > > @@ -36,6 +36,16 @@ card, run
> > >       dd
> > if=build/tmp/deploy/images/bbb/cip-core-image-cip-core-buster-bbb.wic.
> > img \
> > >          of=/dev/<medium-device> bs=1M status=progress
> > >
> > > +## Building Security target images
> > > +Building images for QEMU x86-64bit machine
> > > +
> > > +    ./kas-docker --isar build --target cip-core-image-security
> > kas.yml:board-qemu-amd64.yml
> > > +
> > > +Run the generated securiy images on QEMU (x86-64bit)
> > > +
> > > +    TARGET_IMAGE=cip-core-image-security ./start-qemu.sh amd64
> > > +
> > > +
> > >   ## Community Resources
> > >
> > >   TBD
> > >
> >
> > This patch is fine, but I'm missing 4/4: Add this image to CI (same
> > comment as I had on the MR on gitlab).
> >
> 
> Adding cip security image to CI,
> i need some suggestions to use the current format present in .gitlab-ci.yml
> 
> Currently i have the below problem for using script deploy-cip-core.sh:
> 1. image name formation in the script should have another variable
>          .../$IMG_PREFIX-cip-core-$RELEASE-$TARGET
>          where $IMG_PREFIX is default to "cip-core-image"  if not specified
>           for security image it will be passed as 4th argument "cip-core-image-security"
> 2. currently scrit is expecting the image format in *.wic.img so,
>        for qemu i think we should have wks file to generate image with format .wic.img
> 
> or for this security image do we need to deploy it seperatley?
> please guide me

Sometimes it is better to send a patch instead of trying to explain it with words.

Thanks,
Daniel
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#5053): https://lists.cip-project.org/g/cip-dev/message/5053
Mute This Topic: https://lists.cip-project.org/mt/75699595/4520428
Group Owner: cip-dev+owner@lists.cip-project.org
Unsubscribe: https://lists.cip-project.org/g/cip-dev/leave/8129116/1171672734/xyzzy  [patchwork-cip-dev@patchwork.kernel.org]
-=-=-=-=-=-=-=-=-=-=-=-
Jan Kiszka July 30, 2020, 5:59 a.m. UTC | #4 
On 30.07.20 02:07, daniel.sangorrin@toshiba.co.jp wrote:
> Hi Venkata-san
> 
> Maybe Jan didn't see your e-mail because he wasn't in the CC.
> 
>> -----Original Message-----
>> From: cip-dev@lists.cip-project.org <cip-dev@lists.cip-project.org> On Behalf Of Venkata Pyla
>> Sent: Friday, July 24, 2020 3:58 PM
>> To: cip-dev@lists.cip-project.org
>> Subject: Re: [cip-dev] [PATCH 3/3] README: Add steps to build cip-security image
>>
>> Hi Jan,
>>
>> On Thu, Jul 23, 2020 at 04:10 PM, Jan Kiszka wrote:
>>
>>>
>>> On 21.07.20 10:16, Venkata Pyla wrote:
>>>> From: venkata <venkata.pyla@toshiba-tsip.com>
>>>>
>>>> Signed-off-by: venkata <venkata.pyla@toshiba-tsip.com>
>>>> ---
>>>>    README.md | 10 ++++++++++
>>>>    1 file changed, 10 insertions(+)
>>>>
>>>> diff --git a/README.md b/README.md
>>>> index bbad1a0..b2c4166 100644
>>>> --- a/README.md
>>>> +++ b/README.md
>>>> @@ -36,6 +36,16 @@ card, run
>>>>        dd
>>> if=build/tmp/deploy/images/bbb/cip-core-image-cip-core-buster-bbb.wic.
>>> img \
>>>>           of=/dev/<medium-device> bs=1M status=progress
>>>>
>>>> +## Building Security target images
>>>> +Building images for QEMU x86-64bit machine
>>>> +
>>>> +    ./kas-docker --isar build --target cip-core-image-security
>>> kas.yml:board-qemu-amd64.yml
>>>> +
>>>> +Run the generated securiy images on QEMU (x86-64bit)
>>>> +
>>>> +    TARGET_IMAGE=cip-core-image-security ./start-qemu.sh amd64
>>>> +
>>>> +
>>>>    ## Community Resources
>>>>
>>>>    TBD
>>>>
>>>
>>> This patch is fine, but I'm missing 4/4: Add this image to CI (same
>>> comment as I had on the MR on gitlab).
>>>
>>
>> Adding cip security image to CI,
>> i need some suggestions to use the current format present in .gitlab-ci.yml
>>
>> Currently i have the below problem for using script deploy-cip-core.sh:
>> 1. image name formation in the script should have another variable
>>           .../$IMG_PREFIX-cip-core-$RELEASE-$TARGET
>>           where $IMG_PREFIX is default to "cip-core-image"  if not specified
>>            for security image it will be passed as 4th argument "cip-core-image-security"
>> 2. currently scrit is expecting the image format in *.wic.img so,
>>         for qemu i think we should have wks file to generate image with format .wic.img
>>
>> or for this security image do we need to deploy it seperatley?
>> please guide me
> 
> Sometimes it is better to send a patch instead of trying to explain it with words.
> 

I've replied on the deployment question already.

If there is a need for the security artifacts already, we need to 
enhance the deployment for that particular use case - but I doubt there 
is at this point, otherwise the series had carried CI in the first place.

Jan
diff mbox series

Patch

diff --git a/README.md b/README.md
index bbad1a0..b2c4166 100644
--- a/README.md
+++ b/README.md
@@ -36,6 +36,16 @@  card, run
     dd if=build/tmp/deploy/images/bbb/cip-core-image-cip-core-buster-bbb.wic.img \
        of=/dev/<medium-device> bs=1M status=progress
 
+## Building Security target images
+Building images for QEMU x86-64bit machine
+
+    ./kas-docker --isar build --target cip-core-image-security kas.yml:board-qemu-amd64.yml
+
+Run the generated securiy images on QEMU (x86-64bit)
+
+    TARGET_IMAGE=cip-core-image-security ./start-qemu.sh amd64
+
+
 ## Community Resources
 
 TBD